Files
cacti/tests/Unit/Scripts/SsHstatsTest.php
Sean Mancini 96033267cb refactor(tests): reorganize unit tests into domain category folders (#7733)
* refactor(tests): reorganize unit tests into domain category folders

- Consolidate per-advisory GHSA regression tests into Security/ subfolders by vuln class
- Group all 186 test files into domain folders: DataCollection/, Ui/, Core/,
  Database/, Installer/, Scripts/, Security/, Plugin/
- Strip GitHub issue/GHSA numbers from filenames; keep IDs in test descriptions
- Fix all __DIR__ relative paths to match new folder nesting depth
- Update CI workflow path triggers and phpunit XML configs for new file locations
- Update .github/copilot-instructions.md with unit test organization guidelines
- Add tests/vendor/ to .gitignore

* add gaurds

* fix up guard for unit tests

* fix redeclaration of cacti_log in tests

* fix updates to unit tests

* fix test patjhs

* fix: update test __DIR__ paths for reorganized test structure

* fix: conditionally define read_user_setting to prevent redeclaration in tests

* fix: conditionally define functions to prevent redeclaration in tests

- Wrap clean_up_lines, raise_message, cacti_debug_backtrace, and get_debug_prefix
  with function_exists() checks to prevent conflicts when test stubs are loaded
  before lib/functions.php in the same PHP process

* fix: add unit test bootstrap to prevent function redeclaration errors

- Create tests/bootstrap-unit.php to load core libraries before tests
- Ensures lib/functions.php loads before test stubs define stub functions
- Test stubs use function_exists() checks, so they detect pre-loaded functions
- Update phpunit.xml to use bootstrap-unit.php for Unit testsuite
- Fixes 'Cannot redeclare read_user_setting()' errors when tests run in same process

* fix: load test stubs before global.php in unit test bootstrap

- Reorder bootstrap to load CactiStubs.php and UnitStubs.php first
- Ensures stub functions like __() are available when global.php loads
- global.php calls get_cacti_version_text() which needs __() for translations
- Fixes 'Call to undefined function __()' error during bootstrap

* fix: remove function conflicts from test stubs

- Remove stub definitions for functions already in lib/functions.php:
  cacti_sizeof, cacti_log, cacti_strtolower, read_config_option,
  read_user_setting, cacti_count
- Keep translation function stubs (__(), __esc()) needed by global.php
- Update bootstrap to load lib/functions.php after stubs
- This prevents function redeclaration errors while maintaining test isolation

* fix: prevent constant and variable redeclaration in bootstrap

- Remove explicit PHP_TESTING and CACTI_TEST_BOOTSTRAP defines from bootstrap
  (CactiStubs.php now handles this with guards)
- Add guards to CactiStubs.php to prevent redefinition of PHP_TESTING
- Only set CACTI_TEST_BOOTSTRAP env vars if not already set
- Fixes PHP warnings about 'Constant X already defined'

* fix: remove redundant lib/functions.php load from bootstrap

include/global.php already loads lib/functions.php at lines 287-288.
The bootstrap was trying to load it again after global.php, but global.php
needs format_cacti_version() to be available on lines 293-294 to define
CACTI_VERSION and CACTI_VERSION_FULL constants.

Solution: Let global.php handle loading lib/functions.php itself, and don't
load it separately in the bootstrap.

* fix: remove more conflicting function stubs from test helpers

- Remove stubs for functions also defined in lib/functions.php:
  raise_message, clean_up_lines, cacti_debug_backtrace, get_debug_prefix
- Remove POLLER_ID constant stub (defined unconditionally by global.php)
- Keep only translation functions and test-specific helpers
- This prevents function/constant redeclaration errors

* fix: minimize test stubs to only translation functions

Remove ALL helper functions and constants from UnitStubs.php that are:
- Defined in lib/functions.php (raise_message, clean_up_lines, etc.)
- Defined in lib/html_utility.php (srv, set_request_var)
- Defined in global_constants.php (POLLER_VERBOSITY_*, MESSAGE_LEVEL_*)
- Defined in global.php (POLLER_ID)

Keep ONLY translation functions (__(), __esc()) that are:
- Called by global.php during initialization
- Not defined elsewhere
- Required for proper bootstrap sequence

This eliminates all constant and function redeclaration errors.

* fix: remove __esc stub - already defined in global_languages.php

Keep only __() translation function stub, which is needed by global.php
and not defined elsewhere in Cacti core.

* fix: handle no-arg case in __() translation stub

The __() function may be called with just a string and no format arguments.
Previously, vsprintf() would fail with 'arguments array must contain 2 items'.
Now, if no args are provided, return the text as-is.
2026-08-16 19:23:31 -07:00

110 lines
4.3 KiB
PHP

<?php
/*
+-------------------------------------------------------------------------+
| Copyright (C) 2004-2026 The Cacti Group |
| |
| This program is free software; you can redistribute it and/or |
| modify it under the terms of the GNU General Public License |
| as published by the Free Software Foundation; either version 2 |
| of the License, or (at your option) any later version. |
| |
| This program is distributed in the hope that it will be useful, |
| but WITHOUT ANY WARRANTY; without even the implied warranty of |
| MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
| GNU General Public License for more details. |
+-------------------------------------------------------------------------+
| Cacti: The Complete RRDtool-based Graphing Solution |
+-------------------------------------------------------------------------+
| This code is designed, written, and maintained by the Cacti Group. See |
| about.php and/or the AUTHORS file for specific developer information. |
+-------------------------------------------------------------------------+
| http://www.cacti.net/ |
+-------------------------------------------------------------------------+
*/
/*
* Tests for scripts/ss_hstats.php switch case consolidation.
*
* Verifies that consolidating 8 duplicate case branches into a single
* fall-through case maintains identical behavior for all stat types.
*
* The function ss_hstats() had 8 cases that all executed `$column = $stat;`,
* and one special case 'uptime' that maps to 'snmp_sysUpTimeInstance'.
* After consolidation, the 8 cases use fall-through pattern.
*/
// Set script server mode to prevent CLI initialization
// Declared as global to ensure proper scope when loaded by PHPUnit
global $called_by_script_server;
$called_by_script_server = true;
require_once __DIR__ . '/../../../scripts/ss_hstats.php';
// Test stat-to-column mapping function directly (verifies switch logic)
test('polling_time maps to polling_time column', function () {
expect(ss_hstats_map_stat_to_column('polling_time'))->toBe('polling_time');
});
test('min_time maps to min_time column', function () {
expect(ss_hstats_map_stat_to_column('min_time'))->toBe('min_time');
});
test('max_time maps to max_time column', function () {
expect(ss_hstats_map_stat_to_column('max_time'))->toBe('max_time');
});
test('cur_time maps to cur_time column', function () {
expect(ss_hstats_map_stat_to_column('cur_time'))->toBe('cur_time');
});
test('avg_time maps to avg_time column', function () {
expect(ss_hstats_map_stat_to_column('avg_time'))->toBe('avg_time');
});
test('failed_polls maps to failed_polls column', function () {
expect(ss_hstats_map_stat_to_column('failed_polls'))->toBe('failed_polls');
});
test('availability maps to availability column', function () {
expect(ss_hstats_map_stat_to_column('availability'))->toBe('availability');
});
test('current_errors maps to current_errors column', function () {
expect(ss_hstats_map_stat_to_column('current_errors'))->toBe('current_errors');
});
test('uptime maps to snmp_sysUpTimeInstance column', function () {
expect(ss_hstats_map_stat_to_column('uptime'))->toBe('snmp_sysUpTimeInstance');
});
test('invalid stat returns null', function () {
expect(ss_hstats_map_stat_to_column('invalid_stat'))->toBeNull();
});
test('empty stat returns null', function () {
expect(ss_hstats_map_stat_to_column(''))->toBeNull();
});
test('all identity-mapped stats return the stat name as column', function () {
$identity_stats = [
'polling_time',
'min_time',
'max_time',
'cur_time',
'avg_time',
'failed_polls',
'availability',
'current_errors',
];
foreach ($identity_stats as $stat) {
expect(ss_hstats_map_stat_to_column($stat))->toBe($stat);
}
});
// Test ss_hstats() wrapper behavior with host_id=0
test('ss_hstats returns U when host_id is zero', function () {
expect(ss_hstats(0, 'polling_time'))->toBe('U')
->and(ss_hstats(0, 'uptime'))->toBe('U')
->and(ss_hstats(0, 'invalid'))->toBe('U');
});