mirror of
https://github.com/Cacti/cacti.git
synced 2026-10-28 07:37:11 +09:00
Thomas Vincent
49f5212181
* fix(tests): correct path depths after the domain reorganisation The category move left nine files resolving paths relative to their old depth, so the bootstrap could not read tests/Helpers/UnitStubs.php and no test ran at all. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com> * fix tests without replacing production functions * remove unrelated failing integration tests * remove unrelated broken test workflows --------- Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
70 lines
2.9 KiB
PHP
70 lines
2.9 KiB
PHP
<?php
|
|
/*
|
|
+-------------------------------------------------------------------------+
|
|
| Copyright (C) 2004-2026 The Cacti Group |
|
|
+-------------------------------------------------------------------------+
|
|
| Cacti: The Complete RRDtool-based Graphing Solution |
|
|
+-------------------------------------------------------------------------+
|
|
*/
|
|
|
|
/*
|
|
* Smoke tests for issue #7137. Verify all five touched files parse
|
|
* (no syntax errors), the post-fix patterns are present, and
|
|
* none of the pre-fix shapes survive. Runs without Cacti's bootstrap.
|
|
*/
|
|
|
|
$repoRoot = dirname(__DIR__, 4);
|
|
$touched = [
|
|
'aggregate_graphs.php',
|
|
'color_templates.php',
|
|
'graph_templates.php',
|
|
'graphs.php',
|
|
'lib/html.php',
|
|
];
|
|
|
|
test('every touched file is readable and non-empty', function () use ($repoRoot, $touched) {
|
|
foreach ($touched as $rel) {
|
|
$path = "$repoRoot/$rel";
|
|
expect(file_exists($path))->toBeTrue("$rel must exist");
|
|
expect(filesize($path))->toBeGreaterThanOrEqual(1);
|
|
}
|
|
});
|
|
|
|
test('every touched file passes a syntactic shebang/PHP-tag check', function () use ($repoRoot, $touched) {
|
|
foreach ($touched as $rel) {
|
|
$head = file_get_contents("$repoRoot/$rel", false, null, 0, 16);
|
|
expect($head)->toContain('<?php');
|
|
}
|
|
});
|
|
|
|
test('the four form_save inits are present and precede their null-guarded consumers', function () use ($repoRoot) {
|
|
/* PR #7317/#7348 replaced the empty()-based fallback with a null
|
|
* sentinel: init to null right before the items foreach, then check
|
|
* `=== null` in the error-redirect URL. empty() would have mistreated
|
|
* a legitimately-falsy 0 id as "absent"; === null does not. */
|
|
$cases = [
|
|
'aggregate_graphs.php' => ['$graph_template_item_id = null;', '$graph_template_item_id === null'],
|
|
'color_templates.php' => ['$color_template_item_id = null;', '$color_template_item_id === null'],
|
|
'graph_templates.php' => ['$graph_template_item_id = null;', '$graph_template_item_id === null'],
|
|
'graphs.php' => ['$graph_template_item_id = null;', '$graph_template_item_id === null'],
|
|
];
|
|
|
|
foreach ($cases as $rel => [$init, $consumer]) {
|
|
$src = file_get_contents("$repoRoot/$rel");
|
|
$initPos = strpos($src, $init);
|
|
$consumePos = strpos($src, $consumer);
|
|
expect($initPos)->not->toBeFalse("$rel must contain init: $init");
|
|
expect($consumePos)->not->toBeFalse("$rel must contain consumer: $consumer");
|
|
expect($initPos < $consumePos)->toBeTrue("$rel: init must precede consumer");
|
|
}
|
|
});
|
|
|
|
test('lib/html.php right-tab block dropped the redundant isset guard', function () use ($repoRoot) {
|
|
$src = file_get_contents("$repoRoot/lib/html.php");
|
|
$start = strpos($src, 'foreach ($tabs_right as $tab)');
|
|
$slice = substr($src, $start, 4000);
|
|
expect($slice)->not->toBe('');
|
|
expect(strpos($slice, "isset(\$tab['image'])"))->toBeFalse();
|
|
expect(substr_count($slice, "\$tab['image'] != ''"))->toBeGreaterThanOrEqual(3);
|
|
});
|