Files
cacti/tests/Unit/Ui/Utility/SupportDiagnosticsTest.php
Sean Mancini 96033267cb refactor(tests): reorganize unit tests into domain category folders (#7733)
* refactor(tests): reorganize unit tests into domain category folders

- Consolidate per-advisory GHSA regression tests into Security/ subfolders by vuln class
- Group all 186 test files into domain folders: DataCollection/, Ui/, Core/,
  Database/, Installer/, Scripts/, Security/, Plugin/
- Strip GitHub issue/GHSA numbers from filenames; keep IDs in test descriptions
- Fix all __DIR__ relative paths to match new folder nesting depth
- Update CI workflow path triggers and phpunit XML configs for new file locations
- Update .github/copilot-instructions.md with unit test organization guidelines
- Add tests/vendor/ to .gitignore

* add gaurds

* fix up guard for unit tests

* fix redeclaration of cacti_log in tests

* fix updates to unit tests

* fix test patjhs

* fix: update test __DIR__ paths for reorganized test structure

* fix: conditionally define read_user_setting to prevent redeclaration in tests

* fix: conditionally define functions to prevent redeclaration in tests

- Wrap clean_up_lines, raise_message, cacti_debug_backtrace, and get_debug_prefix
  with function_exists() checks to prevent conflicts when test stubs are loaded
  before lib/functions.php in the same PHP process

* fix: add unit test bootstrap to prevent function redeclaration errors

- Create tests/bootstrap-unit.php to load core libraries before tests
- Ensures lib/functions.php loads before test stubs define stub functions
- Test stubs use function_exists() checks, so they detect pre-loaded functions
- Update phpunit.xml to use bootstrap-unit.php for Unit testsuite
- Fixes 'Cannot redeclare read_user_setting()' errors when tests run in same process

* fix: load test stubs before global.php in unit test bootstrap

- Reorder bootstrap to load CactiStubs.php and UnitStubs.php first
- Ensures stub functions like __() are available when global.php loads
- global.php calls get_cacti_version_text() which needs __() for translations
- Fixes 'Call to undefined function __()' error during bootstrap

* fix: remove function conflicts from test stubs

- Remove stub definitions for functions already in lib/functions.php:
  cacti_sizeof, cacti_log, cacti_strtolower, read_config_option,
  read_user_setting, cacti_count
- Keep translation function stubs (__(), __esc()) needed by global.php
- Update bootstrap to load lib/functions.php after stubs
- This prevents function redeclaration errors while maintaining test isolation

* fix: prevent constant and variable redeclaration in bootstrap

- Remove explicit PHP_TESTING and CACTI_TEST_BOOTSTRAP defines from bootstrap
  (CactiStubs.php now handles this with guards)
- Add guards to CactiStubs.php to prevent redefinition of PHP_TESTING
- Only set CACTI_TEST_BOOTSTRAP env vars if not already set
- Fixes PHP warnings about 'Constant X already defined'

* fix: remove redundant lib/functions.php load from bootstrap

include/global.php already loads lib/functions.php at lines 287-288.
The bootstrap was trying to load it again after global.php, but global.php
needs format_cacti_version() to be available on lines 293-294 to define
CACTI_VERSION and CACTI_VERSION_FULL constants.

Solution: Let global.php handle loading lib/functions.php itself, and don't
load it separately in the bootstrap.

* fix: remove more conflicting function stubs from test helpers

- Remove stubs for functions also defined in lib/functions.php:
  raise_message, clean_up_lines, cacti_debug_backtrace, get_debug_prefix
- Remove POLLER_ID constant stub (defined unconditionally by global.php)
- Keep only translation functions and test-specific helpers
- This prevents function/constant redeclaration errors

* fix: minimize test stubs to only translation functions

Remove ALL helper functions and constants from UnitStubs.php that are:
- Defined in lib/functions.php (raise_message, clean_up_lines, etc.)
- Defined in lib/html_utility.php (srv, set_request_var)
- Defined in global_constants.php (POLLER_VERBOSITY_*, MESSAGE_LEVEL_*)
- Defined in global.php (POLLER_ID)

Keep ONLY translation functions (__(), __esc()) that are:
- Called by global.php during initialization
- Not defined elsewhere
- Required for proper bootstrap sequence

This eliminates all constant and function redeclaration errors.

* fix: remove __esc stub - already defined in global_languages.php

Keep only __() translation function stub, which is needed by global.php
and not defined elsewhere in Cacti core.

* fix: handle no-arg case in __() translation stub

The __() function may be called with just a string and no format arguments.
Previously, vsprintf() would fail with 'arguments array must contain 2 items'.
Now, if no args are provided, return the text as-is.
2026-08-16 19:23:31 -07:00

216 lines
8.2 KiB
PHP

<?php
/*
+-------------------------------------------------------------------------+
| Copyright (C) 2004-2026 The Cacti Group |
| |
| This program is free software; you can redistribute it and/or |
| modify it under the terms of the GNU General Public License |
| as published by the Free Software Foundation; either version 2 |
| of the License, or (at your option) any later version. |
| |
| This program is distributed in the hope that it will be useful, |
| but WITHOUT ANY WARRANTY; without even the implied warranty of |
| MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
| GNU General Public License for more details. |
+-------------------------------------------------------------------------+
| Cacti: The Complete RRDtool-based Graphing Solution |
+-------------------------------------------------------------------------+
| This code is designed, written, and maintained by the Cacti Group. See |
| about.php and/or the AUTHORS file for specific developer information. |
+-------------------------------------------------------------------------+
| http://www.cacti.net/ |
+-------------------------------------------------------------------------+
*/
require_once dirname(__DIR__, 3) . '/Helpers/CactiStubs.php';
require_once dirname(__DIR__, 4) . '/include/global.php';
require_once dirname(__DIR__, 4) . '/lib/utility.php';
// support.php returns early under the test-bootstrap gate, so only its function
// declarations load here. That skips the auth + dispatch path a unit test cannot
// satisfy while leaving the diagnostics helpers callable.
require_once dirname(__DIR__, 4) . '/support.php';
test('show_tech_environment renders the environment sections without a database', function () {
global $config;
// Seed the binary paths so read_config_option() serves from the CLI option
// cache instead of reaching the sentinel database, which throws under the
// test bootstrap.
$config[OPTIONS_CLI]['path_php_binary'] = PHP_BINARY;
$config[OPTIONS_CLI]['path_rrdtool'] = '/cacti-tests/definitely-missing-rrdtool';
$config[OPTIONS_CLI]['path_snmpget'] = PHP_BINARY;
ob_start();
show_tech_environment();
$html = ob_get_clean();
expect($html)->toContain(__('Required PHP Extensions'))
->and($html)->toContain(__('Recommended PHP Extensions'))
->and($html)->toContain(__('PHP Configuration'))
->and($html)->toContain(__('Required Binaries'))
->and($html)->toContain(__('Writable Directories'))
->and($html)->toContain('file_uploads');
});
test('show_tech_environment flags a directory that is not writable', function () {
global $config;
$config[OPTIONS_CLI]['path_php_binary'] = PHP_BINARY;
$config[OPTIONS_CLI]['path_rrdtool'] = PHP_BINARY;
$config[OPTIONS_CLI]['path_snmpget'] = PHP_BINARY;
// CACTI_PATH_RESOURCE is one of the directories the report inspects and is
// not a required path, so making it read-only exercises the not-writable
// warning branch. Restore the mode in finally{} so a failure never leaves
// the checkout in a read-only state.
$dir = CACTI_PATH_RESOURCE;
$mode = fileperms($dir) & 0777;
expect(chmod($dir, 0555))->toBeTrue();
try {
clearstatcache(true, $dir);
ob_start();
show_tech_environment();
$html = ob_get_clean();
expect($html)->toContain(__('Not writable'));
} finally {
chmod($dir, $mode);
clearstatcache(true, $dir);
}
})->skip(function_exists('posix_getuid') && posix_getuid() === 0, 'root bypasses directory write permissions');
/*
* The redacted report is assembled inside show_tech_summary(), which runs a long
* sequence of database queries before reaching the report block. The test
* bootstrap's sentinel connection throws on the first query, so the function
* cannot be called in-process. Extract the assembly block (the security-relevant
* added code) and exercise it directly with controlled inputs, matching the
* source-extraction convention in Issue7070PercentileContractTest.
*/
function support_diag_build_report(array $vars): string {
$path = dirname(__DIR__, 4) . '/support.php';
$src = file_get_contents($path);
if ($src === false) {
throw new RuntimeException("support_diag_build_report(): unable to read $path");
}
// The block runs from the first assignment to the last $report line.
$start = strpos($src, '$snmp_line = $snmp_installed');
if ($start === false) {
throw new RuntimeException('support_diag_build_report(): start marker not found in support.php; has the report block moved?');
}
$end = strpos($src, "\$report .= '- ' . __('RSA Fingerprint')");
if ($end === false) {
throw new RuntimeException('support_diag_build_report(): end marker not found in support.php; has the report block moved?');
}
$end = strpos($src, "\n", $end);
if ($end === false) {
throw new RuntimeException('support_diag_build_report(): no newline after end marker in support.php');
}
$block = substr($src, $start, $end - $start);
extract($vars);
eval($block);
return $report;
}
test('diagnostics report masks the RSA fingerprint and hides infrastructure', function () {
global $config;
$config[OPTIONS_CLI]['poller_type'] = '2';
$config[OPTIONS_CLI]['rsa_fingerprint'] = 'abcdef0123456789deadbeefcafebabe';
$config[OPTIONS_CLI]['poller_interval'] = '60';
$config[OPTIONS_CLI]['stats_poller'] = 'Time:1.0';
$report = support_diag_build_report([
'snmp_version' => "NET-SNMP 5.9\nextra line",
'snmp_installed' => true,
'redact' => true,
'poller_options' => [1 => 'cactid', 2 => 'spine'],
'spine_version' => 'Spine 1.2.99',
'database' => 'MariaDB',
'version' => '10.11',
'rrdtool_release' => '1.8.0',
'total_memory' => 16,
'_SERVER' => ['SERVER_SOFTWARE' => 'nginx'],
]);
// Only the first 8 fingerprint characters survive, tagged as masked.
expect($report)->toContain('abcdef01')
->and($report)->toContain(__('masked'))
->and($report)->not->toContain('deadbeefcafebabe');
// The spine branch replaces the poller label with the spine version.
expect($report)->toContain('Spine 1.2.99');
// The single SNMP line is kept; the trailing line is dropped.
expect($report)->toContain('NET-SNMP 5.9')
->and($report)->not->toContain('extra line');
});
test('diagnostics report reports N/A when RSA and memory are absent', function () {
global $config;
$config[OPTIONS_CLI]['poller_type'] = '1';
$config[OPTIONS_CLI]['rsa_fingerprint'] = '';
$config[OPTIONS_CLI]['poller_interval'] = '60';
$config[OPTIONS_CLI]['stats_poller'] = '';
$report = support_diag_build_report([
'snmp_version' => 'NET-SNMP 5.9',
'snmp_installed' => true,
'redact' => false,
'poller_options' => [1 => 'cactid'],
'spine_version' => 'Unknown',
'database' => 'MySQL',
'version' => '8.0',
'rrdtool_release' => '1.8.0',
'total_memory' => 0,
'_SERVER' => [],
]);
// Empty fingerprint and zero memory both collapse to the N/A label.
expect(substr_count($report, __('N/A')))->toBeGreaterThanOrEqual(2)
->and($report)->not->toContain(__('masked'));
// Missing SERVER_SOFTWARE falls back to Unknown, not a leaked value.
expect($report)->toContain(__('Unknown'));
});
test('tech_env_status renders a success span with a check icon', function () {
$html = tech_env_status(DB_STATUS_SUCCESS, 'Installed');
expect($html)->toContain("class='deviceUp'")
->and($html)->toContain('fa-check-circle')
->and($html)->toContain('Installed');
});
test('tech_env_status renders an error span with a times icon', function () {
$html = tech_env_status(DB_STATUS_ERROR, 'Missing');
expect($html)->toContain("class='deviceDown'")
->and($html)->toContain('fa-times-circle')
->and($html)->toContain('Missing');
});
test('tech_env_status falls back to a warning span for any other status', function () {
$html = tech_env_status(DB_STATUS_WARNING, 'Not installed');
expect($html)->toContain("class='deviceRecovering'")
->and($html)->toContain('fa-exclamation-triangle')
->and($html)->toContain('Not installed');
});