Files
cacti/cli/add_tree.php
TheWitnessandTheWitness 3ab4c69fb7 PHPStan Level 8 - Phase 1 Conversion (#8135)
* PHPStan Level 8 - Phase 1 Conversion

Reduces the real (no-baseline) PHPStan level 8 error count from ~2,724 to 425
and regenerates phpstan-baseline.neon accordingly (8,941 -> 1,921 lines).

Core type-safety changes
- lib/database.php: narrow db_fetch_row()/db_fetch_row_prepared() to return
  array (was bool|array) and db_fetch_assoc()/db_fetch_assoc_prepared() to
  return array (was mixed); the _prepared workers coerce the connection-failure
  path to an empty array so the declared type is honest. empty()/cacti_sizeof()
  checks are unaffected.
- lib/database.php: narrow $db_conn guards from is_object() to instanceof PDO in
  the transaction/quote/insert-id helpers so the PDO calls resolve.
- lib/mib_cache.php: the fluent MibCache methods mib()/object()/table()/row()
  now return self instead of a bare object so chained calls type-check.

Type-safety casts and guards (mechanical, behaviour-preserving)
- Cast string|false/|null builtin results feeding string parameters
  (json_decode, base64_encode, trim, htmle, preg_replace, explode, etc.).
- Cast int|string / int|false values feeding int id/pid parameters.
- Guard resource|false fopen()/popen() handles before fwrite/fclose/fread, and
  wrap foreach over array|false/list|false results with `?: []`.

Genuine bugs found and fixed
- cli/add_tree.php / lib/api_tree.php: site tree nodes could not be created via
  the CLI - the --site-id option was never parsed, $nodeTypes had no 'site'
  entry (passing null to api_tree_item_save(int $type) -> TypeError), and
  api_tree_item_save() never persisted site_id. All three fixed.
- tree.php: leaves_exist() is typed : int but returned db_fetch_assoc_prepared()
  (an array of rows) for a SELECT COUNT(*); now uses db_fetch_cell_prepared()
  and returns the scalar count.
- lib/mib_cache.php: $entries_per_object was a float (division / ceil) used as
  an array key (PHP 8.1 implicit float-to-int key deprecation); now cast to int.

Config
- .phpstan.neon: add notIdentical.alwaysTrue and booleanAnd.alwaysFalse to the
  existing always-true/false ignore family (same "PHPStan gets confused"
  dynamic-constant cause already covered by identical.alwaysTrue,
  notEqual.alwaysTrue, booleanAnd.leftAlwaysTrue, etc.).
- phpstan-baseline.neon: regenerated; the remaining 425 entries are the
  untouched long tail for Phase 2.

* Remove redundant @phpstan-ignore comments

Follow-up cleanup for the level 8 Phase 1 work. Removes 14 inline
@phpstan-ignore comments that no longer suppress any reported error:

- cli/repair_database.php: `@phpstan-ignore booleanAnd.alwaysFalse` is now
  covered by the global booleanAnd.alwaysFalse ignore added to .phpstan.neon.
- 13 others (host.php, include/global.php, include/session.php,
  lib/api_automation.php x2, lib/functions.php x2, lib/html_utility.php x2,
  lib/installer.php, lib/package.php, lib/reports.php, lib/rrd.php) no longer
  match any reported error after the type-safety fixes (e.g. the
  db_fetch_row_prepared() return-type narrowing removed the offset-assign
  errors the api_automation ignores were suppressing).

Verified with reportUnmatchedIgnoredErrors enabled: 0 unmatched ignores
remain and the full level 8 run still reports 0 errors.

* ci: satisfy validator ratchet and refresh security sink baselines

- lib/api_tree.php: give the new tree-item site_id a real numeric
  constraint ('^[-0-9]+$', matching html_reports.php) instead of an
  empty regex, so the validator constraint ratchet passes without
  bumping its baseline.
- tests/security/baselines: refresh the three sink/hotspot signatures
  whose code text changed from the (string) casts added in this branch
  (lib/poller.php setsid, cli/rrdresize.php json_encode, lib/import.php
  simplexml_load_string).

* ci(js): allow DOMPurify 3.4.16 and update sync_js pin test

The dependabot bump (#8134) moved package.json/package-lock.json to
DOMPurify 3.4.16 on develop but left tests/js/sync_js.test.mjs pinned to
3.4.15, so the PR merge commit fails the 'DOMPurify is pinned' contract.
Bring package.json/package-lock.json to 3.4.16 (matching develop) and
update the pin test to expect 3.4.16.

* test: update sql.php null-handling assertion for the (string) cast

This branch changed scripts/sql.php from trim(\ ?? '') to
trim((string) \) (the phpstan-safe form that coerces both null and
false from shell_exec()). Update SqlScriptsTest's null-return assertion
to match the new cast instead of the removed '?? ''.

* fix: address Copilot review - ownership IDs, fopen guards, mib_cache bound

- chown()/chgrp(): pass integer UID/GID from fileowner()/filegroup()
  (guarding the false lookup) instead of string-casting them, which made
  them resolve account/group names like '1001' and fail. Covers
  lib/api_device.php, lib/boost.php and poller_maintenance.php (x2).
- fopen() failure now short-circuits instead of reporting success:
  lib/package.php returns false, lib/clog_webapi.php and utilities.php
  render an error, and snmpagent_mibcachechild.php skips the cache write
  and sentinel unlink so a concurrent writer's lock is preserved.
- lib/mib_cache.php: keep the float quotient as the loop bound and cast
  only the array offset, so a non-even entries/columns split no longer
  truncates the loop and drops a cached row.

* revert: keep db_fetch_* returning false on error; baseline Level 8 instead

Per review, restoring the intentional fail-safe: db_fetch_row[_prepared]()
return bool|array and db_fetch_assoc[_prepared]() return mixed again, so a
genuine SQL error (not just a missing connection) is signalled as false and
the === false checks in cdef_is_in_use(), boost_process_* and aggregate.php
work as before. Dropped the is_array() ? : [] coercion.

Level 8 stays green by regenerating phpstan-baseline.neon to capture the
re-introduced bool|array/mixed call-site errors (the ~1,850 the narrowing
had eliminated). Tightening those callers to drop them from the baseline is
Phase 2 work.

---------

Co-authored-by: TheWitness <copilot@users.noreply.github.com>
2026-10-02 10:08:56 -04:00

420 lines
10 KiB
PHP
Executable File

#!/usr/bin/env php
<?php
/*
+-------------------------------------------------------------------------+
| Copyright (C) 2004-2026 The Cacti Group |
| |
| This program is free software; you can redistribute it and/or |
| modify it under the terms of the GNU General Public License |
| as published by the Free Software Foundation; either version 2 |
| of the License, or (at your option) any later version. |
| |
| This program is distributed in the hope that it will be useful, |
| but WITHOUT ANY WARRANTY; without even the implied warranty of |
| MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
| GNU General Public License for more details. |
+-------------------------------------------------------------------------+
| Cacti: The Complete RRDtool-based Graphing Solution |
+-------------------------------------------------------------------------+
| This code is designed, written, and maintained by the Cacti Group. See |
| about.php and/or the AUTHORS file for specific developer information. |
+-------------------------------------------------------------------------+
| http://www.cacti.net/ |
+-------------------------------------------------------------------------+
*/
require(__DIR__ . '/../include/cli_check.php');
require_once(CACTI_PATH_LIBRARY . '/api_automation_tools.php');
require_once(CACTI_PATH_LIBRARY . '/api_tree.php');
// switch to main database for cli's
if (POLLER_ID > 1) {
db_switch_remote_to_main();
}
// process calling arguments
$parms = $_SERVER['argv'];
array_shift($parms);
if (cacti_sizeof($parms)) {
// setup defaults
$type = ''; // tree or node
$name = ''; // Name of a tree or node
$sortMethod = 'alpha'; // manual, alpha, natural, numeric
$parentNode = 0; // When creating a node, the parent node of this node (or zero for root-node)
$treeId = 0; // When creating a node, it has to go in a tree
$nodeType = ''; // Should be 'header', 'graph' or 'host' when creating a node
$graphId = 0; // The ID of the graph to add (gets added to parentNode)
$siteId = 0; // The ID of the site to add
$sortMethods = ['manual' => 1, 'alpha' => 2, 'natural' => 4, 'numeric' => 3];
// 'site' reuses the host type id; api_tree_item_save() only uses the type to gate the title requirement
$nodeTypes = ['header' => 1, 'graph' => 2, 'host' => 3, 'site' => 3];
$hostId = 0;
$hostGroupStyle = 1; // 1 = Graph Template, 2 = Data Query Index
$quietMode = false;
$displayHosts = false;
$displayTrees = false;
$displayNodes = false;
$displayRRAs = false;
$displayGraphs = false;
$displaySites = false;
$hosts = getHosts();
$sites = getSites();
foreach ($parms as $parameter) {
if (str_contains($parameter, '=')) {
[$arg, $value] = explode('=', $parameter, 2);
} else {
$arg = $parameter;
$value = '';
}
switch ($arg) {
case '--type':
$type = trim($value);
break;
case '--name':
$name = trim($value);
break;
case '--sort-method':
$sortMethod = trim($value);
break;
case '--parent-node':
$parentNode = intval($value);
break;
case '--tree-id':
$treeId = intval($value);
break;
case '--node-type':
$nodeType = trim($value);
break;
case '--graph-id':
$graphId = intval($value);
break;
case '--host-id':
$hostId = intval($value);
break;
case '--site-id':
$siteId = intval($value);
break;
case '--quiet':
$quietMode = true;
break;
case '--list-hosts':
$displayHosts = true;
break;
case '--list-trees':
$displayTrees = true;
break;
case '--list-nodes':
$displayNodes = true;
break;
case '--list-graphs':
$displayGraphs = true;
break;
case '--list-sites':
$displaySites = true;
break;
case '--host-group-style':
$hostGroupStyle = trim($value);
break;
case '--version':
case '-V':
case '-v':
display_version();
exit(0);
case '--help':
case '-H':
case '-h':
display_help();
exit(0);
default:
print "ERROR: Invalid Argument: ($arg)" . PHP_EOL . PHP_EOL;
display_help();
exit(1);
}
}
if ($displaySites) {
displaySites($sites, $quietMode);
exit(0);
}
if ($displayHosts) {
displayHosts($hosts, $quietMode);
exit(0);
}
if ($displayTrees) {
displayTrees($quietMode);
exit(0);
}
if ($displayNodes) {
if ($treeId == 0) {
print 'ERROR: You must supply a tree_id before you can list its nodes' . PHP_EOL;
print 'Try --list-trees' . PHP_EOL;
exit(1);
}
displayTreeNodes($treeId, $nodeType, $parentNode, $quietMode);
exit(0);
}
if ($displayRRAs) {
displayRRAs($quietMode);
exit(0);
}
if ($displayGraphs) {
if ($hostId <= 0) {
print 'ERROR: You must supply a host_id before you can list its graphs' . PHP_EOL;
print 'Try --list-hosts' . PHP_EOL;
exit(1);
}
displayHostGraphs($hostId, $quietMode);
exit(0);
}
if ($type == 'tree') {
// Add a new tree
if (empty($name)) {
print 'ERROR: You must supply a name with --name' . PHP_EOL;
display_help();
exit(1);
}
$treeOpts = [];
$treeOpts['id'] = 0; // Zero means create a new one rather than save over an existing one
$treeOpts['name'] = $name;
if ($sortMethod == 'manual' ||
$sortMethod == 'alpha' ||
$sortMethod == 'numeric' ||
$sortMethod == 'natural') {
$treeOpts['sort_type'] = $sortMethods[$sortMethod];
} else {
print "ERROR: Invalid sort-method: ($sortMethod)" . PHP_EOL;
display_help();
exit(1);
}
$existsAlready = db_fetch_cell("SELECT id FROM graph_tree WHERE name = '$name'");
if ($existsAlready) {
print "ERROR: Not adding tree - it already exists - tree-id: ($existsAlready)" . PHP_EOL;
exit(1);
}
$treeId = sql_save($treeOpts, 'graph_tree');
api_tree_sort_branch(0, $treeId);
print "Tree Created - tree-id: ($treeId)" . PHP_EOL;
exit(0);
}
if ($type == 'node') {
// Add a new node to a tree
if ($nodeType == 'header' ||
$nodeType == 'graph' ||
$nodeType == 'site' ||
$nodeType == 'host') {
$itemType = $nodeTypes[$nodeType];
} else {
print "ERROR: Invalid node-type: ($nodeType)" . PHP_EOL;
display_help();
exit(1);
}
if ($parentNode < 0) {
print "ERROR: parent-node $parentNode must be numeric > 0" . PHP_EOL;
display_help();
exit(1);
}
if ($parentNode > 0) {
$parentNodeExists = db_fetch_cell("SELECT id
FROM graph_tree_items
WHERE graph_tree_id=$treeId
AND id=$parentNode");
if (!isset($parentNodeExists)) {
print "ERROR: parent-node $parentNode does not exist" . PHP_EOL;
exit(1);
}
}
if ($nodeType == 'header') {
// Header --name must be given
if (empty($name)) {
print 'ERROR: You must supply a name with --name' . PHP_EOL;
display_help();
exit(1);
}
// Blank out the graphId, hostID and host_grouping_style fields
$graphId = 0;
$hostId = 0;
$siteId = 0;
$hostGroupStyle = 1;
} elseif ($nodeType == 'graph') {
// Blank out name, hostID, host_grouping_style
$name = '';
$hostId = 0;
$siteId = 0;
$hostGroupStyle = 1;
$graphs = db_fetch_assoc('SELECT id
FROM graph_local
WHERE graph_local.id=' . $graphId);
if (!cacti_sizeof($graphs)) {
print "ERROR: No such graph-id ($graphId) exists. Try --list-graphs" . PHP_EOL;
exit(1);
}
} elseif ($nodeType == 'site') {
// Blank out graphId, name fields
$graphId = 0;
$hostId = 0;
$name = '';
if (!isset($sites[$siteId])) {
print "ERROR: No such site-id ($siteId) exists. Try --list-sites" . PHP_EOL;
exit(1);
}
} elseif ($nodeType == 'host') {
// Blank out graphId, name fields
$graphId = 0;
$siteId = 0;
$name = '';
if (!isset($hosts[$hostId])) {
print "ERROR: No such host-id ($hostId) exists. Try --list-hosts" . PHP_EOL;
exit(1);
}
if ($hostGroupStyle != 1 && $hostGroupStyle != 2) {
print 'ERROR: Host Group Style must be 1 or 2 (Graph Template or Data Query Index)' . PHP_EOL;
display_help();
exit(1);
}
}
// $nodeId could be a Header Node, a Graph Node, or a Host node.
$nodeId = api_tree_item_save(0, $treeId, $itemType, $parentNode, $name, $graphId, $hostId, $siteId, $hostGroupStyle, $sortMethods[$sortMethod], false);
print "Added Node node-id: ($nodeId)" . PHP_EOL;
exit(0);
} else {
print "ERROR: Unknown type: ($type)" . PHP_EOL;
display_help();
exit(1);
}
} else {
display_help();
exit(0);
}
/**
* display_version - displays version information
*
* @return void
*/
function display_version() : void {
$version = get_cacti_cli_version();
print "Cacti Add Tree Utility, Version $version, " . COPYRIGHT_YEARS . PHP_EOL;
}
/**
* display_help - displays help information
*
* @return void
*/
function display_help() : void {
display_version();
print PHP_EOL;
print 'usage: add_tree.php --type=[tree|node] [type-options] [--quiet]' . PHP_EOL . PHP_EOL;
print 'Tree options:' . PHP_EOL;
print ' --name=[Tree Name]' . PHP_EOL;
print ' --sort-method=[manual|alpha|natural|numeric]' . PHP_EOL . PHP_EOL;
print 'Node options:' . PHP_EOL;
print ' --node-type=[header|site|host|graph]' . PHP_EOL;
print ' --tree-id=[ID]' . PHP_EOL;
print ' [--parent-node=[ID] [Node Type Options]]' . PHP_EOL . PHP_EOL;
print 'Header node options:' . PHP_EOL;
print ' --name=[Name]' . PHP_EOL . PHP_EOL;
print 'Site node options:' . PHP_EOL;
print ' --site-id=[ID]' . PHP_EOL . PHP_EOL;
print 'Host node options:' . PHP_EOL;
print ' --host-id=[ID]' . PHP_EOL;
print ' [--host-group-style=[1|2]]' . PHP_EOL;
print ' (host group styles:' . PHP_EOL;
print ' 1 = Graph Template,' . PHP_EOL;
print ' 2 = Data Query Index)' . PHP_EOL . PHP_EOL;
print 'Graph node options:' . PHP_EOL;
print ' --graph-id=[ID]' . PHP_EOL . PHP_EOL;
print 'List Options:' . PHP_EOL;
print ' --list-sites' . PHP_EOL;
print ' --list-hosts' . PHP_EOL;
print ' --list-trees' . PHP_EOL;
print ' --list-nodes --tree-id=[ID]' . PHP_EOL;
print ' --list-graphs --host-id=[ID]' . PHP_EOL;
}