mirror of
https://github.com/Cacti/cacti.git
synced 2026-10-27 15:17:05 +09:00
* PHPStan Level 8 - Phase 1 Conversion
Reduces the real (no-baseline) PHPStan level 8 error count from ~2,724 to 425
and regenerates phpstan-baseline.neon accordingly (8,941 -> 1,921 lines).
Core type-safety changes
- lib/database.php: narrow db_fetch_row()/db_fetch_row_prepared() to return
array (was bool|array) and db_fetch_assoc()/db_fetch_assoc_prepared() to
return array (was mixed); the _prepared workers coerce the connection-failure
path to an empty array so the declared type is honest. empty()/cacti_sizeof()
checks are unaffected.
- lib/database.php: narrow $db_conn guards from is_object() to instanceof PDO in
the transaction/quote/insert-id helpers so the PDO calls resolve.
- lib/mib_cache.php: the fluent MibCache methods mib()/object()/table()/row()
now return self instead of a bare object so chained calls type-check.
Type-safety casts and guards (mechanical, behaviour-preserving)
- Cast string|false/|null builtin results feeding string parameters
(json_decode, base64_encode, trim, htmle, preg_replace, explode, etc.).
- Cast int|string / int|false values feeding int id/pid parameters.
- Guard resource|false fopen()/popen() handles before fwrite/fclose/fread, and
wrap foreach over array|false/list|false results with `?: []`.
Genuine bugs found and fixed
- cli/add_tree.php / lib/api_tree.php: site tree nodes could not be created via
the CLI - the --site-id option was never parsed, $nodeTypes had no 'site'
entry (passing null to api_tree_item_save(int $type) -> TypeError), and
api_tree_item_save() never persisted site_id. All three fixed.
- tree.php: leaves_exist() is typed : int but returned db_fetch_assoc_prepared()
(an array of rows) for a SELECT COUNT(*); now uses db_fetch_cell_prepared()
and returns the scalar count.
- lib/mib_cache.php: $entries_per_object was a float (division / ceil) used as
an array key (PHP 8.1 implicit float-to-int key deprecation); now cast to int.
Config
- .phpstan.neon: add notIdentical.alwaysTrue and booleanAnd.alwaysFalse to the
existing always-true/false ignore family (same "PHPStan gets confused"
dynamic-constant cause already covered by identical.alwaysTrue,
notEqual.alwaysTrue, booleanAnd.leftAlwaysTrue, etc.).
- phpstan-baseline.neon: regenerated; the remaining 425 entries are the
untouched long tail for Phase 2.
* Remove redundant @phpstan-ignore comments
Follow-up cleanup for the level 8 Phase 1 work. Removes 14 inline
@phpstan-ignore comments that no longer suppress any reported error:
- cli/repair_database.php: `@phpstan-ignore booleanAnd.alwaysFalse` is now
covered by the global booleanAnd.alwaysFalse ignore added to .phpstan.neon.
- 13 others (host.php, include/global.php, include/session.php,
lib/api_automation.php x2, lib/functions.php x2, lib/html_utility.php x2,
lib/installer.php, lib/package.php, lib/reports.php, lib/rrd.php) no longer
match any reported error after the type-safety fixes (e.g. the
db_fetch_row_prepared() return-type narrowing removed the offset-assign
errors the api_automation ignores were suppressing).
Verified with reportUnmatchedIgnoredErrors enabled: 0 unmatched ignores
remain and the full level 8 run still reports 0 errors.
* ci: satisfy validator ratchet and refresh security sink baselines
- lib/api_tree.php: give the new tree-item site_id a real numeric
constraint ('^[-0-9]+$', matching html_reports.php) instead of an
empty regex, so the validator constraint ratchet passes without
bumping its baseline.
- tests/security/baselines: refresh the three sink/hotspot signatures
whose code text changed from the (string) casts added in this branch
(lib/poller.php setsid, cli/rrdresize.php json_encode, lib/import.php
simplexml_load_string).
* ci(js): allow DOMPurify 3.4.16 and update sync_js pin test
The dependabot bump (#8134) moved package.json/package-lock.json to
DOMPurify 3.4.16 on develop but left tests/js/sync_js.test.mjs pinned to
3.4.15, so the PR merge commit fails the 'DOMPurify is pinned' contract.
Bring package.json/package-lock.json to 3.4.16 (matching develop) and
update the pin test to expect 3.4.16.
* test: update sql.php null-handling assertion for the (string) cast
This branch changed scripts/sql.php from trim(\ ?? '') to
trim((string) \) (the phpstan-safe form that coerces both null and
false from shell_exec()). Update SqlScriptsTest's null-return assertion
to match the new cast instead of the removed '?? ''.
* fix: address Copilot review - ownership IDs, fopen guards, mib_cache bound
- chown()/chgrp(): pass integer UID/GID from fileowner()/filegroup()
(guarding the false lookup) instead of string-casting them, which made
them resolve account/group names like '1001' and fail. Covers
lib/api_device.php, lib/boost.php and poller_maintenance.php (x2).
- fopen() failure now short-circuits instead of reporting success:
lib/package.php returns false, lib/clog_webapi.php and utilities.php
render an error, and snmpagent_mibcachechild.php skips the cache write
and sentinel unlink so a concurrent writer's lock is preserved.
- lib/mib_cache.php: keep the float quotient as the loop bound and cast
only the array offset, so a non-even entries/columns split no longer
truncates the loop and drops a cached row.
* revert: keep db_fetch_* returning false on error; baseline Level 8 instead
Per review, restoring the intentional fail-safe: db_fetch_row[_prepared]()
return bool|array and db_fetch_assoc[_prepared]() return mixed again, so a
genuine SQL error (not just a missing connection) is signalled as false and
the === false checks in cdef_is_in_use(), boost_process_* and aggregate.php
work as before. Dropped the is_array() ? : [] coercion.
Level 8 stays green by regenerating phpstan-baseline.neon to capture the
re-introduced bool|array/mixed call-site errors (the ~1,850 the narrowing
had eliminated). Tightening those callers to drop them from the baseline is
Phase 2 work.
---------
Co-authored-by: TheWitness <copilot@users.noreply.github.com>
473 lines
13 KiB
PHP
Executable File
473 lines
13 KiB
PHP
Executable File
#!/usr/bin/env php
|
|
<?php
|
|
/*
|
|
+-------------------------------------------------------------------------+
|
|
| Copyright (C) 2004-2026 The Cacti Group |
|
|
| |
|
|
| This program is free software; you can redistribute it and/or |
|
|
| modify it under the terms of the GNU General Public License |
|
|
| as published by the Free Software Foundation; either version 2 |
|
|
| of the License, or (at your option) any later version. |
|
|
| |
|
|
| This program is distributed in the hope that it will be useful, |
|
|
| but WITHOUT ANY WARRANTY; without even the implied warranty of |
|
|
| MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
|
|
| GNU General Public License for more details. |
|
|
+-------------------------------------------------------------------------+
|
|
| Cacti: The Complete RRDtool-based Graphing Solution |
|
|
+-------------------------------------------------------------------------+
|
|
| This code is designed, written, and maintained by the Cacti Group. See |
|
|
| about.php and/or the AUTHORS file for specific developer information. |
|
|
+-------------------------------------------------------------------------+
|
|
| http://www.cacti.net/ |
|
|
+-------------------------------------------------------------------------+
|
|
*/
|
|
|
|
if (function_exists('pcntl_async_signals')) {
|
|
pcntl_async_signals(true);
|
|
} else {
|
|
declare(ticks = 100);
|
|
}
|
|
|
|
ini_set('output_buffering', 'Off');
|
|
ini_set('max_runtime', '-1');
|
|
ini_set('memory_limit', '-1');
|
|
|
|
// we are not talking to the browser
|
|
define('MAX_RECACHE_RUNTIME', 1800);
|
|
|
|
require(__DIR__ . '/include/cli_check.php');
|
|
require_once(CACTI_PATH_LIBRARY . '/api_device.php');
|
|
require_once(CACTI_PATH_LIBRARY . '/api_data_source.php');
|
|
require_once(CACTI_PATH_LIBRARY . '/api_graph.php');
|
|
require_once(CACTI_PATH_LIBRARY . '/api_tree.php');
|
|
require_once(CACTI_PATH_LIBRARY . '/data_query.php');
|
|
require_once(CACTI_PATH_LIBRARY . '/html_form_template.php');
|
|
require_once(CACTI_PATH_LIBRARY . '/ping.php');
|
|
require_once(CACTI_PATH_LIBRARY . '/poller.php');
|
|
require_once(CACTI_PATH_LIBRARY . '/rrd.php');
|
|
require_once(CACTI_PATH_LIBRARY . '/snmp.php');
|
|
require_once(CACTI_PATH_LIBRARY . '/sort.php');
|
|
require_once(CACTI_PATH_LIBRARY . '/template.php');
|
|
require_once(CACTI_PATH_LIBRARY . '/utility.php');
|
|
|
|
$poller_id = POLLER_ID;
|
|
$debug = false;
|
|
$host_id = false;
|
|
$forcerun = false;
|
|
$type = 'master';
|
|
$threads = intval(read_config_option('commands_processes'));
|
|
$poller_id = POLLER_ID;
|
|
|
|
global $poller_db_cnn_id, $remote_db_cnn_id, $type, $host_id, $poller_id;
|
|
|
|
if ($poller_id > 1 && CACTI_CONNECTION === 'online') {
|
|
$poller_db_cnn_id = $remote_db_cnn_id;
|
|
} else {
|
|
$poller_db_cnn_id = false;
|
|
}
|
|
|
|
// process calling arguments
|
|
$parms = $_SERVER['argv'];
|
|
array_shift($parms);
|
|
|
|
if (cacti_sizeof($parms)) {
|
|
foreach ($parms as $parameter) {
|
|
if (str_contains($parameter, '=')) {
|
|
[$arg, $value] = explode('=', $parameter, 2);
|
|
} else {
|
|
$arg = $parameter;
|
|
$value = '';
|
|
}
|
|
|
|
switch ($arg) {
|
|
case '--version':
|
|
case '-V':
|
|
display_version();
|
|
|
|
exit(0);
|
|
case '-H':
|
|
case '--help':
|
|
display_help();
|
|
|
|
exit(0);
|
|
case '--poller':
|
|
case '-p':
|
|
$poller_id = $value;
|
|
|
|
break;
|
|
case '--child':
|
|
case '-c':
|
|
$host_id = $value;
|
|
$type = 'child';
|
|
|
|
break;
|
|
case '-t':
|
|
case '--threads':
|
|
$threads = intval($value);
|
|
|
|
break;
|
|
case '--debug':
|
|
case '-d':
|
|
$debug = true;
|
|
|
|
break;
|
|
default:
|
|
print "ERROR: Invalid Argument: ($arg)" . PHP_EOL . PHP_EOL;
|
|
display_help();
|
|
|
|
exit(1);
|
|
}
|
|
}
|
|
}
|
|
|
|
if ($debug) {
|
|
$verbosity = POLLER_VERBOSITY_LOW;
|
|
} else {
|
|
$verbosity = POLLER_VERBOSITY_MEDIUM;
|
|
}
|
|
|
|
/**
|
|
* Types include
|
|
*
|
|
* master - the main process launched from the Cacti main poller and will launch child processes
|
|
* child - a child of the master process from the 'master'
|
|
*
|
|
*/
|
|
|
|
// install signal handlers for UNIX only
|
|
if (function_exists('pcntl_signal')) {
|
|
pcntl_signal(SIGTERM, 'sig_handler');
|
|
pcntl_signal(SIGINT, 'sig_handler');
|
|
}
|
|
|
|
// Record Start Time
|
|
$start = microtime(true);
|
|
|
|
// Get the process timeout value
|
|
$timeout = poller_commands_timeout();
|
|
|
|
// send a gentle message to the log and stdout
|
|
commands_debug('Polling Starting');
|
|
|
|
if ($host_id === false) {
|
|
$hosts = array_rekey(
|
|
db_fetch_assoc_prepared('SELECT DISTINCT SUBSTRING_INDEX(command, ":", 1) AS host_id
|
|
FROM poller_command
|
|
WHERE poller_id = ?',
|
|
[$poller_id], true, $poller_db_cnn_id),
|
|
'host_id', 'host_id'
|
|
);
|
|
|
|
if (cacti_sizeof($hosts)) {
|
|
/**
|
|
* Register the master process
|
|
*/
|
|
if (!register_process_start('commands', 'master', $poller_id, $timeout)) {
|
|
exit(0);
|
|
}
|
|
|
|
// Master processing
|
|
commands_master_handler($forcerun, $hosts, $threads);
|
|
|
|
// take time to log performance data
|
|
$recache = microtime(true);
|
|
|
|
$recache_stats = sprintf('Poller:%s RecacheTime:%01.4f DevicesRecached:%s', $poller_id, round($recache - $start, 4), cacti_sizeof($hosts));
|
|
|
|
if (cacti_sizeof($hosts)) {
|
|
cacti_log('STATS: ' . $recache_stats, true, 'RECACHE');
|
|
}
|
|
|
|
// insert poller stats into the settings table
|
|
db_execute_prepared('REPLACE INTO settings (name, value) VALUES (?, ?)',
|
|
['stats_recache_' . $poller_id, $recache_stats], true, $poller_db_cnn_id);
|
|
|
|
unregister_process('commands', 'master', $poller_id);
|
|
} else {
|
|
cacti_log('NOTE: No Poller Commands found for processing', true, 'PCOMMAND', $verbosity);
|
|
}
|
|
} else {
|
|
/**
|
|
* Register the child process
|
|
*/
|
|
if (!register_process_start('commands', 'child', $host_id + 1000, $timeout)) {
|
|
exit(0);
|
|
}
|
|
|
|
$last_host_id = 0;
|
|
$first_host = true;
|
|
|
|
/**
|
|
* We will only remove records earlier than this date
|
|
*/
|
|
$max_updated = db_fetch_cell_prepared('SELECT MAX(UNIX_TIMESTAMP(last_updated))
|
|
FROM poller_command
|
|
WHERE poller_id = ?
|
|
AND SUBSTRING_INDEX(command, ":", 1) = ?',
|
|
[$poller_id, $host_id], '', true, $poller_db_cnn_id);
|
|
|
|
/**
|
|
* Get the poller command records for the host
|
|
*/
|
|
$poller_commands = db_fetch_assoc_prepared('SELECT action, command,
|
|
SUBSTRING_INDEX(command, ":", 1) AS host_id
|
|
FROM poller_command
|
|
WHERE poller_id = ?
|
|
AND last_updated <= FROM_UNIXTIME(?)
|
|
AND SUBSTRING_INDEX(command, ":", 1) = ?',
|
|
[$poller_id, $max_updated, $host_id], true, $poller_db_cnn_id);
|
|
|
|
if (cacti_sizeof($poller_commands)) {
|
|
foreach ($poller_commands as $command) {
|
|
switch ($command['action']) {
|
|
case POLLER_COMMAND_REINDEX:
|
|
[$device_id, $data_query_id] = explode(':', $command['command']);
|
|
|
|
$device_id = intval($device_id);
|
|
$data_query_id = intval($data_query_id);
|
|
|
|
if ($last_host_id != $device_id) {
|
|
$last_host_id = $device_id;
|
|
$first_host = true;
|
|
} else {
|
|
$first_host = false;
|
|
}
|
|
|
|
if ($first_host) {
|
|
cacti_log("Device[$device_id] NOTE: Recache Event Detected for Device", true, 'PCOMMAND');
|
|
}
|
|
|
|
cacti_log("Device[$device_id] DQ[$data_query_id] RECACHE: Recache for Device started.", true, 'PCOMMAND', $verbosity);
|
|
run_data_query($device_id, $data_query_id);
|
|
cacti_log("Device[$device_id] DQ[$data_query_id] RECACHE: Recached successfully.", true, 'PCOMMAND', $verbosity);
|
|
|
|
break;
|
|
case POLLER_COMMAND_PURGE:
|
|
$device_id = $command['command'];
|
|
|
|
api_device_purge_from_remote($device_id, $poller_id);
|
|
cacti_log("Device[$device_id] PURGE: Purged successfully.", true, 'PCOMMAND', $verbosity);
|
|
|
|
break;
|
|
default:
|
|
cacti_log('ERROR: Unknown poller command issued', true, 'PCOMMAND');
|
|
}
|
|
|
|
// record current_time
|
|
$current = microtime(true);
|
|
|
|
// end if runtime has been exceeded
|
|
if (($current - $start) > MAX_RECACHE_RUNTIME) {
|
|
cacti_log("ERROR: Poller Command processing timed out after processing '$command'", true, 'PCOMMAND');
|
|
|
|
break;
|
|
}
|
|
}
|
|
|
|
db_execute_prepared('DELETE FROM poller_command
|
|
WHERE poller_id = ?
|
|
AND SUBSTRING_INDEX(command, ":", 1) = ?
|
|
AND last_updated <= FROM_UNIXTIME(?)',
|
|
[$poller_id, $host_id, $max_updated], true, $poller_db_cnn_id);
|
|
}
|
|
|
|
unregister_process('commands', 'child', $host_id + 1000);
|
|
}
|
|
|
|
function commands_master_handler(bool $forcerun, array &$hosts, int $threads) : void {
|
|
commands_debug('There are ' . cacti_sizeof($hosts) . ' to reindex');
|
|
|
|
foreach ($hosts as $id) {
|
|
// run the daily stats
|
|
commands_debug("Launching Host ID $id");
|
|
commands_launch_child($id);
|
|
|
|
// Wait for if there are 50 processes running
|
|
while (true) {
|
|
$running = commands_processes_running();
|
|
|
|
if ($running >= $threads) {
|
|
commands_debug(sprintf('%s Processes Running, Sleeping for 2 seconds.', $running));
|
|
sleep(2);
|
|
} else {
|
|
commands_debug(sprintf('%s Processes Running, Launching more processes.', $running));
|
|
usleep(500000);
|
|
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
$starting = true;
|
|
|
|
while (true) {
|
|
if ($starting) {
|
|
sleep(5);
|
|
$starting = false;
|
|
}
|
|
|
|
$running = commands_processes_running();
|
|
|
|
if ($running > 0) {
|
|
commands_debug(sprintf('%s Processes Running, Sleeping for 2 seconds.', $running));
|
|
sleep(2);
|
|
} else {
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
/**
|
|
* commands_launch_child - this function will launch collector children based upon
|
|
* the maximum number of threads and the process type.
|
|
*
|
|
* @param int $host_id The Cacti host_id
|
|
*
|
|
* @return void
|
|
*/
|
|
function commands_launch_child(int $host_id) : void {
|
|
global $seebug;
|
|
|
|
$php_binary = read_config_option('path_php_binary');
|
|
|
|
commands_debug(sprintf('Launching Commands Process Number %s for Type %s', $host_id, 'child'));
|
|
|
|
cacti_log(sprintf('NOTE: Launching Commands Process Number %s for Type %s', $host_id, 'child'), false, 'CLEANUP', POLLER_VERBOSITY_MEDIUM);
|
|
|
|
exec_background($php_binary, CACTI_PATH_BASE . "/poller_commands.php --child=$host_id" . ($seebug ? ' --debug' : ''));
|
|
}
|
|
|
|
/**
|
|
* commands_processes_running - given a type, determine the number
|
|
* of sub-type or children that are currently running.
|
|
*
|
|
* @return int The number of running processes
|
|
*/
|
|
function commands_processes_running() : int {
|
|
$running = db_fetch_cell('SELECT COUNT(*)
|
|
FROM processes
|
|
WHERE tasktype = "commands"
|
|
AND taskname = "child"');
|
|
|
|
if ($running == 0) {
|
|
return 0;
|
|
}
|
|
|
|
return $running;
|
|
}
|
|
|
|
/**
|
|
* commands_debug - this simple routine prints a standard message to the console
|
|
* when running in debug mode.
|
|
*
|
|
* @param string $message The message to display
|
|
*
|
|
* @return void
|
|
*/
|
|
function commands_debug(string $message) : void {
|
|
global $seebug;
|
|
|
|
if ($seebug) {
|
|
print 'COMMANDS: ' . $message . PHP_EOL;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* sig_handler - provides a generic means to catch exceptions to the Cacti log.
|
|
*
|
|
* @param int $signo The signal that was thrown by the interface.
|
|
*
|
|
* @return void
|
|
*/
|
|
function sig_handler(int $signo) : void {
|
|
global $type, $host_id, $poller_id;
|
|
|
|
switch ($signo) {
|
|
case SIGTERM:
|
|
case SIGINT:
|
|
cacti_log('WARNING: RRDfile Cleanup Poller terminated by user', false, 'CLEANUP');
|
|
|
|
if (str_contains($type, 'master')) {
|
|
commands_kill_running_processes();
|
|
}
|
|
|
|
if ($type == 'master') {
|
|
unregister_process('commands', $type, $poller_id, (int) getmypid());
|
|
} else {
|
|
unregister_process('commands', $type, $host_id + 1000, (int) getmypid());
|
|
}
|
|
|
|
exit(1);
|
|
default:
|
|
// ignore all other signals
|
|
}
|
|
}
|
|
|
|
/**
|
|
* commands_kill_running_processes - this function is part of an interrupt
|
|
* handler to kill children processes when the parent is killed
|
|
*
|
|
* @return void
|
|
*/
|
|
function commands_kill_running_processes() : void {
|
|
global $type;
|
|
|
|
$processes = db_fetch_assoc_prepared('SELECT *
|
|
FROM processes
|
|
WHERE tasktype = "commands"
|
|
AND taskname IN ("child")
|
|
AND pid != ?',
|
|
[getmypid()]);
|
|
|
|
if (cacti_sizeof($processes)) {
|
|
foreach ($processes as $p) {
|
|
if (cacti_process_still_running((int) $p['pid'])) {
|
|
cacti_log(sprintf('WARNING: Killing Commands %s PID %d due to another due to signal or overrun.', ucfirst($p['taskname']), $p['pid']), false, 'CLEANUP');
|
|
|
|
cacti_process_kill((int) $p['pid'], SIGTERM, 'CLEANUP');
|
|
}
|
|
|
|
unregister_process($p['tasktype'], $p['taskname'], $p['taskid'], $p['pid']);
|
|
}
|
|
}
|
|
}
|
|
|
|
function poller_commands_timeout() : int {
|
|
$timeout = intval(read_config_option('commands_timeout'));
|
|
|
|
if (empty($timeout)) {
|
|
$timeout = 300;
|
|
}
|
|
|
|
return $timeout;
|
|
}
|
|
|
|
/**
|
|
* display_version - displays version information
|
|
*
|
|
* @return void
|
|
*/
|
|
function display_version() : void {
|
|
$version = get_cacti_cli_version();
|
|
print "Cacti Poller Commands Poller, Version $version " . COPYRIGHT_YEARS . PHP_EOL;
|
|
}
|
|
|
|
/**
|
|
* display_help - displays help information
|
|
*
|
|
* @return void
|
|
*/
|
|
function display_help() : void {
|
|
display_version();
|
|
|
|
print PHP_EOL;
|
|
print 'usage: poller_commands.php [--poller=ID] [--debug]' . PHP_EOL . PHP_EOL;
|
|
print 'Cacti\'s Commands Poller. This poller can receive specifically crafted commands from' . PHP_EOL;
|
|
print 'either the Cacti UI, or from the main poller, and then run them in the background.' . PHP_EOL . PHP_EOL;
|
|
print 'Optional:' . PHP_EOL;
|
|
print ' --poller=ID - The poller to run as. Defaults to the system poller' . PHP_EOL;
|
|
print ' --threads=N - Override the System Processes setting and use N processes' . PHP_EOL;
|
|
print ' --debug - Display verbose output during execution' . PHP_EOL . PHP_EOL;
|
|
}
|