mirror of
https://github.com/Cacti/cacti.git
synced 2026-10-23 03:27:02 +09:00
* PHPStan Level 8 - Phase 1 Conversion
Reduces the real (no-baseline) PHPStan level 8 error count from ~2,724 to 425
and regenerates phpstan-baseline.neon accordingly (8,941 -> 1,921 lines).
Core type-safety changes
- lib/database.php: narrow db_fetch_row()/db_fetch_row_prepared() to return
array (was bool|array) and db_fetch_assoc()/db_fetch_assoc_prepared() to
return array (was mixed); the _prepared workers coerce the connection-failure
path to an empty array so the declared type is honest. empty()/cacti_sizeof()
checks are unaffected.
- lib/database.php: narrow $db_conn guards from is_object() to instanceof PDO in
the transaction/quote/insert-id helpers so the PDO calls resolve.
- lib/mib_cache.php: the fluent MibCache methods mib()/object()/table()/row()
now return self instead of a bare object so chained calls type-check.
Type-safety casts and guards (mechanical, behaviour-preserving)
- Cast string|false/|null builtin results feeding string parameters
(json_decode, base64_encode, trim, htmle, preg_replace, explode, etc.).
- Cast int|string / int|false values feeding int id/pid parameters.
- Guard resource|false fopen()/popen() handles before fwrite/fclose/fread, and
wrap foreach over array|false/list|false results with `?: []`.
Genuine bugs found and fixed
- cli/add_tree.php / lib/api_tree.php: site tree nodes could not be created via
the CLI - the --site-id option was never parsed, $nodeTypes had no 'site'
entry (passing null to api_tree_item_save(int $type) -> TypeError), and
api_tree_item_save() never persisted site_id. All three fixed.
- tree.php: leaves_exist() is typed : int but returned db_fetch_assoc_prepared()
(an array of rows) for a SELECT COUNT(*); now uses db_fetch_cell_prepared()
and returns the scalar count.
- lib/mib_cache.php: $entries_per_object was a float (division / ceil) used as
an array key (PHP 8.1 implicit float-to-int key deprecation); now cast to int.
Config
- .phpstan.neon: add notIdentical.alwaysTrue and booleanAnd.alwaysFalse to the
existing always-true/false ignore family (same "PHPStan gets confused"
dynamic-constant cause already covered by identical.alwaysTrue,
notEqual.alwaysTrue, booleanAnd.leftAlwaysTrue, etc.).
- phpstan-baseline.neon: regenerated; the remaining 425 entries are the
untouched long tail for Phase 2.
* Remove redundant @phpstan-ignore comments
Follow-up cleanup for the level 8 Phase 1 work. Removes 14 inline
@phpstan-ignore comments that no longer suppress any reported error:
- cli/repair_database.php: `@phpstan-ignore booleanAnd.alwaysFalse` is now
covered by the global booleanAnd.alwaysFalse ignore added to .phpstan.neon.
- 13 others (host.php, include/global.php, include/session.php,
lib/api_automation.php x2, lib/functions.php x2, lib/html_utility.php x2,
lib/installer.php, lib/package.php, lib/reports.php, lib/rrd.php) no longer
match any reported error after the type-safety fixes (e.g. the
db_fetch_row_prepared() return-type narrowing removed the offset-assign
errors the api_automation ignores were suppressing).
Verified with reportUnmatchedIgnoredErrors enabled: 0 unmatched ignores
remain and the full level 8 run still reports 0 errors.
* ci: satisfy validator ratchet and refresh security sink baselines
- lib/api_tree.php: give the new tree-item site_id a real numeric
constraint ('^[-0-9]+$', matching html_reports.php) instead of an
empty regex, so the validator constraint ratchet passes without
bumping its baseline.
- tests/security/baselines: refresh the three sink/hotspot signatures
whose code text changed from the (string) casts added in this branch
(lib/poller.php setsid, cli/rrdresize.php json_encode, lib/import.php
simplexml_load_string).
* ci(js): allow DOMPurify 3.4.16 and update sync_js pin test
The dependabot bump (#8134) moved package.json/package-lock.json to
DOMPurify 3.4.16 on develop but left tests/js/sync_js.test.mjs pinned to
3.4.15, so the PR merge commit fails the 'DOMPurify is pinned' contract.
Bring package.json/package-lock.json to 3.4.16 (matching develop) and
update the pin test to expect 3.4.16.
* test: update sql.php null-handling assertion for the (string) cast
This branch changed scripts/sql.php from trim(\ ?? '') to
trim((string) \) (the phpstan-safe form that coerces both null and
false from shell_exec()). Update SqlScriptsTest's null-return assertion
to match the new cast instead of the removed '?? ''.
* fix: address Copilot review - ownership IDs, fopen guards, mib_cache bound
- chown()/chgrp(): pass integer UID/GID from fileowner()/filegroup()
(guarding the false lookup) instead of string-casting them, which made
them resolve account/group names like '1001' and fail. Covers
lib/api_device.php, lib/boost.php and poller_maintenance.php (x2).
- fopen() failure now short-circuits instead of reporting success:
lib/package.php returns false, lib/clog_webapi.php and utilities.php
render an error, and snmpagent_mibcachechild.php skips the cache write
and sentinel unlink so a concurrent writer's lock is preserved.
- lib/mib_cache.php: keep the float quotient as the loop bound and cast
only the array offset, so a non-even entries/columns split no longer
truncates the loop and drops a cached row.
* revert: keep db_fetch_* returning false on error; baseline Level 8 instead
Per review, restoring the intentional fail-safe: db_fetch_row[_prepared]()
return bool|array and db_fetch_assoc[_prepared]() return mixed again, so a
genuine SQL error (not just a missing connection) is signalled as false and
the === false checks in cdef_is_in_use(), boost_process_* and aggregate.php
work as before. Dropped the is_array() ? : [] coercion.
Level 8 stays green by regenerating phpstan-baseline.neon to capture the
re-introduced bool|array/mixed call-site errors (the ~1,850 the narrowing
had eliminated). Tightening those callers to drop them from the baseline is
Phase 2 work.
---------
Co-authored-by: TheWitness <copilot@users.noreply.github.com>
419 lines
13 KiB
PHP
419 lines
13 KiB
PHP
<?php
|
|
/*
|
|
+-------------------------------------------------------------------------+
|
|
| Copyright (C) 2004-2026 The Cacti Group |
|
|
| |
|
|
| This program is free software; you can redistribute it and/or |
|
|
| modify it under the terms of the GNU General Public License |
|
|
| as published by the Free Software Foundation; either version 2 |
|
|
| of the License, or (at your option) any later version. |
|
|
| |
|
|
| This program is distributed in the hope that it will be useful, |
|
|
| but WITHOUT ANY WARRANTY; without even the implied warranty of |
|
|
| MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
|
|
| GNU General Public License for more details. |
|
|
+-------------------------------------------------------------------------+
|
|
| Cacti: The Complete RRDtool-based Graphing Solution |
|
|
+-------------------------------------------------------------------------+
|
|
| This code is designed, written, and maintained by the Cacti Group. See |
|
|
| about.php and/or the AUTHORS file for specific developer information. |
|
|
+-------------------------------------------------------------------------+
|
|
| http://www.cacti.net/ |
|
|
+-------------------------------------------------------------------------+
|
|
*/
|
|
|
|
require('./include/global.php');
|
|
|
|
set_default_action();
|
|
|
|
$action = grv('action');
|
|
|
|
switch ($action) {
|
|
case 'checkpass':
|
|
$error = secpass_check_pass(gnrv('password'));
|
|
|
|
if ($error != '') {
|
|
print $error;
|
|
} else {
|
|
print 'ok';
|
|
}
|
|
|
|
exit;
|
|
default:
|
|
/**
|
|
* If the user is not logged in, redirect them back to the page
|
|
* they came from, or to the login page.
|
|
*/
|
|
if (!isset($_SESSION[SESS_USER_ID])) {
|
|
$referer = validate_redirect_url($_SERVER['HTTP_REFERER'] ?? '', 'index.php');
|
|
header("Location: $referer");
|
|
exit;
|
|
}
|
|
}
|
|
|
|
$return = validate_redirect_url($_SERVER['HTTP_REFERER'] ?? '', 'index.php');
|
|
|
|
if (basename($return) != 'auth_changepassword.php') {
|
|
if (strpos($return, '/plugins/') !== false) {
|
|
$parts = explode('/plugins/', $return);
|
|
$return = CACTI_PATH_URL . 'plugins/' . $parts[1];
|
|
} else {
|
|
$return = CACTI_PATH_URL . basename($return);
|
|
}
|
|
|
|
$_SESSION['acp_return'] = $return;
|
|
} else {
|
|
if (isset($_SESSION['acp_return'])) {
|
|
$return = $_SESSION['acp_return'];
|
|
} else {
|
|
$return = CACTI_PATH_URL . 'index.php';
|
|
}
|
|
}
|
|
|
|
$user = db_fetch_row_prepared('SELECT *
|
|
FROM user_auth
|
|
WHERE id = ?',
|
|
[$_SESSION[SESS_USER_ID]]);
|
|
|
|
$version = CACTI_VERSION;
|
|
|
|
global $user_auth_realm_filenames;
|
|
|
|
if (!cacti_sizeof($user) || $user['realm'] != 0) {
|
|
if (!cacti_sizeof($user)) {
|
|
raise_message(44);
|
|
} else {
|
|
raise_message('nodomainpassword');
|
|
}
|
|
|
|
$return = validate_redirect_url($_SERVER['HTTP_REFERER'] ?? '', 'index.php');
|
|
|
|
header("Location: $return");
|
|
|
|
exit;
|
|
}
|
|
|
|
if ($user['password_change'] != 'on') {
|
|
raise_message('nopassword');
|
|
|
|
// destroy session information
|
|
kill_session_var(SESS_USER_ID);
|
|
cacti_cookie_logout();
|
|
|
|
$return = validate_redirect_url($_SERVER['HTTP_REFERER'] ?? '', 'index.php');
|
|
|
|
header("Location: $return");
|
|
|
|
exit;
|
|
}
|
|
|
|
// find out if we are logged in as a 'guest user' or not, if we are redirect away from password change
|
|
if (cacti_sizeof($user) && $user['id'] === get_guest_account()) {
|
|
header('Location: graph_view.php');
|
|
|
|
exit;
|
|
}
|
|
|
|
// default to !bad_password
|
|
$bad_password = false;
|
|
$errorMessage = '';
|
|
|
|
switch ($action) {
|
|
case 'changepassword':
|
|
// Get current user
|
|
$user_id = intval($_SESSION[SESS_USER_ID]);
|
|
|
|
// Get passwords entered for change
|
|
$password = gnrv('password');
|
|
$password_confirm = gnrv('password_confirm');
|
|
|
|
// Get current password as entered
|
|
$current_password = gnrv('current_password');
|
|
|
|
// Secpass checking
|
|
$error = secpass_check_pass($password);
|
|
|
|
// Check new password passes basic checks
|
|
if ($error != 'ok') {
|
|
$bad_password = true;
|
|
$errorMessage = "<span class='badpassword_message'>$error</span>";
|
|
|
|
break;
|
|
}
|
|
|
|
// Check user password history
|
|
if (!secpass_check_history($user_id, $password)) {
|
|
$bad_password = true;
|
|
$errorMessage = "<span class='badpassword_message'>" . __('You cannot use a previously entered password!') . '</span>';
|
|
|
|
break;
|
|
}
|
|
|
|
// Password and Confirmed password checks
|
|
if ($password !== $password_confirm) {
|
|
$bad_password = true;
|
|
$errorMessage = "<span class='badpassword_message'>" . __('Your new passwords do not match, please retype.') . '</span>';
|
|
|
|
break;
|
|
}
|
|
|
|
// Compare current password with stored password
|
|
if ((!empty($user['password']) || !empty($current_password)) && !compat_password_verify($current_password, $user['password'])) {
|
|
$bad_password = true;
|
|
$errorMessage = "<span class='badpassword_message'>" . __('Your current password is not correct. Please try again.') . '</span>';
|
|
|
|
break;
|
|
}
|
|
|
|
// Check new password does not match stored password
|
|
if (compat_password_verify($password, $user['password'])) {
|
|
$bad_password = true;
|
|
$errorMessage = "<span class='badpassword_message'>" . __('Your new password cannot be the same as the old password. Please try again.') . '</span>';
|
|
|
|
break;
|
|
}
|
|
|
|
// If password isn't blank, password change is good to go
|
|
if ($password != '') {
|
|
if (read_config_option('secpass_expirepass') > 0) {
|
|
db_execute_prepared("UPDATE user_auth
|
|
SET lastchange = ?
|
|
WHERE id = ?
|
|
AND realm = 0
|
|
AND enabled = 'on'",
|
|
[time(), $user_id]);
|
|
}
|
|
|
|
$history = intval(read_config_option('secpass_history'));
|
|
|
|
if ($history > 0) {
|
|
$h = db_fetch_row_prepared("SELECT password, password_history
|
|
FROM user_auth
|
|
WHERE id = ?
|
|
AND realm = 0
|
|
AND enabled = 'on'",
|
|
[$user_id]);
|
|
|
|
$op = $h['password'];
|
|
$h = explode('|', $h['password_history']);
|
|
|
|
while (cacti_count($h) > $history - 1) {
|
|
array_shift($h);
|
|
}
|
|
|
|
$h[] = $op;
|
|
$h = implode('|', $h);
|
|
|
|
db_execute_prepared("UPDATE user_auth
|
|
SET password_history = ?
|
|
WHERE id = ?
|
|
AND realm = 0
|
|
AND enabled = 'on'",
|
|
[$h, $user_id]);
|
|
}
|
|
|
|
db_execute_prepared('INSERT IGNORE INTO user_log
|
|
(username, result, time, ip)
|
|
VALUES (?, 3, NOW(), ?)',
|
|
[$user['username'], get_client_addr()]);
|
|
|
|
db_check_password_length();
|
|
|
|
db_execute_prepared("UPDATE user_auth
|
|
SET must_change_password = '', password = ?
|
|
WHERE id = ?",
|
|
[compat_password_hash($password,PASSWORD_DEFAULT), $user_id]);
|
|
|
|
// Clear the auth cache for the user
|
|
db_execute_prepared('DELETE FROM user_auth_cache
|
|
WHERE user_id = ?',
|
|
[$_SESSION[SESS_USER_ID]]);
|
|
|
|
// Delete any user login sessions if using database sessions
|
|
db_execute_prepared('DELETE FROM sessions
|
|
WHERE user_id = ?',
|
|
[$_SESSION[SESS_USER_ID]]);
|
|
|
|
kill_session_var(SESS_CHANGE_PASSWORD);
|
|
kill_session_var(SESS_USER_ID);
|
|
|
|
raise_message('password_success');
|
|
|
|
header('Location: logout.php');
|
|
|
|
exit;
|
|
} else {
|
|
$bad_password = true;
|
|
}
|
|
|
|
break;
|
|
}
|
|
|
|
if (api_plugin_hook_function('custom_password', OPER_MODE_NATIVE) == OPER_MODE_RESKIN) {
|
|
exit;
|
|
}
|
|
|
|
if (grv('action') == 'force') {
|
|
$errorMessage = "<span class='loginErrors'>*** " . __('Forced password change') . ' ***</span>';
|
|
}
|
|
|
|
// Create tooltip for password complexity
|
|
$secpass_tooltip = "<span style='font-weight:normal;'>" . __('Password requirements include:') . '</span><br>';
|
|
$secpass_body = '';
|
|
|
|
if (read_config_option('secpass_minlen') > 0) {
|
|
$secpass_body .= __('Must be at least %d characters in length', read_config_option('secpass_minlen'));
|
|
}
|
|
|
|
if (read_config_option('secpass_reqmixcase') == 'on') {
|
|
$secpass_body .= ($secpass_body != '' ? '<br>' : '') . __('Must include mixed case');
|
|
}
|
|
|
|
if (read_config_option('secpass_reqnum') == 'on') {
|
|
$secpass_body .= ($secpass_body != '' ? '<br>' : '') . __('Must include at least 1 number');
|
|
}
|
|
|
|
if (read_config_option('secpass_reqspec') == 'on') {
|
|
$secpass_body .= ($secpass_body != '' ? '<br>' : '') . __('Must include at least 1 special character');
|
|
}
|
|
|
|
if (read_config_option('secpass_history') != '0') {
|
|
$secpass_body .= ($secpass_body != '' ? '<br>' : '') . __('Cannot be reused for %d password changes', read_config_option('secpass_history') + 1);
|
|
}
|
|
|
|
$secpass_tooltip .= $secpass_body;
|
|
|
|
$selectedTheme = get_selected_theme();
|
|
|
|
$skip_current = (empty($user['password']));
|
|
|
|
if (isrv('ref')) {
|
|
$ref_parts = parse_url(gnrv('ref'));
|
|
$valid = false;
|
|
|
|
// It's an array, so valid URL
|
|
if (is_array($ref_parts)) {
|
|
$valid = true;
|
|
}
|
|
|
|
// Someone trying to login via a get is bad!
|
|
if (isset($ref_parts['user']) || isset($ref_parts['pass'])) {
|
|
$valid = false;
|
|
}
|
|
|
|
// Someone trying to send an invalid host
|
|
if (!isset($ref_parts['host'])) {
|
|
$valid = false;
|
|
}
|
|
|
|
if ($valid) {
|
|
$server_addr = $_SERVER['SERVER_ADDR'];
|
|
|
|
if (!filter_var($_SERVER['SERVER_NAME'], FILTER_VALIDATE_IP)) {
|
|
$server_info = dns_get_record($_SERVER['SERVER_NAME'], DNS_ANY);
|
|
$server_ref = gethostbyname($ref_parts['host']);
|
|
|
|
if ($server_ref != $server_addr) {
|
|
$valid = false;
|
|
}
|
|
|
|
if (!$valid && cacti_sizeof($server_info)) {
|
|
foreach (($server_info ?: []) as $record) {
|
|
if (isset($record['host']) && $record['host'] == $server_ref) {
|
|
$valid = true;
|
|
|
|
break;
|
|
}
|
|
|
|
if (isset($record['target']) && $record['target'] == $server_ref) {
|
|
$valid = true;
|
|
|
|
break;
|
|
}
|
|
|
|
if (isset($record['ip']) && $record['ip'] == $server_addr) {
|
|
$valid = true;
|
|
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
} else {
|
|
$server_ip = gethostbyname($_SERVER['SERVER_NAME']);
|
|
$server_ref = gethostbyname($ref_parts['host']);
|
|
|
|
if ($server_ip == $server_ref) {
|
|
$valid = true;
|
|
}
|
|
}
|
|
} else {
|
|
$valid = false;
|
|
}
|
|
|
|
if (!$valid) {
|
|
cacti_log('WARNING: User attempted to access Cacti from unknown URL', false, 'AUTH');
|
|
|
|
raise_message('problems_with_page', __('There are problems with the Change Password page. Contact your Cacti administrator right away.'), MESSAGE_LEVEL_ERROR);
|
|
|
|
header('Location:index.php');
|
|
|
|
exit;
|
|
}
|
|
}
|
|
|
|
if ($skip_current) {
|
|
$title_message = __('Please enter your current password and your new<br>Cacti password.');
|
|
} else {
|
|
$title_message = __('Please enter your new Cacti password.');
|
|
}
|
|
|
|
html_auth_header('change_password', __('Change Password'), __('Change Password'), $title_message);
|
|
?>
|
|
<tr style='display:none'>
|
|
<td>
|
|
<input type='hidden' name='action' value='changepassword'>
|
|
<input type='hidden' name='ref' value='<?php print htmle(grv('ref')); ?>'>
|
|
<input type='hidden' name='name' value='<?php print isset($user['username']) ? htmle($user['username']) : ''; ?>'>
|
|
<input type='text'><input type='password'></td>
|
|
</td>
|
|
</tr>
|
|
<tr>
|
|
<?php if ($skip_current) { ?>
|
|
<td><?php print __('Username'); ?></td>
|
|
<td class='nowrap'><input type='hidden' id='current' name='current_password' value=''><?php print $user['username']; ?></td>
|
|
<?php } else { ?>
|
|
<td><?php print __('Current password'); ?></td>
|
|
<td class='nowrap'><input type='password' class='ui-state-default ui-corner-all' id='current' name='current_password' autocomplete='current-password' size='15' maxlength='25' placeholder='********'></td><td></td>
|
|
<?php } ?>
|
|
</tr>
|
|
<tr>
|
|
<td><?php print __('New password'); ?></td>
|
|
<td class='nowrap'><input type='password' class='ui-state-default ui-corner-all' id='password' name='password' autocomplete='off' size='15' maxlength='25' placeholder='********'></td><td id='pass_details'><div id='pass' style='float:left;'></div><?php print display_tooltip($secpass_tooltip); ?></td>
|
|
</tr>
|
|
<tr>
|
|
<td><?php print __('Confirm password'); ?></td>
|
|
<td class='nowrap'><input type='password' class='ui-state-default ui-corner-all' id='password_confirm' name='password_confirm' autocomplete='off' size='15' maxlength='25' placeholder='********'></td><td id='pass_details_conf'><div id='passconfirm' style='float:left;'></div></td>
|
|
</tr>
|
|
<tr>
|
|
<td colspan='3' class='nowrap'><button type='submit' class='ui-button ui-corner-all ui-widget ui-state-active' value='save'><?php print __esc('Save'); ?></button>
|
|
<?php if ($user['must_change_password'] != 'on') { ?>
|
|
<button type='button' class='ui-button ui-corner-all ui-widget' onClick='document.location=<?php print json_encode((string) $return); ?>'><?php print __esc('Return'); ?></button>
|
|
<?php } ?>
|
|
</td>
|
|
</tr>
|
|
<?php
|
|
$secpass_minlen = read_config_option('secpass_minlen');
|
|
|
|
html_auth_footer('change_password', $errorMessage, "
|
|
<script type='text/javascript'>
|
|
var password_change = $('#password_change').is(':checked');
|
|
|
|
$(function() {
|
|
$('#current').focus();
|
|
|
|
/* clear passwords */
|
|
$('#password').val('');
|
|
$('#password_confirm').val('');
|
|
});
|
|
</script>");
|