Files
cacti/cli/rebuild_poller_cache.php
T
TheWitnessandTheWitness 3ab4c69fb7 PHPStan Level 8 - Phase 1 Conversion (#8135)
* PHPStan Level 8 - Phase 1 Conversion

Reduces the real (no-baseline) PHPStan level 8 error count from ~2,724 to 425
and regenerates phpstan-baseline.neon accordingly (8,941 -> 1,921 lines).

Core type-safety changes
- lib/database.php: narrow db_fetch_row()/db_fetch_row_prepared() to return
  array (was bool|array) and db_fetch_assoc()/db_fetch_assoc_prepared() to
  return array (was mixed); the _prepared workers coerce the connection-failure
  path to an empty array so the declared type is honest. empty()/cacti_sizeof()
  checks are unaffected.
- lib/database.php: narrow $db_conn guards from is_object() to instanceof PDO in
  the transaction/quote/insert-id helpers so the PDO calls resolve.
- lib/mib_cache.php: the fluent MibCache methods mib()/object()/table()/row()
  now return self instead of a bare object so chained calls type-check.

Type-safety casts and guards (mechanical, behaviour-preserving)
- Cast string|false/|null builtin results feeding string parameters
  (json_decode, base64_encode, trim, htmle, preg_replace, explode, etc.).
- Cast int|string / int|false values feeding int id/pid parameters.
- Guard resource|false fopen()/popen() handles before fwrite/fclose/fread, and
  wrap foreach over array|false/list|false results with `?: []`.

Genuine bugs found and fixed
- cli/add_tree.php / lib/api_tree.php: site tree nodes could not be created via
  the CLI - the --site-id option was never parsed, $nodeTypes had no 'site'
  entry (passing null to api_tree_item_save(int $type) -> TypeError), and
  api_tree_item_save() never persisted site_id. All three fixed.
- tree.php: leaves_exist() is typed : int but returned db_fetch_assoc_prepared()
  (an array of rows) for a SELECT COUNT(*); now uses db_fetch_cell_prepared()
  and returns the scalar count.
- lib/mib_cache.php: $entries_per_object was a float (division / ceil) used as
  an array key (PHP 8.1 implicit float-to-int key deprecation); now cast to int.

Config
- .phpstan.neon: add notIdentical.alwaysTrue and booleanAnd.alwaysFalse to the
  existing always-true/false ignore family (same "PHPStan gets confused"
  dynamic-constant cause already covered by identical.alwaysTrue,
  notEqual.alwaysTrue, booleanAnd.leftAlwaysTrue, etc.).
- phpstan-baseline.neon: regenerated; the remaining 425 entries are the
  untouched long tail for Phase 2.

* Remove redundant @phpstan-ignore comments

Follow-up cleanup for the level 8 Phase 1 work. Removes 14 inline
@phpstan-ignore comments that no longer suppress any reported error:

- cli/repair_database.php: `@phpstan-ignore booleanAnd.alwaysFalse` is now
  covered by the global booleanAnd.alwaysFalse ignore added to .phpstan.neon.
- 13 others (host.php, include/global.php, include/session.php,
  lib/api_automation.php x2, lib/functions.php x2, lib/html_utility.php x2,
  lib/installer.php, lib/package.php, lib/reports.php, lib/rrd.php) no longer
  match any reported error after the type-safety fixes (e.g. the
  db_fetch_row_prepared() return-type narrowing removed the offset-assign
  errors the api_automation ignores were suppressing).

Verified with reportUnmatchedIgnoredErrors enabled: 0 unmatched ignores
remain and the full level 8 run still reports 0 errors.

* ci: satisfy validator ratchet and refresh security sink baselines

- lib/api_tree.php: give the new tree-item site_id a real numeric
  constraint ('^[-0-9]+$', matching html_reports.php) instead of an
  empty regex, so the validator constraint ratchet passes without
  bumping its baseline.
- tests/security/baselines: refresh the three sink/hotspot signatures
  whose code text changed from the (string) casts added in this branch
  (lib/poller.php setsid, cli/rrdresize.php json_encode, lib/import.php
  simplexml_load_string).

* ci(js): allow DOMPurify 3.4.16 and update sync_js pin test

The dependabot bump (#8134) moved package.json/package-lock.json to
DOMPurify 3.4.16 on develop but left tests/js/sync_js.test.mjs pinned to
3.4.15, so the PR merge commit fails the 'DOMPurify is pinned' contract.
Bring package.json/package-lock.json to 3.4.16 (matching develop) and
update the pin test to expect 3.4.16.

* test: update sql.php null-handling assertion for the (string) cast

This branch changed scripts/sql.php from trim(\ ?? '') to
trim((string) \) (the phpstan-safe form that coerces both null and
false from shell_exec()). Update SqlScriptsTest's null-return assertion
to match the new cast instead of the removed '?? ''.

* fix: address Copilot review - ownership IDs, fopen guards, mib_cache bound

- chown()/chgrp(): pass integer UID/GID from fileowner()/filegroup()
  (guarding the false lookup) instead of string-casting them, which made
  them resolve account/group names like '1001' and fail. Covers
  lib/api_device.php, lib/boost.php and poller_maintenance.php (x2).
- fopen() failure now short-circuits instead of reporting success:
  lib/package.php returns false, lib/clog_webapi.php and utilities.php
  render an error, and snmpagent_mibcachechild.php skips the cache write
  and sentinel unlink so a concurrent writer's lock is preserved.
- lib/mib_cache.php: keep the float quotient as the loop bound and cast
  only the array offset, so a non-even entries/columns split no longer
  truncates the loop and drops a cached row.

* revert: keep db_fetch_* returning false on error; baseline Level 8 instead

Per review, restoring the intentional fail-safe: db_fetch_row[_prepared]()
return bool|array and db_fetch_assoc[_prepared]() return mixed again, so a
genuine SQL error (not just a missing connection) is signalled as false and
the === false checks in cdef_is_in_use(), boost_process_* and aggregate.php
work as before. Dropped the is_array() ? : [] coercion.

Level 8 stays green by regenerating phpstan-baseline.neon to capture the
re-introduced bool|array/mixed call-site errors (the ~1,850 the narrowing
had eliminated). Tightening those callers to drop them from the baseline is
Phase 2 work.

---------

Co-authored-by: TheWitness <copilot@users.noreply.github.com>
2026-10-02 10:08:56 -04:00

475 lines
13 KiB
PHP
Executable File

#!/usr/bin/env php
<?php
/*
+-------------------------------------------------------------------------+
| Copyright (C) 2004-2026 The Cacti Group |
| |
| This program is free software; you can redistribute it and/or |
| modify it under the terms of the GNU General Public License |
| as published by the Free Software Foundation; either version 2 |
| of the License, or (at your option) any later version. |
| |
| This program is distributed in the hope that it will be useful, |
| but WITHOUT ANY WARRANTY; without even the implied warranty of |
| MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
| GNU General Public License for more details. |
+-------------------------------------------------------------------------+
| Cacti: The Complete RRDtool-based Graphing Solution |
+-------------------------------------------------------------------------+
| This code is designed, written, and maintained by the Cacti Group. See |
| about.php and/or the AUTHORS file for specific developer information. |
+-------------------------------------------------------------------------+
| http://www.cacti.net/ |
+-------------------------------------------------------------------------+
*/
if (function_exists('pcntl_async_signals')) {
pcntl_async_signals(true);
} else {
declare(ticks = 100);
}
ini_set('output_buffering', 'Off');
require(__DIR__ . '/../include/cli_check.php');
require_once(CACTI_PATH_LIBRARY . '/utility.php');
require_once(CACTI_PATH_LIBRARY . '/api_data_source.php');
require_once(CACTI_PATH_LIBRARY . '/poller.php');
// switch to main database for cli's
if (POLLER_ID > 1) {
db_switch_remote_to_main();
}
// process calling arguments
$parms = $_SERVER['argv'];
array_shift($parms);
// system controlled parameters
$type = 'rmaster';
$thread_id = 0;
// mandatory parameters
$start_time = false;
$end_time = false;
// optional parameters for host selection
$debug = false;
$host_id = 0;
$host_template_id = 0;
$data_template_id = 0;
// optional for threading and verbose display
$threads = detect_cpu_cores();
if ($threads == 0) {
$threads = 2;
}
// optional for force handing and resume
$forcerun = false;
foreach ($parms as $parameter) {
if (str_contains($parameter, '=')) {
[$arg, $value] = explode('=', $parameter, 2);
} else {
$arg = $parameter;
$value = '';
}
switch ($arg) {
case '--host-id':
$host_id = intval($value);
if ($host_id <= 0) {
print 'ERROR: You must supply a valid Device Id to run this script!' . PHP_EOL;
exit(1);
}
break;
case '--host-template-id':
$host_template_id = intval($value);
if ($host_template_id <= 0) {
print 'ERROR: You must supply a valid Device Template Id to run this script!' . PHP_EOL;
exit(1);
}
break;
case '--data-template-id':
$data_template_id = intval($value);
if ($data_template_id <= 0) {
print 'ERROR: You must supply a valid Data Template Id to run this script!' . PHP_EOL;
exit(1);
}
break;
case '--type':
$type = $value;
break;
case '--threads':
if (!is_numeric(trim($value))) {
print 'ERROR: You must supply a valid Number of Treads or skip this parameter for default value (' . $threads . ')' . PHP_EOL;
exit(1);
}
$threads = $value;
break;
case '--child':
$thread_id = (int) $value;
break;
case '--force':
$forcerun = true;
break;
case '-d':
case '--debug':
$debug = true;
break;
case '-h':
case '-H':
case '--help':
display_help();
exit;
case '-v':
case '-V':
case '--version':
display_version();
exit;
default:
print 'ERROR: Invalid Parameter ' . $parameter . PHP_EOL . PHP_EOL;
display_help();
exit;
}
}
/**
* allow multiple runs for each type. This is mainly important for
* the Data Template options to change the Profile Id of a data
* source or data template. These processes to repopulate the
* poller cache are done in succession in background.
*/
$rp_type = '';
if ($host_id > 0) {
$rp_type .= ($rp_type != '' ? ',' : ':') . "hi:$host_id";
}
if ($host_template_id > 0) {
$rp_type .= ($rp_type != '' ? ',' : ':') . "ht:$host_template_id";
}
if ($data_template_id > 0) {
$rp_type .= ($rp_type != '' ? ',' : ':') . "dt:$data_template_id";
}
// install signal handlers for UNIX only
if (function_exists('pcntl_signal')) {
pcntl_signal(SIGTERM, 'sig_handler');
pcntl_signal(SIGINT, 'sig_handler');
}
// take time and log performance data
$start = microtime(true);
// set new timeout and memory settings
ini_set('max_execution_time', '0');
ini_set('memory_limit', '-1');
// issue warnings and start message if applicable
print 'WARNING: Do not interrupt this script. Rebuilding Poller Cache can take quite some time' . PHP_EOL;
// send a gentle message to the log and stdout
pushout_debug('Rebuild poller cache starting');
// silently end if the registered process is still running
if (!$forcerun) {
if (!register_process_start('pushout' . $rp_type, $type, $thread_id, 86400)) {
exit(0);
}
}
// Collect data as determined by the type
switch ($type) {
case 'rmaster':
pushout_master_handler($forcerun, $host_id, $host_template_id, $data_template_id, $threads);
unregister_process('pushout' . $rp_type, 'rmaster', 0);
break;
case 'child': // Launched by the rmaster process
$child_start = microtime(true);
$sql_where = '';
$sql_params = [];
if ($host_id > 0) {
$sql_where .= 'AND id = ?';
$sql_params[] = $host_id;
}
if ($host_template_id > 0) {
$sql_where .= 'AND host_template_id = ?';
$sql_params[] = $host_template_id;
}
$rows = db_fetch_cell_prepared("SELECT COUNT(id) FROM host WHERE disabled = '' " . $sql_where, $sql_params);
$hosts_per_process = ceil($rows / $threads);
$sql_where .= ' GROUP BY h.id ORDER BY h.id LIMIT ' . (($thread_id - 1) * $hosts_per_process) . ',' . $hosts_per_process;
$rows = db_fetch_assoc_prepared("SELECT h.id AS id, COUNT(dl.id) AS dl_count
FROM host AS h
LEFT JOIN data_local AS dl
ON h.id=dl.host_id
WHERE h.disabled='' " . $sql_where,
$sql_params);
cacti_log(sprintf('Child Started Process %s with %d hosts, from: %d', $thread_id, $hosts_per_process, ($thread_id - 1) * $hosts_per_process), true, 'PUSHOUT');
foreach ($rows as $row) {
if (!$debug) {
print '.';
}
if ($row['dl_count'] > 0) {
push_out_host($row['id'], 0, $data_template_id);
} else {
db_execute_prepared('DELETE FROM poller_item WHERE host_id = ?', [$row['id']]);
}
}
$total_time = microtime(true) - $child_start;
unregister_process('pushout' . $rp_type, 'child', $thread_id);
break;
}
pushout_debug('Polling Ending');
exit(0);
function pushout_master_handler(bool $forcerun, int $host_id, int $host_template_id, int $data_template_id, int $threads) : bool {
global $type;
$sql_where = '';
$sql_params = [];
if ($host_id > 0) {
$sql_where .= 'AND id = ?';
$sql_params[] = $host_id;
}
if ($host_template_id > 0) {
$sql_where .= 'AND host_template_id = ?';
$sql_params[] = $host_template_id;
}
$rows = db_fetch_cell_prepared("SELECT COUNT(id)
FROM host
WHERE disabled = '' " . $sql_where, $sql_params);
if ($rows == 0) {
print 'WARNING: There are no hosts to process' . PHP_EOL;
return false;
}
$hosts_per_process = ceil($rows / $threads);
print "There are $rows hosts, $threads threads and $hosts_per_process hosts to process per thread" . PHP_EOL;
$h_done = 0;
for ($thread_id = 1; $h_done < $rows; $thread_id++) {
pushout_debug("Launching Process ID $thread_id");
pushout_launch_child($thread_id, $threads);
$h_done += $hosts_per_process;
}
$starting = true;
while (true) {
if ($starting) {
sleep(5);
$starting = false;
}
$running = pushout_processes_running();
if ($running > 0) {
pushout_debug(sprintf('%s Processes Running, keeping for 2 seconds.', $running));
sleep(2);
} else {
break;
}
}
return true;
}
/**
* pushout_launch_child - this function will launch collector children based upon
* the maximum number of threads and the process type
*
* @param int $thread_id The Thread id to launch with
* @param int $threads The number of threads to run with
*
* @return void
*/
function pushout_launch_child(int $thread_id, int $threads) : void {
global $config, $debug, $host_template_id, $data_template_id;
$php_binary = read_config_option('path_php_binary');
pushout_debug(sprintf('Launching Rebuild poller cache Process Number %s for Type %s', $thread_id, 'child'));
cacti_log(sprintf('NOTE: Launching Rebuild poller cache Number %s for Type %s', $thread_id, 'child'), true, 'PUSHOUT', POLLER_VERBOSITY_MEDIUM);
exec_background($php_binary, CACTI_PATH_CLI . "/rebuild_poller_cache.php --type=child --threads=$threads --child=$thread_id " . ($debug ? ' --debug' : '') . ($host_template_id ? " --host-template-id=$host_template_id" : '') . ($data_template_id ? " --data-template-id=$data_template_id" : ''));
}
/**
* pushout_processes_running - given a type, determine the number
* of sub-type or children that are currently running
*
* @return int - The number of running processes
*/
function pushout_processes_running() : int {
$running = db_fetch_cell('SELECT COUNT(*)
FROM processes
WHERE tasktype = "pushout"
AND taskname = "child"');
return intval($running);
}
/**
* pushout_debug - this simple routine prints a standard message to the console
* when running in debug mode.
*
* @param string $message The message to display
*
* @return void
*/
function pushout_debug(string $message) : void {
global $debug;
if ($debug) {
print 'PUSHOUT: ' . trim($message) . PHP_EOL;
}
}
/**
* sig_handler - provides a generic means to catch exceptions to the Cacti log.
*
* @param int $signo The signal that was thrown by the interface.
*
* @return void
*/
function sig_handler(int $signo) : void {
global $type, $thread_id, $rp_type;
switch ($signo) {
case SIGTERM:
case SIGINT:
cacti_log('WARNING: Rebuild poller cache terminated by user', false, 'PUSHOUT');
if (str_contains($type, 'rmaster')) {
pushout_kill_running_processes();
}
unregister_process('pushout' . $rp_type, 'rmaster', $thread_id, (int) getmypid());
exit(1);
default:
// ignore all other signals
}
}
/**
* pushout_kill_running_processes - this function is part of an interrupt
* handler to kill children processes when the parent is killed
*
* @return void
*/
function pushout_kill_running_processes() : void {
global $type;
$processes = db_fetch_assoc_prepared('SELECT *
FROM processes
WHERE tasktype = "pushout"
AND taskname IN ("child")
AND pid != ?',
[getmypid()]);
if (cacti_sizeof($processes)) {
foreach ($processes as $p) {
if (cacti_process_still_running((int) $p['pid'])) {
cacti_log(sprintf('WARNING: Killing Cleanup %s PID %d due to another due to signal or overrun.', ucfirst($p['taskname']), $p['pid']), false, 'PUSHOUT');
cacti_process_kill((int) $p['pid'], SIGTERM, 'PUSHOUT');
}
unregister_process($p['tasktype'], $p['taskname'], $p['taskid'], $p['pid']);
}
}
}
/**
* display_version - displays version information
*
* @return void
*/
function display_version() : void {
print 'Cacti Rebuild poller cache Tool, Version ' . CACTI_VERSION . ' ' . COPYRIGHT_YEARS . PHP_EOL;
}
/**
* display_help - generic help screen for utilities
*
* @return void
*/
function display_help() : void {
display_version();
print PHP_EOL . 'usage: rebuild_poller_cache.php [--host-id=N] [--host-template-id=N] [--data-template-id=N] [--debug]' . PHP_EOL . PHP_EOL;
print 'Cacti\'s repopulate poller cache tool. This CLI script will ' . PHP_EOL;
print 'repopulate poller cache for all or specified hosts.' . PHP_EOL . PHP_EOL;
print 'This utility will run in parallel with the given number of threads.' . PHP_EOL;
print 'If threads argument is not specified, value is derived from the number of processor cores.' . PHP_EOL;
print 'In case of a detection problem, 2 threads are used.' . PHP_EOL . PHP_EOL;
print 'Optional:' . PHP_EOL;
print ' --threads=N - The number of threads to use to repopulate' . PHP_EOL;
print ' --host-id=N - Run for a specific Device' . PHP_EOL;
print ' --host-template-id=N - Run for a specific Device Template' . PHP_EOL;
print ' --data-template-id=N - Run for a specific Data Template' . PHP_EOL;
print ' --debug - Display verbose output during execution' . PHP_EOL . PHP_EOL;
print 'System Controlled:' . PHP_EOL;
print ' --type - The type and subtype of the rebuild poller cache process' . PHP_EOL;
print ' --child - The thread id of the child process' . PHP_EOL . PHP_EOL;
}