Files
cacti/scripts/ss_cpoller.php
T
Thomas VincentandCopilot 78e4644f9f fix: harden data collection scripts — SQL injection, counter math, column allow-listing (#6651)
* cleanup: remove unreachable defensive error logs in aggregate graph item validation

* fix: harden data collection scripts with correct SNMP retry parameter

Replace $host['ping_retries'] with $host['snmp_retries'] across all
SNMP data collection scripts. Add column allow-lists for MikroTik
scripts to prevent SQL injection via column name interpolation.

Add Pest tests verifying column allow-lists reject injection attempts
and all scripts reference snmp_retries instead of ping_retries.

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

* fix: consolidate disk device detection with preg_match

Replace 8 str_starts_with() calls with a single preg_match() in
ss_net_snmp_disk_io.php for readability. Align ss_net_snmp_disk_bytes.php
with the same device prefixes (xvd, vd, hd, md, dm-) and improved
nvme-aware partition filter.

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

* chore: drop unrelated lib/api_aggregate changes

Keep PR scope focused on the issue for this branch.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

---------

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-05 20:09:08 -05:00

175 lines
4.9 KiB
PHP
Executable File

#!/usr/bin/env php
<?php
/*
+-------------------------------------------------------------------------+
| Copyright (C) 2004-2026 The Cacti Group |
| |
| This program is free software; you can redistribute it and/or |
| modify it under the terms of the GNU General Public License |
| as published by the Free Software Foundation; either version 2 |
| of the License, or (at your option) any later version. |
| |
| This program is distributed in the hope that it will be useful, |
| but WITHOUT ANY WARRANTY; without even the implied warranty of |
| MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
| GNU General Public License for more details. |
+-------------------------------------------------------------------------+
| Cacti: The Complete RRDtool-based Graphing Solution |
+-------------------------------------------------------------------------+
| This code is designed, written, and maintained by the Cacti Group. See |
| about.php and/or the AUTHORS file for specific developer information. |
+-------------------------------------------------------------------------+
| http://www.cacti.net/ |
+-------------------------------------------------------------------------+
*/
error_reporting(0);
if (!isset($called_by_script_server)) {
include_once(__DIR__ . '/../include/cli_check.php');
array_shift($_SERVER['argv']);
print call_user_func_array('ss_cpoller', $_SERVER['argv']);
}
function ss_cpoller(string $cmd = 'index', string $arg1 = '', string $arg2 = '') : mixed {
if ($cmd == 'index') {
$collectors = db_fetch_assoc('SELECT id FROM poller ORDER BY id');
if (cacti_sizeof($collectors)) {
foreach ($collectors as $collector) {
print $collector['id'] . PHP_EOL;
}
}
} elseif ($cmd == 'query') {
$arg = $arg1;
if ($arg1 == 'pollerId') {
$arr = db_fetch_assoc('SELECT id FROM poller ORDER BY id');
if (cacti_sizeof($arr)) {
foreach ($arr as $item) {
print $item['id'] . '!' . $item['id'] . PHP_EOL;
}
}
} elseif ($arg1 == 'pollerName') {
$arr = db_fetch_assoc('SELECT id, name FROM poller ORDER BY id');
if (cacti_sizeof($arr)) {
foreach ($arr as $item) {
print $item['id'] . '!' . $item['name'] . PHP_EOL;
}
}
}
} elseif ($cmd == 'get') {
$arg = $arg1;
$index = $arg2;
$value = '0';
switch($arg) {
case 'recacheTime':
$value = '0';
$stats = explode(' ', db_fetch_cell_prepared('SELECT value FROM settings WHERE name = ?', ['stats_recache_' . $index]));
foreach ($stats as $_stat) {
if (preg_match('/^RecacheTime:/', $_stat)) {
$parts = explode(':', $_stat);
$value = $parts[1];
}
}
break;
case 'recacheDevices':
$value = '0';
$stats = explode(' ', db_fetch_cell_prepared('SELECT value FROM settings WHERE name = ?', ['stats_recache_' . $index]));
foreach ($stats as $_stat) {
if (preg_match('/^DevicesRecached:/', $_stat)) {
$parts = explode(':', $_stat);
$value = $parts[1];
}
}
break;
case 'avgTime':
$value = db_fetch_cell_prepared('SELECT avg_time
FROM poller
WHERE id = ?',
[$index]);
break;
case 'minTime':
$value = db_fetch_cell_prepared('SELECT min_time
FROM poller
WHERE id = ?',
[$index]);
break;
case 'maxTime':
$value = db_fetch_cell_prepared('SELECT max_time
FROM poller
WHERE id = ?',
[$index]);
break;
case 'processCount':
$value = db_fetch_cell_prepared('SELECT processes
FROM poller
WHERE id = ?',
[$index]);
break;
case 'threadCount':
$value = db_fetch_cell_prepared('SELECT threads
FROM poller
WHERE id = ?',
[$index]);
break;
case 'pollerTime':
$value = db_fetch_cell_prepared('SELECT total_time
FROM poller
WHERE id = ?',
[$index]);
break;
case 'getSNMP':
$value = db_fetch_cell_prepared('SELECT snmp
FROM poller
WHERE id = ?',
[$index]);
break;
case 'getScript':
$value = db_fetch_cell_prepared('SELECT script
FROM poller
WHERE id = ?',
[$index]);
break;
case 'getScriptServer':
$value = db_fetch_cell_prepared('SELECT server
FROM poller
WHERE id = ?',
[$index]);
break;
case 'getErrorHosts':
$value = db_fetch_cell_prepared('SELECT COUNT(DISTINCT host_id)
FROM host_errors WHERE poller_id = ?', [$index]);
break;
case 'getTotalErrors':
$value = db_fetch_cell_prepared('SELECT SUM(errors)
FROM host_errors WHERE poller_id = ?', [$index]);
break;
}
return ($value == '' ? '0' : $value);
}
return 'U';
}