Files
cacti/link.php
T
Thomas VincentandTheWitness fcbcbdd1d7 refactor: replace strpos() boolean checks with str_contains/str_starts_with (#6645)
* refactor: replace strpos() boolean checks with str_contains/str_starts_with

Completes the PHP 8.x string function migration started in lib/.
Converts remaining legacy patterns across 81 files:

- strpos($x, $y) !== false → str_contains($x, $y)
- strpos($x, $y) === false → !str_contains($x, $y)
- strpos($x, $y) != false  → str_contains($x, $y)
- bare if (strpos($x, $y)) → if (str_contains($x, $y))
- substr($x, 0, strlen($y)) == $y → str_starts_with($x, $y)

Intentionally preserves strpos() calls that use the return value as
an integer offset:
- user_admin.php / user_group_admin.php (4 calls, ternary for position)
- auth_profile.php (2 calls, offset for substr); guards fixed from
  bare if ($pos) to if ($pos !== false)

Behavior fix: ss_esxi_vhosts.php:55 bare strpos() missed position-0
matches; str_contains() now correctly detects 'not installed' at any
position. Adjacent line already used str_contains().

Ref: https://github.com/Cacti/cacti/issues/6641

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

* fix: correct dead-code elseif in plugin_display_compat() version comparison

The if/elseif chain in plugin_display_compat() checked >=, >=, >, <
— the second >= was unreachable dead code. Corrected to <= to complete
the operator set (>=, <=, >, <).

Without this fix, <= constraints (e.g. "<=1.2") fell through to the <
branch and were rendered as "< =1.2" instead of "<= 1.2".

This pre-existing bug was exposed when converting strpos() to
str_contains(), which made PHPStan detect the always-false condition.

Ref: https://github.com/Cacti/cacti/issues/6641

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

* fix: add limit to explode('=') in CLI argument parsers

17 CLI scripts used explode('=', $parameter) without a limit of 2,
silently truncating values containing = (e.g. --note=a=b parsed as
$value='a' instead of 'a=b'). The other 40 CLI scripts already had
the correct limit.

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>

---------

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Co-authored-by: TheWitness <thewitness@cacti.net>
2026-02-25 11:38:59 -05:00

106 lines
3.8 KiB
PHP

<?php
/*
+-------------------------------------------------------------------------+
| Copyright (C) 2004-2026 The Cacti Group |
| |
| This program is free software; you can redistribute it and/or |
| modify it under the terms of the GNU General Public License |
| as published by the Free Software Foundation; either version 2 |
| of the License, or (at your option) any later version. |
| |
| This program is distributed in the hope that it will be useful, |
| but WITHOUT ANY WARRANTY; without even the implied warranty of |
| MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
| GNU General Public License for more details. |
+-------------------------------------------------------------------------+
| Cacti: The Complete RRDtool-based Graphing Solution |
+-------------------------------------------------------------------------+
| This code is designed, written, and maintained by the Cacti Group. See |
| about.php and/or the AUTHORS file for specific developer information. |
+-------------------------------------------------------------------------+
| http://www.cacti.net/ |
+-------------------------------------------------------------------------+
*/
require_once('./include/global.php');
$page = db_fetch_row_prepared('SELECT
id, title, style, contentfile, enabled, refresh
FROM external_links AS el
WHERE id = ?',
[gfrv('id')]);
// Prevent redirect loops
if (isset($_SERVER['HTTP_REFERER'])) {
if (!str_contains($_SERVER['HTTP_REFERER'], 'link.php')) {
$referer = $_SERVER['HTTP_REFERER'];
$_SESSION['link_referer'] = $referer;
} elseif (isset($_SESSION['link_referer'])) {
$referer = sanitize_uri($_SESSION['link_referer']);
} else {
$referer = 'index.php';
}
} elseif (isset($_SESSION['link_referer'])) {
$referer = sanitize_uri($_SESSION['link_referer']);
} else {
$referer = 'index.php';
}
if (!cacti_sizeof($page)) {
raise_message('page_not_defined');
header('Location: ' . $referer);
exit;
} else {
global $link_nav;
if (is_realm_allowed($page['id'] + 10000)) {
unset($refresh);
if (!empty($page['refresh'])) {
$refresh['seconds'] = $page['refresh'];
$refresh['page'] = CACTI_PATH_URL . 'link.php?id=' . grv('id');
}
if ($page['style'] == 'TAB') {
$link_nav['link.php:']['title'] = $page['title'];
$link_nav['link.php:']['mapping'] = '';
general_header();
} else {
$link_nav['link.php:']['title'] = $page['title'];
$link_nav['link.php:']['mapping'] = 'index.php:';
top_header();
}
if (preg_match('/^((((ht|f)tp(s?))\:\/\/){1}\S+)/i', $page['contentfile'])) {
if (filter_var($page['contentfile'], FILTER_VALIDATE_URL)) {
print '<iframe id="content" src="' . htmle($page['contentfile']) . '" sandbox="allow-scripts allow-popups allow-forms" frameborder="0"></iframe>';
} else {
$message = __esc("External Link ID '%s' with Title '%s' attempted to inject an invalid URL and was blocked!", $page['id'], $page['title']);
cacti_log($message, false, 'SECURITY');
raise_message('invalid_url', $message, MESSAGE_LEVEL_ERROR);
}
} else {
print '<div id="content">';
$basepath = CACTI_PATH_INCLUDE . '/content';
$file = realpath($basepath . '/' . $page['contentfile']);
if ($file !== false && str_starts_with($file, $basepath)) {
require_once($file);
} else {
print '<h1>The file \'' . htmle($page['contentfile']) . '\' does not exist!!</h1>';
}
print '</div>';
}
bottom_footer();
} else {
raise_message('permission_denied');
header('Location: ' . $referer);
exit;
}
}