From 020e76a84284afe22b20abc29f9bf22ba700ee8d Mon Sep 17 00:00:00 2001 From: Myasnikov Daniil Date: Tue, 23 Jun 2026 17:29:10 +0500 Subject: [PATCH] fix(hack): verify mikefarah yq in promote-retag Address review feedback from gemini-code-assist on hack/promote-retag.sh:27: command -v yq only confirms some yq is on PATH; the script's queries use mikefarah syntax, so reject python-yq and other variants by checking the version string, mirroring the Makefile build-deps check. Assisted-By: Claude Signed-off-by: Myasnikov Daniil --- hack/promote-retag.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hack/promote-retag.sh b/hack/promote-retag.sh index 7052a65e7..b7c760c44 100755 --- a/hack/promote-retag.sh +++ b/hack/promote-retag.sh @@ -24,6 +24,9 @@ DRY_RUN=0 [ "${2:-}" = "--dry-run" ] && DRY_RUN=1 command -v yq >/dev/null || { echo "yq (mikefarah) is required" >&2; exit 1; } +# The queries below use mikefarah syntax; reject python-yq and other variants +# (mirrors the build-deps check in the Makefile). +yq --version 2>&1 | grep -q mikefarah || { echo "yq (mikefarah) is required" >&2; exit 1; } command -v skopeo >/dev/null || { echo "skopeo is required" >&2; exit 1; } # Collect "repo@sha256:..." refs from every package values.yaml, across the