From 9a782f697a4bd75bbd206d8f784fdb67772f64e6 Mon Sep 17 00:00:00 2001 From: Myasnikov Daniil Date: Wed, 21 Oct 2026 15:04:39 +0500 Subject: [PATCH] fix(hack): keep the backup stack in the vminstance selective install The vminstance Chainsaw suite carries the VMInstance and VMDisk Velero round-trips. Both build the cozy-default BackupStorageLocation and the platform bucket from the backupstrategy-controller package, but the selective install retained that package only for the database and broker suites. A selection of vminstance alone therefore installed a platform with no Bucket, no BucketClaim and no BSL, and both round-trips timed out on the BSL wait before running a step of the example scripts. Every pull request whose selection is exactly vminstance hits this, and that includes each edit to examples/backups/vmi and examples/backups/vmdisk, which select that suite on purpose. Assisted-by: LLM Signed-off-by: Myasnikov Daniil --- hack/select-install.sh | 2 +- hack/select-install_test.bats | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hack/select-install.sh b/hack/select-install.sh index cea5442a8..15acf8aca 100755 --- a/hack/select-install.sh +++ b/hack/select-install.sh @@ -141,7 +141,7 @@ suite_to_source() { # would also change reverse test selection. suite_runtime_sources() { case "$1" in - clickhouse|etcd|kafka|kafka-metadata|mariadb|mongodb|postgres|rabbitmq|redis|valkey) + clickhouse|etcd|kafka|kafka-metadata|mariadb|mongodb|postgres|rabbitmq|redis|valkey|vminstance) echo cozystack.backupstrategy-controller ;; gateway) echo cozystack.kubeovn-webhook ;; esac diff --git a/hack/select-install_test.bats b/hack/select-install_test.bats index 3d741a584..462abb60a 100644 --- a/hack/select-install_test.bats +++ b/hack/select-install_test.bats @@ -177,7 +177,7 @@ assert_output_graph_error() { } @test "backup suites keep the APIs used by their roundtrip examples" { - for suite in clickhouse etcd kafka kafka-metadata mariadb mongodb postgres rabbitmq redis valkey; do + for suite in clickhouse etcd kafka kafka-metadata mariadb mongodb postgres rabbitmq redis valkey vminstance; do keep=$(hack/select-install.sh "$suite") drop=$(hack/select-install.sh --disabled "$suite") for required in cozystack.backupstrategy-controller cozystack.backup-controller \