From 23d751601349eb80794c315a8912d152130fcef3 Mon Sep 17 00:00:00 2001 From: IvanHunters Date: Wed, 22 Jul 2026 22:25:24 +0300 Subject: [PATCH] docs(talos-log-collector): correct global.target description and note kmsg time global.target is not platform-injected for this optional package (the bundle emits a Package CR with no component values), it comes from the chart default tenant-root; reword the misleading "platform-injected" description. Also note that kernel (kmsg) records carry no wall-clock timestamp, so VictoriaLogs uses the ingest time rather than talos-time for them. Signed-off-by: IvanHunters --- packages/system/talos-log-collector/README.md | 12 ++++++++---- .../system/talos-log-collector/values.schema.json | 4 ++-- packages/system/talos-log-collector/values.yaml | 6 +++--- 3 files changed, 13 insertions(+), 9 deletions(-) diff --git a/packages/system/talos-log-collector/README.md b/packages/system/talos-log-collector/README.md index 81478dde7..4a93ff7f7 100644 --- a/packages/system/talos-log-collector/README.md +++ b/packages/system/talos-log-collector/README.md @@ -55,6 +55,10 @@ url: "tcp://127.0.0.1:5170/" > Omitting the `KmsgLogConfig` document collects service logs only; kernel > (kmsg) logs, including the DRBD messages, will silently never arrive. +> Kernel (kmsg) records carry no wall-clock timestamp (only a monotonic +> clock), so VictoriaLogs stamps them with the ingest time rather than the +> `talos-time` used for service logs. + > Early-boot kernel panics, before the network is up, are not captured by any > in-cluster collector. Use the node BMC serial console for those. @@ -89,8 +93,8 @@ url: "tcp://127.0.0.1:5170/" ### VictoriaLogs destination -| Name | Description | Type | Value | -| --------------- | ---------------------------------------------------------------------------- | -------- | ------------- | -| `global` | Platform-injected global values. | `object` | `{}` | -| `global.target` | Tenant whose VictoriaLogs (vlinsert-generic..svc) receives the logs. | `string` | `tenant-root` | +| Name | Description | Type | Value | +| --------------- | --------------------------------------------------------------------------------------------------------------------------------- | -------- | ------------- | +| `global` | Global values block; `target` selects the destination tenant. | `object` | `{}` | +| `global.target` | Tenant whose VictoriaLogs (vlinsert-generic..svc) receives the logs. Defaults to tenant-root; override via bundle values. | `string` | `tenant-root` | diff --git a/packages/system/talos-log-collector/values.schema.json b/packages/system/talos-log-collector/values.schema.json index 7ca6e513b..cbb9cd826 100644 --- a/packages/system/talos-log-collector/values.schema.json +++ b/packages/system/talos-log-collector/values.schema.json @@ -79,12 +79,12 @@ } }, "global": { - "description": "Platform-injected global values.", + "description": "Global values block; `target` selects the destination tenant.", "type": "object", "default": {}, "properties": { "target": { - "description": "Tenant whose VictoriaLogs (vlinsert-generic.\u003ctarget\u003e.svc) receives the logs.", + "description": "Tenant whose VictoriaLogs (vlinsert-generic.\u003ctarget\u003e.svc) receives the logs. Defaults to tenant-root; override via bundle values.", "type": "string", "default": "tenant-root" } diff --git a/packages/system/talos-log-collector/values.yaml b/packages/system/talos-log-collector/values.yaml index f1c369801..e313b3988 100644 --- a/packages/system/talos-log-collector/values.yaml +++ b/packages/system/talos-log-collector/values.yaml @@ -41,9 +41,9 @@ resources: ## @section VictoriaLogs destination ## -## @typedef {struct} Global - Platform-injected global values. -## @field {string} [target] - Tenant whose VictoriaLogs (vlinsert-generic..svc) receives the logs. +## @typedef {struct} Global - Global values block; `target` selects the destination tenant. +## @field {string} [target] - Tenant whose VictoriaLogs (vlinsert-generic..svc) receives the logs. Defaults to tenant-root; override via bundle values. -## @param {Global} [global] - Platform-injected global values. +## @param {Global} [global] - Global values block; `target` selects the destination tenant. global: target: tenant-root