From 90eb5c6815b3eda9dd4fa2c394d4dd1620499aca Mon Sep 17 00:00:00 2001
From: Aleksei Sviridkin <f@lex.la>
Date: Sun, 19 Jul 2026 09:55:41 +0300
Subject: [PATCH] test(mongodb): make the cert-manager exclusion suite
 discriminate
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Every assertion in the suite passed while checking nothing. containsDocument
without `any: true` asserts that EVERY rendered document matches, so negating
it asks whether "not every document is a Certificate" — true of any chart
rendering more than one object, and this one renders eight. A cert-manager
Certificate appended to templates/mongodb.yaml, the most plausible place for
one to appear, left the suite fully green.

Add `any: true` to each containsDocument so the negation means "no document
anywhere is of this kind". Unscoped assertions are ANDed across template
files, which is what makes the negatives correct: they go red if any file
renders the forbidden kind.

Add a positive control asserting the chart does render the PerconaServerMongoDB
CR through the same matcher shape, scoped to the one template that emits it.
The four negatives are all satisfied by a matcher that never matches, which is
exactly how this suite failed; the control fails if that returns.

Verified by injecting a Certificate into the chart: the suite now fails and
previously passed.

Assisted-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
---
 .../tests/no-certmanager-objects_test.yaml    | 33 +++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/packages/apps/mongodb/tests/no-certmanager-objects_test.yaml b/packages/apps/mongodb/tests/no-certmanager-objects_test.yaml
index 000300d0c..9d6c50213 100644
--- a/packages/apps/mongodb/tests/no-certmanager-objects_test.yaml
+++ b/packages/apps/mongodb/tests/no-certmanager-objects_test.yaml
@@ -9,6 +9,14 @@ suite: chart renders no cert-manager objects
 #
 # Deliberately NOT scoped with `templates:` — the point is to see every
 # document the chart produces, not one file.
+#
+# `any: true` is REQUIRED on every containsDocument below, and its absence is
+# not a style difference. Without it the matcher asserts that EVERY rendered
+# document matches, so negating it yields "not every document is a
+# Certificate" — true of any chart rendering more than one object, and this
+# one renders eight, which makes all four negatives below pass unconditionally.
+# The vacuity control is the guard against that: it fails if the negated form
+# ever stops discriminating.
 
 release:
   name: mg-test
@@ -19,12 +27,33 @@ set:
     cluster-domain: cozy.local
 
 tests:
+  # Positive control for the four negatives that follow. All of them are
+  # satisfied by a matcher that never matches anything, so they are only worth
+  # as much as the proof that this one does. Asserting a kind the chart
+  # certainly DOES render, through the same matcher shape and the same
+  # `any: true`, supplies it.
+  #
+  # Scoped to the one template that renders the CR, unlike the negatives. An
+  # unscoped assertion is ANDed across template files, so a positive one would
+  # demand the CR appear in backup-secret.yaml and credentials.yaml too and
+  # fail for the wrong reason. That same ANDing is what makes the unscoped
+  # negatives correct: they go red if ANY file renders the forbidden kind.
+  - it: the containsDocument matcher discriminates
+    templates:
+      - templates/mongodb.yaml
+    asserts:
+      - containsDocument:
+          kind: PerconaServerMongoDB
+          apiVersion: psmdb.percona.com/v1
+          any: true
+
   - it: renders no cert-manager Certificate
     asserts:
       - not: true
         containsDocument:
           kind: Certificate
           apiVersion: cert-manager.io/v1
+          any: true
 
   - it: renders no cert-manager Issuer
     asserts:
@@ -32,6 +61,7 @@ tests:
         containsDocument:
           kind: Issuer
           apiVersion: cert-manager.io/v1
+          any: true
 
   - it: renders no cert-manager objects with external access enabled
     set:
@@ -43,10 +73,12 @@ tests:
         containsDocument:
           kind: Certificate
           apiVersion: cert-manager.io/v1
+          any: true
       - not: true
         containsDocument:
           kind: Issuer
           apiVersion: cert-manager.io/v1
+          any: true
 
   - it: renders no cert-manager ClusterIssuer
     asserts:
@@ -54,3 +86,4 @@ tests:
         containsDocument:
           kind: ClusterIssuer
           apiVersion: cert-manager.io/v1
+          any: true