From f6b30e2928833bc7f736acfac733d0301b4d4a1a Mon Sep 17 00:00:00 2001 From: Myasnikov Daniil Date: Wed, 12 Aug 2026 19:31:55 +0500 Subject: [PATCH] test(monitoring): pin the oidc values passthrough to the inner chart The wrapper hands the whole of .Values to the inner chart verbatim, so that one line is the only path by which a tenant-set spec.oidc reaches the chart which renders it. Nothing pinned that hop: the inner chart's own suite sets its values directly, so a wrapper that dropped or renamed a key would still render a correct inner chart -- from values no tenant can actually set. Verified by mutation: replacing the passthrough with `omit .Values "oidc"` fails exactly this case's three assertions and leaves the other three cases in the file green. This is the one item from the deleted monitoring OIDC bats that live coverage was genuinely carrying and unit coverage was not, and it costs no cluster. Signed-off-by: Myasnikov Daniil --- .../monitoring/tests/helmrelease_test.yaml | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/packages/extra/monitoring/tests/helmrelease_test.yaml b/packages/extra/monitoring/tests/helmrelease_test.yaml index f5d14b0c0..8a0f0cc43 100644 --- a/packages/extra/monitoring/tests/helmrelease_test.yaml +++ b/packages/extra/monitoring/tests/helmrelease_test.yaml @@ -25,6 +25,28 @@ tests: path: spec.waitStrategy.name value: poller + # The wrapper hands the whole of .Values to the inner chart verbatim, so this is + # the only path by which a tenant-set field such as spec.oidc reaches the chart + # that renders it. Nothing else pinned that hop: packages/system/monitoring's own + # suite sets its values directly, so a wrapper that dropped or renamed a key + # would still render a correct inner chart — from values no tenant can set. + - it: passes tenant-set oidc values through to the inner chart + set: + oidc.mode: System + oidc.users: + - email: alice@example.com + role: Admin + asserts: + - equal: + path: spec.values.oidc.mode + value: System + - equal: + path: spec.values.oidc.users[0].email + value: alice@example.com + - equal: + path: spec.values.oidc.users[0].role + value: Admin + - it: gates readiness on the VLCluster status.updateStatus asserts: - equal: