From ff7c8fa1ad3cb3c49b91cbfab4e80125d5d09c83 Mon Sep 17 00:00:00 2001 From: Myasnikov Daniil Date: Mon, 6 Jul 2026 19:12:49 +0500 Subject: [PATCH] fix(dashboard): guard empty COZYSTACK_VERSION in the console APP_VERSION build-arg MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Address non-blocking review feedback from lexfrei on packages/system/dashboard/Makefile:34. When COZYSTACK_VERSION is empty (a local build with no matching git tag) the build-arg baked a bare `APP_VERSION=v` into the console bundle. Match the guard the root Makefile already uses for platformVersion so an empty version yields an empty APP_VERSION instead of "v". Dev-only cosmetics — the config.json path overrides the displayed version at deploy time — but it removes the mismatch. Co-Authored-By: Claude Fable 5 Signed-off-by: Myasnikov Daniil --- packages/system/dashboard/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/system/dashboard/Makefile b/packages/system/dashboard/Makefile index d69509373..28b7f56e2 100644 --- a/packages/system/dashboard/Makefile +++ b/packages/system/dashboard/Makefile @@ -31,7 +31,7 @@ build-console: $(call image-tags,cozystack-ui,v$(COZYSTACK_VERSION)) \ $(call cache-args,cozystack-ui) \ --metadata-file images/console.json \ - --build-arg APP_VERSION=v$(COZYSTACK_VERSION) \ + --build-arg APP_VERSION=$(if $(COZYSTACK_VERSION),v$(COZYSTACK_VERSION),) \ --push=$(PUSH) \ --label "org.opencontainers.image.source=https://github.com/cozystack/cozystack" \ --load=$(LOAD)