Commit Graph
3 Commits
Author SHA1 Message Date
Aleksei Sviridkin 05818aa3b2 fix(cli): fail cozypkg and check-readiness on unwritable output
For the commands this change touches (cozypkg list, the validation
report of validate, push and tap, tap's summary, and check-readiness),
a write error the process observes is a failure: the command exits
non-zero and says whether the action it reports on already happened.
Progress lines printed before the decisive step stay best-effort. A
closed pipe ends the process with SIGPIPE, as for other Unix tools.

`cozypkg list` and the validation report dropped write errors, and the
list deferred its tabwriter flush, so a closed or full stdout still
reported success with nothing printed. The list now writes to the
command's writer and returns the flush error, and the report returns
its write error. When validation refuses a push or a tap, or fails a
validate run, the refusal stays the reported reason and the report's
write error is joined to it. A push whose report cannot be written
stops before flux runs and says "nothing was pushed"; a tap whose
summary cannot be written fails with "tap applied, but writing its
summary failed".

check-readiness fails --help, --version and its readiness result the
same way, in one-shot, --wait and --watch mode, with exit 1 as for a
result that is not ready, which its help now lists among the exit
statuses along with SIGPIPE for a closed pipe; the watch loop stops at
the first frame it cannot write, and a timed-out wait still ends with
its verdict.

push writes its "Pushing" line before it runs flux and stops with
"nothing was pushed" when that line cannot be written, with validation
skipped or after the report.

Assisted-by: LLM
Signed-off-by: Aleksei Sviridkin <f@lex.la>
2026-11-13 12:34:56 +03:00
Aleksei Sviridkin 7a0aab2bdc refactor: apply the Go 1.27 modernizers
Run go fix over every first-party module: interface{} becomes any,
hand-written loops become slices, maps, min/max and range-over-int,
errors.As becomes errors.AsType, pointer helpers become new(expr) and
are inlined at their call sites, and so on. Every rewrite keeps
behaviour.

Three rewrites stay out. embedlit flattens embedded-field literals
such as ObjectMeta, syntax only Go 1.27 accepts, which would break
backports to release branches still on Go 1.26. omitzero drops
omitempty from struct fields, and openapi-gen reads omitempty as
optional, so metadata, spec and status would turn required in the
published schemas. And errorsastype rewrote an errors.As whose
target, apierrors.APIStatus, does not implement error, which
errors.AsType rejects at compile time.

Assisted-by: LLM
Signed-off-by: Aleksei Sviridkin <f@lex.la>
2026-09-24 17:23:18 +03:00
Myasnikov Daniil f85ec76e19 feat(hack): rewrite check-readiness as a Go command with test suite
Replace hack/check-readiness.sh with a Go command at cmd/check-readiness,
wired into the build like cozypkg (`make check-readiness`, Version via
-ldflags). The tool shells out to kubectl and reports only non-ready
cozystack / Flux / Kubernetes resources parsed from status conditions,
supporting --wait/--timeout, --watch, --core, --parallel, --verbose,
-n/-l scoping, --no-color and --version.

Add a black-box golden test suite under test/check-readiness driven by a
mock kubectl over fixtures; `make test-check-readiness` runs it and it is
wired into `make unit-tests`.

Supersedes #2740, which added the same feature set to the bash script.

Assisted-By: Claude <noreply@anthropic.com>
Signed-off-by: Myasnikov Daniil <myasnikovdaniil2001@gmail.com>
2026-05-27 01:49:49 +05:00