mirror of
https://github.com/cozystack/cozystack.git
synced 2026-10-28 15:47:33 +09:00
Block accidental DELETE on critical platform objects (tenant-root, cozy-system, LinstorCluster, CRDs, ClusterIssuers, cozystack-version ConfigMap, cozystack-packages OCIRepository, tenant-root HelmRelease) via a label-scoped ValidatingAdmissionPolicy. No webhook DaemonSet, Service, TLS, or image — the API server evaluates the CEL expression in-process. Requires Kubernetes 1.30+. Bypass for legitimate deletes is two steps: kubectl label <kind> <name> platform.cozystack.io/no-delete- kubectl delete <kind> <name> CRDs installed dynamically by the operator get the label stamped in internal/crdinstall/install.go before the apply call. Release note: Added deletion-protection guardrail (ValidatingAdmissionPolicy) blocking DELETE on cozystack platform objects labeled platform.cozystack.io/no-delete=true. Bypass by removing the label first. Assisted-By: Claude <noreply@anthropic.com> Signed-off-by: Myasnikov Daniil <myasnikovdaniil2001@gmail.com>
124 lines
3.9 KiB
Go
124 lines
3.9 KiB
Go
/*
|
|
Copyright 2025 The Cozystack Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package crdinstall
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
|
|
"github.com/cozystack/cozystack/internal/manifestutil"
|
|
|
|
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
|
|
"sigs.k8s.io/controller-runtime/pkg/client"
|
|
"sigs.k8s.io/controller-runtime/pkg/log"
|
|
)
|
|
|
|
// Install applies Cozystack CRDs using embedded manifests.
|
|
// It extracts the manifests and applies them to the cluster using server-side apply,
|
|
// then waits for all CRDs to have the Established condition.
|
|
func Install(ctx context.Context, k8sClient client.Client, writeEmbeddedManifests func(string) error) error {
|
|
logger := log.FromContext(ctx)
|
|
|
|
tmpDir, err := os.MkdirTemp("", "crd-install-*")
|
|
if err != nil {
|
|
return fmt.Errorf("failed to create temp directory: %w", err)
|
|
}
|
|
defer os.RemoveAll(tmpDir)
|
|
|
|
manifestsDir := filepath.Join(tmpDir, "manifests")
|
|
if err := os.MkdirAll(manifestsDir, 0755); err != nil {
|
|
return fmt.Errorf("failed to create manifests directory: %w", err)
|
|
}
|
|
|
|
if err := writeEmbeddedManifests(manifestsDir); err != nil {
|
|
return fmt.Errorf("failed to extract embedded manifests: %w", err)
|
|
}
|
|
|
|
entries, err := os.ReadDir(manifestsDir)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to read manifests directory: %w", err)
|
|
}
|
|
|
|
var manifestFiles []string
|
|
for _, entry := range entries {
|
|
if strings.HasSuffix(entry.Name(), ".yaml") {
|
|
manifestFiles = append(manifestFiles, filepath.Join(manifestsDir, entry.Name()))
|
|
}
|
|
}
|
|
|
|
if len(manifestFiles) == 0 {
|
|
return fmt.Errorf("no YAML manifest files found in directory")
|
|
}
|
|
|
|
var objects []*unstructured.Unstructured
|
|
for _, manifestPath := range manifestFiles {
|
|
objs, err := manifestutil.ParseManifestFile(manifestPath)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to parse manifests from %s: %w", manifestPath, err)
|
|
}
|
|
objects = append(objects, objs...)
|
|
}
|
|
|
|
if len(objects) == 0 {
|
|
return fmt.Errorf("no objects found in manifests")
|
|
}
|
|
|
|
// Validate all objects are CRDs — reject anything else to prevent
|
|
// accidental force-apply of arbitrary resources.
|
|
for _, obj := range objects {
|
|
if obj.GetAPIVersion() != "apiextensions.k8s.io/v1" || obj.GetKind() != "CustomResourceDefinition" {
|
|
return fmt.Errorf("unexpected object %s %s/%s in CRD manifests, only apiextensions.k8s.io/v1 CustomResourceDefinition is allowed",
|
|
obj.GetAPIVersion(), obj.GetKind(), obj.GetName())
|
|
}
|
|
}
|
|
|
|
// Stamp the deletion-protection label so the platform VAP guards every
|
|
// Cozystack CRD against accidental kubectl delete.
|
|
for _, obj := range objects {
|
|
labels := obj.GetLabels()
|
|
if labels == nil {
|
|
labels = make(map[string]string)
|
|
}
|
|
labels["platform.cozystack.io/no-delete"] = "true"
|
|
obj.SetLabels(labels)
|
|
}
|
|
|
|
logger.Info("Applying Cozystack CRDs", "count", len(objects))
|
|
for _, obj := range objects {
|
|
patchOptions := &client.PatchOptions{
|
|
FieldManager: "cozystack-operator",
|
|
Force: func() *bool { b := true; return &b }(),
|
|
}
|
|
|
|
if err := k8sClient.Patch(ctx, obj, client.Apply, patchOptions); err != nil {
|
|
return fmt.Errorf("failed to apply CRD %s: %w", obj.GetName(), err)
|
|
}
|
|
logger.Info("Applied CRD", "name", obj.GetName())
|
|
}
|
|
|
|
crdNames := manifestutil.CollectCRDNames(objects)
|
|
if err := manifestutil.WaitForCRDsEstablished(ctx, k8sClient, crdNames); err != nil {
|
|
return fmt.Errorf("CRDs not established after apply: %w", err)
|
|
}
|
|
|
|
logger.Info("CRD installation completed successfully")
|
|
return nil
|
|
}
|