mirror of
https://github.com/cozystack/cozystack.git
synced 2026-10-29 08:07:33 +09:00
Aleksei Sviridkin
eedd08f6fc
The dashboard Role handed the tenant the release's leaf Secret whenever tls.authClients was yes, on the reasoning that a client needing to authenticate can reuse the server identity as its own. That Secret holds tls.key, so any subject at the tenant's use level could read the private key of the certificate Redis and Sentinel present and impersonate those endpoints to every client that trusts the release CA. Withhold it. The tenant keeps read access to the CA-only Secret, which is what verifying the server actually requires and which carries no private key at all. This leaves authClients=optional and =yes without a client certificate a tenant can obtain, since the CA private key needed to sign one is also withheld by design. Document that limitation in README.md rather than paper over it: in-cluster components are unaffected because the operator mounts the leaf for them, but an external client has no supported path to a certificate this CA accepts, so those two values are only usable when the certificate is supplied out of band. Also correct the neighbouring comment, which described the per-release CA as trusted by the whole cluster. It is self-signed and scoped to one release, and nothing outside that release trusts it. Add the test target the package was missing. The TLS suite added with this feature sat in tests/ with no way to invoke it, so CI had never run any of it; the assertions covering this Role were passing only in principle. All 24 now run, including the two that pin the leaf Secret as withheld at both authClients values. The authClients sentence also says to quote the value: an unquoted yes or no in a manifest is read as a boolean and the string field rejects it. Assisted-By: Claude <noreply@anthropic.com> Signed-off-by: Aleksei Sviridkin <f@lex.la>
14 lines
281 B
Makefile
14 lines
281 B
Makefile
include ../../../hack/package.mk
|
|
|
|
.PHONY: test
|
|
test:
|
|
helm unittest .
|
|
|
|
generate:
|
|
cozyvalues-gen -m 'redis' -v values.yaml -s values.schema.json -r README.md -g ../../../api/apps/v1alpha1/redis/types.go
|
|
../../../hack/update-crd.sh
|
|
|
|
update:
|
|
hack/update-versions.sh
|
|
make generate
|