The lane is advisory, and an advisory check that is red for a reason
everyone already knows trains reviewers to ignore it — then it stops
working on the day it finds something new. It currently has exactly one
such reason: tenant-test/vm-instance-test does not return to Ready across
an upgrade (#3984), while the same workload passes on a fresh install in
the very same run.
Give the lane a ledger rather than a longer timeout or a suite exclusion.
hack/e2e-wait-hr-ready.sh learns an optional EXPECTED_NOT_READY_FILE, and
only hack/e2e-upgrade-apply.bats sets it; unset, the script behaves as it
always did, down to making no second listing call on the happy path, so
the install gate is untouched.
The entries have to expire on their own or the file becomes the thing it
was meant to prevent, a stale explanation outliving its defect. Three
rules do that, all failures rather than warnings:
- a not-Ready release that is NOT listed still fails the gate;
- a listed release that is Ready again fails until its line is deleted;
- a line naming no release in the cluster fails too.
So the fastest way to remove a line is to fix the defect, and the file
cannot be wrong about the present without saying so. A named file that
cannot be read is also a failure: treating it as "nothing expected" would
turn a typo into a gate that quietly accepts more than it claims.
hack/wait-hr-ready_test.bats drives the real script through a kubectl stub
over all of it. It is deliberately not named hack/e2e-*.bats: the unit
target is $(filter-out hack/e2e-%.bats,...), so a file named after the
script it tests would be excluded from the suite and never run.
Verified non-vacuous by mutation — disabling each of the three rules in
turn turns exactly one case red, and the missing-file refusal likewise.
Assisted-By: Claude <noreply@anthropic.com>
Signed-off-by: Myasnikov Daniil <myasnikovdaniil2001@gmail.com>
Myasnikov Daniil
c7dca5f1da