mirror of
https://github.com/cozystack/cozystack.git
synced 2026-11-04 02:57:27 +09:00
Myasnikov Daniil
9a71dc1427
Sweep across `hack/*.bats` and `hack/*.sh` replacing fragile `sleep N` / `timeout N until …; do sleep …; done` patterns with `kubectl wait --for=condition=…` plus a small existence backstop: until kubectl get <resource> >/dev/null 2>&1; do sleep 2; done kubectl wait <resource> --for=condition=Ready --timeout=… Existence backstop added to 33 `kubectl wait` sites across 12 bats files (redis, kafka, openbao, harbor, mongodb, qdrant, vminstance, clickhouse, mariadb, postgres, bucket, install). Without it, `kubectl wait` against a not-yet-created resource sits silently for the full timeout; with it, the test fails fast with a clear "resource never appeared" error. OpenAPI tests' fixed `sleep 5` after starting `kubectl proxy` is now a port-readiness wait. The 3 remaining genuine sleeps (LINSTOR node membership propagation, MetalLB end-to-end HTTP path, HR-count emission heuristic) are annotated with TODO + rationale so a future reader knows they are intentional. Same green-path semantics; failures now surface in seconds instead of after a 5-minute timeout. Signed-off-by: Myasnikov Daniil <myasnikovdaniil2001@gmail.com> Assisted-By: Claude <noreply@anthropic.com>
82 lines
3.7 KiB
Bash
82 lines
3.7 KiB
Bash
#!/usr/bin/env bats
|
|
|
|
@test "Create Harbor" {
|
|
name='test'
|
|
release="harbor-$name"
|
|
|
|
# Clean up stale resources from previous failed runs
|
|
kubectl -n tenant-test delete harbor.apps.cozystack.io $name 2>/dev/null || true
|
|
kubectl -n tenant-test wait hr $release --timeout=60s --for=delete 2>/dev/null || true
|
|
|
|
kubectl apply -f- <<EOF
|
|
apiVersion: apps.cozystack.io/v1alpha1
|
|
kind: Harbor
|
|
metadata:
|
|
name: $name
|
|
namespace: tenant-test
|
|
spec:
|
|
host: ""
|
|
storageClass: ""
|
|
core:
|
|
resources: {}
|
|
resourcesPreset: "nano"
|
|
registry:
|
|
resources: {}
|
|
resourcesPreset: "nano"
|
|
jobservice:
|
|
resources: {}
|
|
resourcesPreset: "nano"
|
|
trivy:
|
|
enabled: false
|
|
size: 2Gi
|
|
resources: {}
|
|
resourcesPreset: "nano"
|
|
database:
|
|
size: 2Gi
|
|
replicas: 1
|
|
redis:
|
|
size: 1Gi
|
|
replicas: 1
|
|
EOF
|
|
# Wait for the operator to materialise the HelmRelease before kubectl wait
|
|
# kicks in (kubectl wait errors immediately if the object does not exist yet).
|
|
timeout 60 sh -ec "until kubectl -n tenant-test get hr $release >/dev/null 2>&1; do sleep 2; done"
|
|
kubectl -n tenant-test wait hr $release --timeout=60s --for=condition=ready
|
|
|
|
# Wait for COSI to provision bucket
|
|
timeout 60 sh -ec "until kubectl -n tenant-test get bucketclaims.objectstorage.k8s.io $release-registry >/dev/null 2>&1; do sleep 2; done"
|
|
kubectl -n tenant-test wait bucketclaims.objectstorage.k8s.io $release-registry \
|
|
--timeout=300s --for=jsonpath='{.status.bucketReady}'=true
|
|
timeout 60 sh -ec "until kubectl -n tenant-test get bucketaccesses.objectstorage.k8s.io $release-registry >/dev/null 2>&1; do sleep 2; done"
|
|
kubectl -n tenant-test wait bucketaccesses.objectstorage.k8s.io $release-registry \
|
|
--timeout=60s --for=jsonpath='{.status.accessGranted}'=true
|
|
|
|
kubectl -n tenant-test wait hr $release-system --timeout=600s --for=condition=ready || {
|
|
echo "=== HelmRelease status ==="
|
|
kubectl -n tenant-test get hr $release-system -o yaml 2>&1 || true
|
|
echo "=== Pods ==="
|
|
kubectl -n tenant-test get pods 2>&1 || true
|
|
echo "=== Events ==="
|
|
kubectl -n tenant-test get events --sort-by='.lastTimestamp' 2>&1 | tail -30 || true
|
|
echo "=== ExternalArtifact ==="
|
|
kubectl -n cozy-system get externalartifact cozystack-harbor-application-default-harbor-system -o yaml 2>&1 || true
|
|
echo "=== BucketClaim status ==="
|
|
kubectl -n tenant-test get bucketclaims.objectstorage.k8s.io $release-registry -o yaml 2>&1 || true
|
|
echo "=== BucketAccess status ==="
|
|
kubectl -n tenant-test get bucketaccesses.objectstorage.k8s.io $release-registry -o yaml 2>&1 || true
|
|
echo "=== BucketAccess Secret ==="
|
|
kubectl -n tenant-test get secret $release-registry-bucket -o jsonpath='{.data.BucketInfo}' 2>&1 | base64 -d 2>&1 || true
|
|
false
|
|
}
|
|
timeout 60 sh -ec "until kubectl -n tenant-test get deploy $release-core >/dev/null 2>&1; do sleep 2; done"
|
|
kubectl -n tenant-test wait deploy $release-core --timeout=120s --for=condition=available
|
|
timeout 60 sh -ec "until kubectl -n tenant-test get deploy $release-registry >/dev/null 2>&1; do sleep 2; done"
|
|
kubectl -n tenant-test wait deploy $release-registry --timeout=120s --for=condition=available
|
|
timeout 60 sh -ec "until kubectl -n tenant-test get deploy $release-portal >/dev/null 2>&1; do sleep 2; done"
|
|
kubectl -n tenant-test wait deploy $release-portal --timeout=120s --for=condition=available
|
|
kubectl -n tenant-test get secret $release-credentials -o jsonpath='{.data.admin-password}' | base64 --decode | grep -q '.'
|
|
kubectl -n tenant-test get secret $release-credentials -o jsonpath='{.data.url}' | base64 --decode | grep -q 'https://'
|
|
kubectl -n tenant-test get svc $release -o jsonpath='{.spec.ports[0].port}' | grep -q '80'
|
|
kubectl -n tenant-test delete harbor.apps.cozystack.io $name
|
|
}
|