Files
cozystack/hack
Aleksei Sviridkin 5a5d5cd3d8 fix(tests): reject matcher failures in negative file assertions (#5175)
<!-- Thank you for making a contribution! Here are some tips for you:
- Use Conventional Commits for the PR title: `type(scope): description`
- Types: feat, fix, docs, style, refactor, perf, test, build, ci, chore
- Scopes are not an exhaustive list — pick the most specific scope for
the change and extend the list when a genuinely new area appears.
Examples:
- System components: dashboard, platform, operator, cilium, kube-ovn,
linstor, fluxcd, cluster-api
- Managed apps: postgres, mariadb, redis, kafka, clickhouse,
virtual-machine, kubernetes
- Development and maintenance: api, hack, tests, ci, docs, maintenance
- Breaking changes: append `!` after type/scope (`feat(api)!: ...`) or
add a `BREAKING CHANGE:` footer
- If it's a work in progress, consider creating this PR as a draft.
- Don't hesistate to ask for opinion and review in the community chats,
even if it's still a draft.
- Add the label `kind/backport` if it's a bugfix that needs to be
backported to a previous version.
-->

## What this PR does

Fixes #3700.

Negative file assertions must not pass when the matcher fails or an
artifact is missing. Share `assert_file_lacks_pattern` through the
existing Bats helper, preserving all call sites while removing the 12
divergent copies. The shared implementation accepts absence only when
awk evaluates successfully and explicitly reports no match. It reports
read/evaluation failures regardless of their exit status and validates
the regex even when the artifact is empty.

Regression tests run the assertion under `bash -eu` and cover matching
and non-matching patterns, empty files, invalid regexes, missing paths,
directories, and unreadable files. The tests reproduce false positives
against the previous helper implementations, including a matcher that
prints a no-match result but exits with an error. The test suite
resolves its helper relative to its own directory and also runs outside
the repository root.

### Validation

- Bats 1.14.0: all 471 tests in the regression file and 12 affected
consumer suites pass, with no skips.
- All 462 tests in the 12 affected consumer suites pass under the dash
POSIX compatibility runner.
- All nine helper tests pass from both the repository root and `/tmp`;
independent verification also passes all nine with BusyBox awk v1.35.0.
The previous helper falsely accepts invalid patterns and unreadable
files with that implementation.
- `bash -n hack/test_helper.bash` and `git diff --check` pass.
- An earlier full Bats run executed all 2,491 tests: 2,426 passed and 65
failed. Of these, 56 require Docker and three require `envsubst`,
neither of which is installed in this environment. The remaining six
selector failures also reproduce on the unchanged baseline with the
older local yq; rerunning both selector suites with the CI-pinned,
checksum-verified yq v4.53.3 passes all 110 tests. The full-tree suite
has not been rerun for this corrective revision; its focused checks are
listed above.

### Screenshots

<!-- REQUIRED for UI changes: attach screenshots or screen recordings
demonstrating
the visual impact of your changes. PRs with UI changes without
screenshots will not be merged. -->

### Downstream repositories

<!--
Cozystack is upstream for repositories that are NOT kept in sync with it
automatically, and nothing in CI compares the two sides, so a change
here can break them silently.

Which change forces what, and which file to touch, is the trigger map in
docs/agents/contributing.md under "Downstream Repositories". Walk it
before you tick anything.

IF YOU ARE AN AI AGENT OR AN LLM, THIS IS PART OF THE TASK, NOT A FORM
TO FILL IN:

1. Walk the trigger map against the actual diff of this PR, file by
file. Do not decide from the PR title or from your memory of what you
changed.
2. For every repository you tick, open the follow-up PR there and link
it on the same line. A ticked box with no link claims work that does not
exist, which is worse than an empty box. Search that repository for an
open PR or issue covering it first, and link that instead of filing a
duplicate.
3. When the follow-up is out of scope, or needs a decision that is not
yours to make, open an issue in that repository instead, link that, and
say so in the PR body. Do not push a speculative PR into another
repository just to fill a line here.
4. Do not tick "No downstream repository is affected" to make the
checklist go away. If you are unsure, leave every box empty and say so
in the PR body, so a human decides.
-->

- [x] No downstream repository is affected by this change
- [ ] [cozystack/website](https://github.com/cozystack/website) -
follow-up:
- [ ]
[cozystack/terraform-provider-cozystack](https://github.com/cozystack/terraform-provider-cozystack)
- follow-up:
- [ ]
[cozystack/ansible-cozystack](https://github.com/cozystack/ansible-cozystack)
- follow-up:
- [ ] [cozystack/ccp](https://github.com/cozystack/ccp) - follow-up:
- [ ] [cozystack/talm](https://github.com/cozystack/talm) - follow-up:
- [ ] [cozystack/cozyhr](https://github.com/cozystack/cozyhr) -
follow-up:
- [ ] [cozystack/cozy-proxy](https://github.com/cozystack/cozy-proxy) -
follow-up:
- [ ]
[cozystack/cozystack-telemetry-server](https://github.com/cozystack/cozystack-telemetry-server)
- follow-up:
- [ ]
[cozystack/external-apps-example](https://github.com/cozystack/external-apps-example)
- follow-up:
- [ ] [cozystack/examples](https://github.com/cozystack/examples) -
follow-up:
- [ ] [cozystack/community](https://github.com/cozystack/community) -
follow-up:

### Release note

<!--  Write a release note:
- Explain what has changed internally and for users.
- Start with the same `type(scope):` prefix as in the PR title
- Follow the guidelines at
https://github.com/kubernetes/community/blob/master/contributors/guide/release-notes.md.
-->

```release-note
fix(tests): fail negative file assertions on invalid patterns or unreadable artifacts and share the helper across Bats suites.
```


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
<!-- coderabbit-ai-generated:v1 -->

## Summary by CodeRabbit

* **Tests**
* Consolidated checks for verifying that files do not contain specified
patterns.
* Expanded coverage to verify behavior for matching and non-matching
patterns, invalid patterns, missing paths, directories, inaccessible
files, and pattern-checking errors.
* Checks now succeed only when the target is a regular file and pattern
evaluation completes successfully without finding a match.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-11-15 06:00:02 +03:00
..