mirror of
https://github.com/cozystack/cozystack.git
synced 2026-11-06 03:57:52 +09:00
Myasnikov Daniil
61bbf86755
resolveOsImage assigns $factoryURL before it branches, and the builtin arm never reassigns it, so the http(s) pattern ran for every pool including one that clones. A builtin pool builds no source URL at all: its DataVolume carries source.pvc and no source.http, and the reconcile Job takes only the schematic and the version. The value was therefore refused on a path that does not consume it. The operator this landed on is the one the feature exists for. Somebody moving to osImage.builtin to stop depending on the Image Factory is exactly the person likely to blank imageFactoryURL, and the render then failed with a message naming a source URL that path never builds. The field is a bare string in values.schema.json and in the cozyrds openAPISchema -- no pattern, no minLength -- so an empty or malformed one reaches the render rather than being rejected at admission. The guard is unchanged for osImage.factory and for the no-osImage default, which are the two arms that interpolate it. Three cases: a builtin pool renders with the field blanked and with it malformed, and the omitted-osImage default still refuses a malformed one, so neither new case can be read as relaxing the arm a running cluster is already on. Forcing the new condition open reddens the two builtin cases; forcing it shut reddens the factory and default ones. Reviewed as [MINOR] on cozystack/cozystack#3294. Assisted-By: LLM Signed-off-by: Myasnikov Daniil <myasnikovdaniil2001@gmail.com>
How to test packages local
cd packages/core/installer
make image-cozystack REGISTRY=YOUR_CUSTOM_REGISTRY
make apply
kubectl delete po -l app=source-controller -n cozy-fluxcd