mirror of
https://github.com/cozystack/cozystack.git
synced 2026-11-22 04:33:36 +09:00
KubeVirt 1.9 deprecates HotplugVolumes in favour of DeclarativeHotplugVolumes, which is Beta and therefore on by default, but virt-controller skips declarative reconciliation for as long as the old gate is on. Keeping it was only needed because kubevirt-csi detached through the VMI-level removevolume, which virt-api accepts on a VM-owned VMI only with the old gate. kubevirt-csi can now skip that call, so its fallback goes off together with the gate. The two live in different HelmReleases and roll out one after the other; in between the driver may issue a VMI-level call virt-api rejects, and the unpublish fails and is retried until both sides agree. The chart now renders --enable-vmi-hotplug-fallback=false, which a kubevirt-csi image built before the flag existed rejects at startup. The driver image is stamped at release preparation, so this needs the rebuilt image that ships in the same release. DeclarativeHotplugVolumes is now listed explicitly. With HotplugVolumes gone it is the only hotplug path, and disabling it through disabledFeatureGates would make virt-api refuse every addvolume, so the chart refuses that render instead. This changes volume hotplug platform-wide. A VM-level addvolume or removevolume now edits VM.spec directly and virt-controller reconciles the VMI hotplug volumes against it, instead of going through VM.status.volumeRequests. On the first reconcile it also removes every hotpluggable VMI volume missing from VM.spec; platform migration 59 copies those into VM.spec beforehand on the variants that run migrations. Assisted-by: LLM Signed-off-by: Aleksei Sviridkin <f@lex.la>
How to test packages local
cd packages/core/installer
make image-cozystack REGISTRY=YOUR_CUSTOM_REGISTRY
make apply
kubectl delete po -l app=source-controller -n cozy-fluxcd