mirror of
https://github.com/cozystack/cozystack.git
synced 2026-11-21 12:13:55 +09:00
## What this PR does Stacked on #5221; review that one first. Once it merges this PR retargets to `main`. After #5221 a Postgres BackupJob writes the shared WAL archive destination only while no other running BackupJob of the application has a `cnpg.io/Backup` in flight. A `cnpg.io/Backup` that no running BackupJob tracks was not counted: one created by hand or by a `ScheduledBackup`, or one whose BackupJob was deleted or had already finished. A BackupJob using another BackupClass could then rewrite the destination while CloudNativePG was running such a Backup, leaving its base backup in one place and the WAL it needs in another, so the backup could not be restored. Such a Backup now holds the destination while CloudNativePG executes it, that is in the `started` and `running` phases (`BackupStatus.IsExecuting` in CloudNativePG 1.30). While a Backup of a Cluster is in one of those phases, CloudNativePG's own `BackupList.CanExecuteBackup` starts no other Backup of that Cluster, so the hold never lasts longer than the queue the operator already imposes and needs no separate deadline. A `pending` Backup does not hold, including one that ran before and was sent back to `pending`: CloudNativePG starts its base backup over against the destination current at that time. These Backups are found by `spec.cluster.name` in the controller's cache, because a Backup created by hand need carry no label. The waiting BackupJob reports `Ready=False` with reason `WaitingForUntrackedBackup` and names the Backup. ### Screenshots Not applicable: no UI change. ### Downstream repositories The diff touches only `internal/backupcontroller`: no CRD, values, chart or naming change, so nothing in the trigger map applies. - [x] No downstream repository is affected by this change - [ ] [cozystack/website](https://github.com/cozystack/website) - follow-up: - [ ] [cozystack/terraform-provider-cozystack](https://github.com/cozystack/terraform-provider-cozystack) - follow-up: - [ ] [cozystack/ansible-cozystack](https://github.com/cozystack/ansible-cozystack) - follow-up: - [ ] [cozystack/ccp](https://github.com/cozystack/ccp) - follow-up: - [ ] [cozystack/talm](https://github.com/cozystack/talm) - follow-up: - [ ] [cozystack/cozyhr](https://github.com/cozystack/cozyhr) - follow-up: - [ ] [cozystack/cozy-proxy](https://github.com/cozystack/cozy-proxy) - follow-up: - [ ] [cozystack/cozystack-telemetry-server](https://github.com/cozystack/cozystack-telemetry-server) - follow-up: - [ ] [cozystack/external-apps-example](https://github.com/cozystack/external-apps-example) - follow-up: - [ ] [cozystack/examples](https://github.com/cozystack/examples) - follow-up: - [ ] [cozystack/community](https://github.com/cozystack/community) - follow-up: ### Release note ```release-note fix(postgres): a Postgres BackupJob no longer rewrites the WAL archive destination while CloudNativePG is running a backup of the same cluster that no BackupJob tracks, such as one created by hand or by a ScheduledBackup; it waits with reason WaitingForUntrackedBackup. ``` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> <!-- coderabbit-ai-generated:v1 --> ## Summary by CodeRabbit * **Bug Fixes** * Prevented shared WAL archive destinations from being written while an untracked backup is actively running. * Pending and finalizing backups no longer hold the destination, and the destination becomes available again after the active backup completes. * Improved handling of backup status and retry conditions when multiple backups are in progress. <!-- end of auto-generated comment: release notes by coderabbit.ai -->