mirror of
https://github.com/cozystack/cozystack.git
synced 2026-11-05 11:37:31 +09:00
Two reliability fixes in `hack/e2e-apps/vminstance.bats`: 1. Delete-recreate race. Both @test blocks deleted the prior VMInstance/VMDisk with `kubectl ... --timeout=2m || true`. The `|| true` silently swallowed timeout errors, letting the test continue with the resource still in finalizer-drain. The next `kubectl apply` then no-ops with "Detected changes to resource ... which is currently being deleted", producing a NotFound on the downstream HR wait. Bumped the delete timeout to 3m and removed `|| true` so true delete failures surface loudly. End-of-test cleanup deletes also got the explicit timeout. 2. VM IP and VM ready timeouts. The 20s timeout for the VMI to acquire an IP was unrealistic for nested KubeVirt under runner load — virt-launcher + libvirt + cloud-init DHCP routinely takes 30-60s. Bumped to 120s with a 2s poll interval (60 polls instead of 4). VM ready timeout bumped from 20s to 60s for the same reason. Both surfaced as recurring first-attempt failures in the past 30 successful PR runs (7/17 analysable runs in each case) — masked by the 3x retry on `Run E2E tests`. Signed-off-by: Myasnikov Daniil <myasnikovdaniil2001@gmail.com>