Second review pass, all four are prose that describes something the code
beside it does not do.
The talos.version description still said the support matrix is evaluated
against that value only and that an image.* override is not checked against
it. That was true when it was written and stopped being true one commit later,
when the matrix moved into a named template and gained its second call site.
cozyvalues-gen had propagated the stale sentence into values.schema.json, the
README, the Go types and the ApplicationDefinition schema, so the operator and
the dashboard both read it.
The guard block claimed an empty lookup makes all of its guards no-ops under
`helm template`. It does for the phase, StorageClass and size guards, which
read fields of a golden that was found. For the absence guard an empty lookup
IS the failure condition, so a builtin pool cannot be rendered by anything with
no cluster to read, and its unit tests have to mock the golden. Worth knowing
before someone runs helm lint against it and files a bug.
The e2e golden wait promised a stall would surface "with the factory in the
message". `kubectl wait` prints only "timed out waiting for the condition on
datavolumes/<name>" on expiry, which names neither the URL nor the importer's
error, so the step reported a stall about as legibly as the node-join timeout
it exists to replace. It now describes the DataVolume and tails the importer
Pod before failing; CDI writes the HTTP error and the source URL into the
Running condition message.
The catalog said a golden's StorageClass must be snapshot-capable. The
platform pins cloneStrategyOverride: csi-clone, which needs no
VolumeSnapshotClass, so that was an over-constraint on a value operators are
told to change.
Assisted-By: LLM
Signed-off-by: Myasnikov Daniil <myasnikovdaniil2001@gmail.com>
Myasnikov Daniil
ea30f79c76