mirror of
https://github.com/cozystack/cozystack.git
synced 2026-11-21 12:13:55 +09:00
## What this PR does The VPA admission controller runs as one replica, and its webhook is registered with `failurePolicy: Ignore`. While that one pod is being rescheduled, every pod created in the cluster is admitted without its VPA recommendation, and with `updateMode: Initial` it keeps those resources until it is recreated. On a v1.6.5 cluster `vmstorage-shortterm-0` was created during a node drain while the admission controller moved to another node. It has no `vpaUpdates` annotation and runs with the vm-operator defaults, requests 250m/500Mi and limits 1/1500Mi, while its VPA recommends 920m and 3.42Gi and the other replica got 5.13Gi through VPA. It was OOMKilled 18 days later. This PR sets `replicaCount: 2`, enables the chart's PodDisruptionBudget with `minAvailable: 1` and spreads the two replicas over nodes with a `ScheduleAnyway` topology spread, so single-node clusters still schedule both. A drain then leaves one controller serving. The controller still deletes and recreates its MutatingWebhookConfiguration on start (`selfRegistration` in `pkg/admission-controller/config.go`, VPA 1.5.1), so a restart leaves only that short gap instead of the whole reschedule. `failurePolicy` stays `Ignore`, a VPA outage should not block pod creation. Two new cases in `tests/vpa_test.yaml` check the replica count, the spread selector against the pod labels and the PDB. `helm unittest .` in `packages/system/vertical-pod-autoscaler` passes 18 of 18 with helm-unittest 1.1.2, and against the values on main the two new cases fail and the other 16 pass. `helm template` renders the Deployment with 2 replicas and the PDB with the admission controller selector. I have not run the change on a live cluster. #4540 is the same trap from the other side, a component that keeps a bad size because Initial never revisits it. ### Screenshots Not a UI change. ### Downstream repositories Values of `packages/system/vertical-pod-autoscaler` and its tests only. No platform values, app schema, default exposed to tenants or package change, so no trigger map entry applies. - [x] No downstream repository is affected by this change - [ ] [cozystack/website](https://github.com/cozystack/website) - follow-up: - [ ] [cozystack/terraform-provider-cozystack](https://github.com/cozystack/terraform-provider-cozystack) - follow-up: - [ ] [cozystack/ansible-cozystack](https://github.com/cozystack/ansible-cozystack) - follow-up: - [ ] [cozystack/ccp](https://github.com/cozystack/ccp) - follow-up: - [ ] [cozystack/talm](https://github.com/cozystack/talm) - follow-up: - [ ] [cozystack/cozyhr](https://github.com/cozystack/cozyhr) - follow-up: - [ ] [cozystack/cozy-proxy](https://github.com/cozystack/cozy-proxy) - follow-up: - [ ] [cozystack/cozystack-telemetry-server](https://github.com/cozystack/cozystack-telemetry-server) - follow-up: - [ ] [cozystack/external-apps-example](https://github.com/cozystack/external-apps-example) - follow-up: - [ ] [cozystack/examples](https://github.com/cozystack/examples) - follow-up: - [ ] [cozystack/community](https://github.com/cozystack/community) - follow-up: ### Release note ```release-note fix(vertical-pod-autoscaler): the admission controller runs two replicas spread over nodes with a PodDisruptionBudget, so pods created during a drain still get their VPA recommendation. ``` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> <!-- coderabbit-ai-generated:v1 --> ## Summary by CodeRabbit * **Improvements** * The VPA admission controller now runs with two replicas, increasing availability. * Its pods are spread across hostnames when scheduling permits, helping reduce the impact of node-level disruptions. * A disruption budget requires at least one admission-controller pod to remain available during voluntary disruptions. <!-- end of auto-generated comment: release notes by coderabbit.ai -->