mirror of
https://github.com/cozystack/cozystack.git
synced 2026-11-21 20:23:39 +09:00
The shell translator rewrites test bodies and loses Bats reporting. The unit lane needs complete TAP results and JUnit reports without changing how live-cluster suites run. Sourced production helpers still need a dash pass, and unit test bodies need nounset without exporting shell options into subprocesses. Assisted-by: LLM Signed-off-by: Myasnikov Daniil <myasnikovdaniil2001@gmail.com>
249 lines
11 KiB
Bash
249 lines
11 KiB
Bash
#!/usr/bin/env bats
|
|
# -----------------------------------------------------------------------------
|
|
# The SeaweedFS naming guard exists in two copies:
|
|
#
|
|
# packages/system/seaweedfs/templates/naming-guard.yaml (ENFORCING — the
|
|
# <name>-system HelmRelease pulls this chart from a platform-managed
|
|
# ExternalArtifact, so a platform upgrade re-renders it directly and nothing
|
|
# else stands between the upgrade and the tenant's workloads)
|
|
# packages/extra/seaweedfs/templates/seaweedfs.yaml (sibling — warns on
|
|
# the SeaweedFS application itself, where the operator looks first)
|
|
#
|
|
# They cannot be shared: the two packages are separate charts and neither depends
|
|
# on cozy-lib, so there is no library either could include the classifier from.
|
|
# They were kept in sync by a comment saying "keep the two classifications in
|
|
# sync" — and this whole branch exists because the guard lived in the wrong
|
|
# chart. Silent drift between the copies is the same failure class, so pin it.
|
|
#
|
|
# Only the DETECTION block is compared: the two `fail` messages differ by design
|
|
# ("SeaweedFS release <name>" vs "SeaweedFS <name>", matching each chart's voice)
|
|
# and the branch structure is asserted separately. It is the detection — which
|
|
# objects establish which generation — that must never diverge.
|
|
#
|
|
# The block starts at the reconstruction, not at the flag declarations: the line
|
|
# above it is deliberately different per chart (system/ IS the <name>-system
|
|
# release; extra/ is <name> and derives the child), and that is the ONLY sanctioned
|
|
# difference. Both are asserted separately below.
|
|
#
|
|
# Run with: bats hack/seaweedfs-guard-parity.bats
|
|
# -----------------------------------------------------------------------------
|
|
|
|
load test_helper
|
|
|
|
SYS="$PWD/packages/system/seaweedfs/templates/naming-guard.yaml"
|
|
EXTRA="$PWD/packages/extra/seaweedfs/templates/seaweedfs.yaml"
|
|
|
|
# detection_block <file> -- the generation-detection lines, from the first flag
|
|
# declaration through the two derived generation booleans.
|
|
detection_block() {
|
|
sed -n '/\$renamedVol := include/,/\$systemGen := or/p' "$1"
|
|
}
|
|
|
|
# template_code <file> -- the file with its {{/* ... */}} spans removed.
|
|
#
|
|
# A discriminator is forbidden as template LOGIC, and both charts carry long
|
|
# comment blocks arguing why these particular signals were rejected. Grepping the
|
|
# raw file cannot tell the argument from the thing argued against, so it reports
|
|
# a chart for documenting the rule it obeys.
|
|
#
|
|
# The span and not the line. Dropping every line that opens a comment is one
|
|
# character shorter and silently loses `{{- $x := .creationTimestamp }} {{/* why
|
|
# */}}`: the discriminator leaves with the comment and the checks below find
|
|
# nothing. Nothing downstream sees it either -- that line both opens and closes,
|
|
# so the strip finishes cleanly and every canary token survives. The only
|
|
# symptom is a chart that classifies on a forbidden signal and a test that says
|
|
# it does not.
|
|
#
|
|
# A file that ends inside a comment is reported on stdout, not through an exit
|
|
# status. Every `{{/*` is read as an opener, including one inside a quoted
|
|
# string -- these charts carry long `fail (printf ...)` messages -- and a lone
|
|
# opener swallows the rest of the file, leaving the checks reading nothing.
|
|
# hack/cozytest.sh rewrites every `}` at column 0 into `return 0; }`, which is
|
|
# this function's closing brace too, so its exit status never reaches the
|
|
# caller: a status the runner discards is a check that is not there.
|
|
#
|
|
# Counting delimiters cannot stand in for the state the strip already carries.
|
|
# Go template comments do not nest -- the first `*/}}` closes the block -- so
|
|
# `{{/* the opener is spelled {{/* */}}` is a comment Helm renders, while its
|
|
# two openers against one closer read as an imbalance that is not one.
|
|
template_code() {
|
|
awk '
|
|
{
|
|
line = $0; out = ""
|
|
while (1) {
|
|
if (!inc) {
|
|
if (match(line, /\{\{-? *\/\*/)) {
|
|
out = out substr(line, 1, RSTART - 1)
|
|
line = substr(line, RSTART + RLENGTH); inc = 1
|
|
} else { out = out line; break }
|
|
} else {
|
|
if (match(line, /\*\/ *-?\}\}/)) { line = substr(line, RSTART + RLENGTH); inc = 0 }
|
|
else break
|
|
}
|
|
}
|
|
if (out ~ /[^[:space:]]/) print out
|
|
}
|
|
END { if (inc) print "__TEMPLATE_COMMENT_LEFT_OPEN__" }
|
|
' "$1"
|
|
}
|
|
|
|
@test "the comment strip removes the span, not the line that opens it" {
|
|
# Pins the difference between the two spellings, because on today's charts
|
|
# they agree: no line carries both a discriminator and a comment opener, so
|
|
# the weaker version passes every check below. It is the shape that would go
|
|
# wrong silently -- a chart classifying on a forbidden signal and this suite
|
|
# reporting that it does not -- so it gets a fixture rather than trust.
|
|
tmp="$(mktemp)"
|
|
printf '%s\n' \
|
|
'{{- $renamedVol := include "x" . }}' \
|
|
'{{- $bad := .metadata.creationTimestamp }} {{/* why this is fine */}}' \
|
|
'{{- /* a whole-line block' \
|
|
' mentioning readyReplicas */}}' > "$tmp"
|
|
|
|
code="$(template_code "$tmp")"
|
|
# A comment-only block still goes.
|
|
if printf '%s\n' "$code" | grep -q 'readyReplicas'; then
|
|
echo "FAIL: a comment-only block survived the strip"
|
|
false
|
|
fi
|
|
# The code sharing a line with an opener does not.
|
|
printf '%s\n' "$code" | grep -q 'creationTimestamp'
|
|
printf '%s\n' "$code" | grep -q 'renamedVol'
|
|
rm -f "$tmp"
|
|
}
|
|
|
|
@test "the comment strip reads a quoted opener as text and reports one left open" {
|
|
# Go template comments do not nest -- the first `*/}}` closes the block -- so
|
|
# a comment documenting the opener syntax is one Helm renders. The strip is
|
|
# already inside a comment when the second opener arrives, so it reads that
|
|
# opener as comment text; counting delimiters reads the same line as two
|
|
# openers against one closer and refuses a chart that is fine.
|
|
tmp="$(mktemp)"
|
|
printf '%s\n' \
|
|
'{{- $renamedVol := include "x" . }}' \
|
|
'{{/* the opener is spelled {{/* and mentions readyReplicas */}}' > "$tmp"
|
|
code="$(template_code "$tmp")"
|
|
printf '%s\n' "$code" | grep -q 'renamedVol'
|
|
if printf '%s\n' "$code" | grep -q 'readyReplicas'; then
|
|
echo "FAIL: the comment quoting an opener survived the strip"
|
|
false
|
|
fi
|
|
if printf '%s\n' "$code" | grep -qF -- '__TEMPLATE_COMMENT_LEFT_OPEN__'; then
|
|
echo "FAIL: a comment that closes was reported as left open"
|
|
false
|
|
fi
|
|
|
|
# An opener with no closer leaves the strip mid-comment at EOF -- the shape
|
|
# that silently swallows every check below it -- and that is what the marker
|
|
# is for.
|
|
printf '%s\n' \
|
|
'{{- $renamedVol := include "x" . }}' \
|
|
'{{- fail (printf "the opener is spelled {{/* in the docs") }}' \
|
|
'{{- $bad := .metadata.creationTimestamp }}' > "$tmp"
|
|
code="$(template_code "$tmp")"
|
|
printf '%s\n' "$code" | grep -qF -- '__TEMPLATE_COMMENT_LEFT_OPEN__'
|
|
# The swallowing is real, not just announced: the line after the lone opener
|
|
# is gone from the output.
|
|
if printf '%s\n' "$code" | grep -q 'creationTimestamp'; then
|
|
echo "FAIL: the fixture does not reproduce the swallow it claims to pin"
|
|
false
|
|
fi
|
|
rm -f "$tmp"
|
|
}
|
|
|
|
@test "both charts detect naming generations with byte-identical logic" {
|
|
a=$(mktemp); b=$(mktemp)
|
|
detection_block "$SYS" > "$a"
|
|
detection_block "$EXTRA" > "$b"
|
|
# Non-empty: a sed range that matched nothing would make this test vacuous.
|
|
[ -s "$a" ]
|
|
[ -s "$b" ]
|
|
diff -u "$a" "$b"
|
|
rm -f "$a" "$b"
|
|
}
|
|
|
|
@test "each chart feeds the reconstruction the <name>-system release name" {
|
|
# system/seaweedfs IS that release; extra/seaweedfs is <name> and must derive it.
|
|
# Getting this wrong silently reconstructs the wrong prefix, so neither
|
|
# generation matches and the guard renders through.
|
|
grep -qF -- '$sysRelease := .Release.Name' "$SYS"
|
|
grep -qF -- '$sysRelease := printf "%s-system" .Release.Name' "$EXTRA"
|
|
}
|
|
|
|
@test "both charts reconstruct the renamed prefix rather than prefix-matching alone" {
|
|
# An instance legitimately named `seaweedfs-volume` renders release-named objects
|
|
# (seaweedfs-volume-system-volume, data1-seaweedfs-volume-system-volume-0) that
|
|
# ALSO satisfy the chart-named prefixes. Release-named must be tested FIRST,
|
|
# against a reconstructed prefix, or live storage reads as legacy.
|
|
for f in "$SYS" "$EXTRA"; do
|
|
grep -qF -- '$renamedVol := include "seaweedfs.renamedVolumePrefix" $sysRelease' "$f"
|
|
# release-named branch precedes the chart-named fallback in both scans
|
|
pv=$(grep -n 'hasPrefix (printf "data1-%s" $renamedVol)' "$f" | cut -d: -f1)
|
|
lv=$(grep -n 'hasPrefix "data1-seaweedfs-volume"' "$f" | cut -d: -f1)
|
|
[ -n "$pv" ] && [ -n "$lv" ] && [ "$pv" -lt "$lv" ]
|
|
ps=$(grep -n 'hasPrefix $renamedVol .metadata.name' "$f" | cut -d: -f1)
|
|
ls=$(grep -n 'hasPrefix "seaweedfs-volume" .metadata.name' "$f" | cut -d: -f1)
|
|
[ -n "$ps" ] && [ -n "$ls" ] && [ "$ps" -lt "$ls" ]
|
|
done
|
|
}
|
|
|
|
@test "both charts derive the generation flags from PVC and StatefulSet evidence" {
|
|
# The OR is load-bearing: a tenant whose PVCs are not provisioned yet is only
|
|
# visible through its label-matched StatefulSet.
|
|
for f in "$SYS" "$EXTRA"; do
|
|
grep -qF -- '$legacyGen := or $legacyPVC $legacySTS' "$f"
|
|
grep -qF -- '$systemGen := or $systemPVC $systemSTS' "$f"
|
|
done
|
|
}
|
|
|
|
@test "both charts refuse when both generations are present" {
|
|
for f in "$SYS" "$EXTRA"; do
|
|
grep -qF -- 'if and $legacyGen $systemGen' "$f"
|
|
grep -qF -- 'has BOTH naming generations present' "$f"
|
|
done
|
|
}
|
|
|
|
@test "both charts refuse a release-named-only tenant (class S)" {
|
|
for f in "$SYS" "$EXTRA"; do
|
|
grep -qF -- 'else if $systemGen' "$f"
|
|
grep -qF -- 'keeps its data on volumes named after the Helm release' "$f"
|
|
done
|
|
}
|
|
|
|
@test "neither chart classifies on mutable claim timestamps or liveness" {
|
|
# The premise "PVCs are never recreated in place" is false: the runbook's own
|
|
# Step 2 re-bind deletes and recreates each claim, so a tenant interrupted
|
|
# part-way through reads as the exact inverse of the truth — and the step the
|
|
# old classification pointed at deletes the claim Step 2 just re-bound.
|
|
# readyReplicas is likewise only a snapshot, not proof a duplicate never
|
|
# served. Neither may come back as a discriminator.
|
|
for f in "$SYS" "$EXTRA"; do
|
|
# Whether the strip finished is the precondition for reading what it
|
|
# returned. A lone `{{/*` -- one inside a quoted string, and these charts
|
|
# carry long `fail (printf ...)` messages -- swallows the rest of the file,
|
|
# and the checks below would then find nothing and report a clean chart.
|
|
# It has to be asked here rather than covered by a canary token: a token
|
|
# only proves that whatever precedes IT survived, and the block most likely
|
|
# to do the swallowing is the last one in the file.
|
|
code=$(template_code "$f")
|
|
if printf '%s\n' "$code" | grep -qF -- '__TEMPLATE_COMMENT_LEFT_OPEN__'; then
|
|
echo "FAIL: $f ends inside a template comment, so the strip cannot be trusted"
|
|
false
|
|
fi
|
|
printf '%s\n' "$code" | grep -qF -- '$renamedVol'
|
|
for signal in 'creationTimestamp' 'readyReplicas' '$systemOldest' '$legacyOldest'; do
|
|
if printf '%s\n' "$code" | grep -qF -- "$signal"; then
|
|
echo "FAIL: $f classifies on $signal, which cannot establish which generation holds the data"
|
|
false
|
|
fi
|
|
done
|
|
done
|
|
}
|
|
|
|
@test "both charts gate the guard behind the same cluster-view canary" {
|
|
for f in "$SYS" "$EXTRA"; do
|
|
grep -qF -- '$canary := lookup "v1" "Namespace" "" .Release.Namespace' "$f"
|
|
grep -qF -- 'refusing to upgrade blind' "$f"
|
|
done
|
|
}
|