mirror of
https://github.com/cozystack/cozystack.git
synced 2026-11-21 12:13:55 +09:00
users[].password is gone from the chart, its schema and the API type. Every application-user password is generated into <release>-credentials and kept across reconciles by lookup, so an upgraded release keeps the password it already has and a password left in values is ignored. The init-job mounts that Secret and applies each password with ALTER ROLE and a psql variable, so no password is rendered into the init-script Secret that Helm keeps in release history. While bootstrap is enabled the Secret is marked credentials-pending, and NOTES say the generated passwords apply once the init-job runs. Names reach superuser SQL and the init-script shell, so render-time guards reject a username, database or extension name outside [-._a-zA-Z0-9] or past the length PostgreSQL silently truncates: 63 bytes for a role or extension, 54 for a database, whose <db>_readonly role would otherwise truncate and fail the next run. A username over 63 bytes that the credentials Secret already carries still upgrades. users.postgres, the CNPG superuser, is rejected in every bootstrap state. Changing a database's key in values drops the database, so the reject message and the README give the rename that keeps the data: a platform administrator renames it and its roles as the CNPG superuser before the key changes. The init-job cannot hang its Helm hook: the readiness wait ends on elapsed time below activeDeadlineSeconds and the Job never retries, so a purged restore target fails with a diagnostic. The delete-users pass reads managed users from pg_shdescription instead of parsing the version-dependent \du+ layout, which on PostgreSQL 16 and later matched nothing and left a removed user able to log in; it compares names as CREATE ROLE stores them and reassigns a removed user's objects in every database before dropping it. A database without roles renders, and extension names are quoted for hyphenated names and folded to lowercase so they resolve as they did unquoted. A value that carries its own surrounding quotes, the only way a hyphenated extension rendered before, has that pair removed and keeps its case, so such a release still upgrades. The README reads a password with jq, since jsonpath splits a dotted key. Signed-off-by: Alexey Artamonov <aleksei.artamonov@aenix.io>
100 lines
4.2 KiB
YAML
100 lines
4.2 KiB
YAML
suite: the init-job is bounded so a purged restore target cannot deadlock the Helm hook
|
|
|
|
# Clearing bootstrap.enabled arms the init Job as a post-install,post-upgrade Helm
|
|
# hook that Helm blocks on. Its pod mounts <release>-superuser (which CNPG deletes
|
|
# with the Cluster) and waited `until pg_isready; do sleep 5; done` with no bound
|
|
# and no activeDeadlineSeconds. When a second restore purges the same target while
|
|
# that hook is still pending, the hook can never finish and Helm deadlocks on it —
|
|
# the postgres-2-backup-roundtrip E2E caught exactly this. Bound the Job (a hard
|
|
# activeDeadlineSeconds and no retries) and the readiness wait (a bounded loop that
|
|
# exits) so a purged target fails the hook fast instead of hanging forever.
|
|
|
|
release:
|
|
name: pg-test
|
|
namespace: tenant-test
|
|
|
|
set:
|
|
_cluster:
|
|
scheduling: {}
|
|
users:
|
|
app: {}
|
|
|
|
tests:
|
|
# On an UPGRADE the Cluster is already up, so pg_isready answers in seconds, but
|
|
# the deadline must still leave room for the per-schema grant DO block on a large
|
|
# existing database — 540s, well below the 10m (600s) hook budget so a purged
|
|
# target's Job fails with its own diagnostic before Helm's generic timeout, yet
|
|
# not the tight 300s that would fail a legitimate long grant pass. A bump back to
|
|
# 600 (== the Helm timeout) reddens here.
|
|
- it: the init Job is bounded on upgrade with grant-loop headroom and does not retry
|
|
template: templates/init-job.yaml
|
|
release:
|
|
name: pg-test
|
|
namespace: tenant-test
|
|
upgrade: true
|
|
asserts:
|
|
- isKind:
|
|
of: Job
|
|
- equal:
|
|
path: spec.backoffLimit
|
|
value: 0
|
|
- equal:
|
|
path: spec.activeDeadlineSeconds
|
|
value: 540
|
|
- matchRegex:
|
|
path: metadata.annotations["helm.sh/hook"]
|
|
pattern: post-upgrade
|
|
# On a fresh INSTALL nothing is running yet — the same release is provisioning the
|
|
# Cluster (PVC, image pull, initdb) — and there is no purge hazard, so the cold
|
|
# start gets the near-full budget (570s) rather than the tight upgrade deadline
|
|
# that would fail a slow-but-healthy first boot. Collapsing this back to one number
|
|
# for both contexts reddens one side or the other.
|
|
- it: the init Job gives a cold install the near-full budget
|
|
template: templates/init-job.yaml
|
|
asserts:
|
|
- equal:
|
|
path: spec.activeDeadlineSeconds
|
|
value: 570
|
|
|
|
# The wait is bounded by wall-clock elapsed ($SECONDS), not by an attempt count:
|
|
# an attempt count ignores the time pg_isready itself takes, so 110 attempts of
|
|
# "sleep 5" really ran past the 570s Job deadline and the Job was killed before
|
|
# the loop could print its diagnostic or leave the create-users/grant work any
|
|
# time. The bound sits below activeDeadlineSeconds so the tail is reserved for
|
|
# that work. Reverting to an attempt counter, or raising the bound to the Job
|
|
# deadline, reddens these.
|
|
- it: the readiness wait is bounded by elapsed time on install, reserving the deadline tail
|
|
template: templates/init-script.yaml
|
|
documentSelector:
|
|
path: metadata.name
|
|
value: pg-test-init-script
|
|
asserts:
|
|
- notMatchRegex:
|
|
path: stringData["init.sh"]
|
|
pattern: 'until pg_isready ; do sleep 5; done'
|
|
- notMatchRegex:
|
|
path: stringData["init.sh"]
|
|
pattern: 'attempts'
|
|
# Install (the suite default): the cold, still-provisioning Cluster gets up to
|
|
# 480s of script time, leaving at most 90s of the 570s Job deadline (less the
|
|
# pod's start-up, which the Job clock counts) for the work after readiness.
|
|
- matchRegex:
|
|
path: stringData["init.sh"]
|
|
pattern: 'if \[ "\$SECONDS" -ge 480 \]; then'
|
|
|
|
- it: the readiness wait is tight on upgrade (Cluster already up, purge hazard)
|
|
template: templates/init-script.yaml
|
|
release:
|
|
name: pg-test
|
|
namespace: tenant-test
|
|
upgrade: true
|
|
documentSelector:
|
|
path: metadata.name
|
|
value: pg-test-init-script
|
|
asserts:
|
|
# Upgrade: the Cluster is already up, so give up after 250s, leaving up to 290s
|
|
# of the 540s Job deadline for the per-schema grant pass on a large database.
|
|
- matchRegex:
|
|
path: stringData["init.sh"]
|
|
pattern: 'if \[ "\$SECONDS" -ge 250 \]; then'
|