Files
cozystack/packages/apps/postgres/tests/init_job_cleanup_test.yaml
T
Alexey Artamonov 2b5877eff9 feat(postgres)!: generate user passwords and read them at runtime
users[].password is gone from the chart, its schema and the API type.
Every application-user password is generated into <release>-credentials
and kept across reconciles by lookup, so an upgraded release keeps the
password it already has and a password left in values is ignored. The
init-job mounts that Secret and applies each password with ALTER ROLE
and a psql variable, so no password is rendered into the init-script
Secret that Helm keeps in release history. While bootstrap is enabled
the Secret is marked credentials-pending, and NOTES say the generated
passwords apply once the init-job runs.

Names reach superuser SQL and the init-script shell, so render-time
guards reject a username, database or extension name outside
[-._a-zA-Z0-9] or past the length PostgreSQL silently truncates: 63
bytes for a role or extension, 54 for a database, whose <db>_readonly
role would otherwise truncate and fail the next run. A username over 63
bytes that the credentials Secret already carries still upgrades.
users.postgres, the CNPG superuser, is rejected in every bootstrap
state. Changing a database's key in values drops the database, so the
reject message and the README give the rename that keeps the data: a
platform administrator renames it and its roles as the CNPG superuser
before the key changes.

The init-job cannot hang its Helm hook: the readiness wait ends on
elapsed time below activeDeadlineSeconds and the Job never retries, so a
purged restore target fails with a diagnostic. The delete-users pass
reads managed users from pg_shdescription instead of parsing the
version-dependent \du+ layout, which on PostgreSQL 16 and later matched
nothing and left a removed user able to log in; it compares names as
CREATE ROLE stores them and reassigns a removed user's objects in every
database before dropping it. A database without roles renders, and
extension names are quoted for hyphenated names and folded to lowercase
so they resolve as they did unquoted. A value that carries its own
surrounding quotes, the only way a hyphenated extension rendered before,
has that pair removed and keeps its case, so such a release still
upgrades. The README reads a password with jq, since jsonpath splits a
dotted key.

Signed-off-by: Alexey Artamonov <aleksei.artamonov@aenix.io>
2026-09-24 18:10:57 +03:00

52 lines
1.6 KiB
YAML

suite: init-job is garbage-collected after completion
# Locks in cozystack/cozystack#3055: the post-install/post-upgrade init Job
# is a one-shot reconciler of users/databases/roles. Without a TTL it lingers
# in the namespace forever after the Postgres CR is deleted (its hook-delete-policy
# is 'before-hook-creation' only, which never fires on uninstall). A native
# ttlSecondsAfterFinished lets the Kubernetes TTL controller GC the Job and its
# Pod ~1 hour after it completes, regardless of Helm hook lifecycle — without
# touching the hook-timeout semantics the recovery flow depends on. 1h leaves a
# debugging window for a failed init Job before it is collected.
# Both templates are loaded so the Job's checksum/config annotation can resolve
# its `include ".../init-script.yaml"`. Each test then pins assertions to a
# single template via `template:` so the per-template document set is exact.
templates:
- templates/init-job.yaml
- templates/init-script.yaml
release:
name: pg-test
namespace: tenant-test
set:
_cluster:
scheduling: {}
users:
app: {}
tests:
- it: "init-job sets ttlSecondsAfterFinished so Kubernetes GCs it after the run"
template: templates/init-job.yaml
asserts:
- hasDocuments:
count: 1
- isKind:
of: Job
- equal:
path: metadata.name
value: pg-test-init-job
- equal:
path: spec.ttlSecondsAfterFinished
value: 3600
- it: "init-job is skipped entirely under bootstrap recovery"
template: templates/init-job.yaml
set:
bootstrap:
enabled: true
asserts:
- hasDocuments:
count: 0