mirror of
https://github.com/cozystack/cozystack.git
synced 2026-11-21 12:13:55 +09:00
Keying the network-data on instanceProfile reached every VM that never set the field, because the profile defaults to ubuntu whatever image the disk holds. The sysconfig, NetworkManager and eni renderers turn each match stanza into an interface literally named after the netplan ID, so a non-netplan guest left on the default profile would lose the DHCP it gets today. A VM with neither cloudInit nor sshKeys would also gain a cloud-init disk on upgrade, and KubeVirt's NoCloud instance-id is new to that guest, so its next boot would regenerate host keys as a first boot. The configuration also shadows a static NIC set up through netplan: netplan emits one networkd file per ID, networkd applies only the first file in lexical order that matches a link, and 10-netplan-cozy-en sorts before the file for enp2s0. The external-VLAN recipe claimed otherwise. An explicit netplanDhcp value, off by default, leaves every existing VM rendering exactly as before and lets the documentation say when not to turn it on. Assisted-by: LLM Signed-off-by: Mattia Eleuteri <mattia@hidora.io>
233 lines
10 KiB
Smarty
233 lines
10 KiB
Smarty
{{/*
|
|
Expand the name of the chart.
|
|
*/}}
|
|
{{- define "virtual-machine.name" -}}
|
|
{{- default .Chart.Name .Values.nameOverride | trunc 63 | trimSuffix "-" }}
|
|
{{- end }}
|
|
|
|
{{/*
|
|
Create a default fully qualified app name.
|
|
We truncate at 63 chars because some Kubernetes name fields are limited to this (by the DNS naming spec).
|
|
If release name contains chart name it will be used as a full name.
|
|
*/}}
|
|
{{- define "virtual-machine.fullname" -}}
|
|
{{- if .Values.fullnameOverride }}
|
|
{{- .Values.fullnameOverride | trunc 63 | trimSuffix "-" }}
|
|
{{- else }}
|
|
{{- $name := default .Chart.Name .Values.nameOverride }}
|
|
{{- if contains $name .Release.Name }}
|
|
{{- .Release.Name | trunc 63 | trimSuffix "-" }}
|
|
{{- else }}
|
|
{{- printf "%s-%s" .Release.Name $name | trunc 63 | trimSuffix "-" }}
|
|
{{- end }}
|
|
{{- end }}
|
|
{{- end }}
|
|
|
|
{{/*
|
|
Create chart name and version as used by the chart label.
|
|
*/}}
|
|
{{- define "virtual-machine.chart" -}}
|
|
{{- printf "%s-%s" .Chart.Name .Chart.Version | replace "+" "_" | trunc 63 | trimSuffix "-" }}
|
|
{{- end }}
|
|
|
|
{{/*
|
|
Common labels
|
|
*/}}
|
|
{{- define "virtual-machine.labels" -}}
|
|
helm.sh/chart: {{ include "virtual-machine.chart" . }}
|
|
{{ include "virtual-machine.selectorLabels" . }}
|
|
{{- if .Chart.AppVersion }}
|
|
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
|
|
{{- end }}
|
|
app.kubernetes.io/managed-by: {{ .Release.Service }}
|
|
{{- end }}
|
|
|
|
{{/*
|
|
Selector labels
|
|
*/}}
|
|
{{- define "virtual-machine.selectorLabels" -}}
|
|
app.kubernetes.io/name: {{ include "virtual-machine.name" . }}
|
|
app.kubernetes.io/instance: {{ .Release.Name }}
|
|
{{- end }}
|
|
|
|
{{/*
|
|
Generate a stable UUID for cloud-init re-initialization upon upgrade.
|
|
*/}}
|
|
{{- define "virtual-machine.stableUuid" -}}
|
|
{{- $source := printf "%s-%s-%s" .Release.Namespace (include "virtual-machine.fullname" .) .Values.cloudInitSeed }}
|
|
{{- $hash := sha256sum $source }}
|
|
{{- $uuid := printf "%s-%s-4%s-9%s-%s" (substr 0 8 $hash) (substr 8 12 $hash) (substr 13 16 $hash) (substr 17 20 $hash) (substr 20 32 $hash) }}
|
|
{{- if eq .Values.cloudInitSeed "" }}
|
|
{{- /* Try to save previous uuid to not trigger full cloud-init again if user decided to remove the seed. */}}
|
|
{{- $vmResource := lookup "kubevirt.io/v1" "VirtualMachine" .Release.Namespace (include "virtual-machine.fullname" .) -}}
|
|
{{- if $vmResource }}
|
|
{{- $existingUuid := $vmResource | dig "spec" "template" "spec" "domain" "firmware" "uuid" "" }}
|
|
{{- if $existingUuid }}
|
|
{{- $uuid = $existingUuid }}
|
|
{{- end }}
|
|
{{- end }}
|
|
{{- end }}
|
|
{{- $uuid }}
|
|
{{- end }}
|
|
|
|
{{/*
|
|
Domain resources (cpu, memory) as a JSON object.
|
|
Used in vm.yaml for rendering and in the update hook for merge patches.
|
|
|
|
cpu and sockets are schema-typed as quantities but land in domain.cpu.cores
|
|
and domain.cpu.sockets, which KubeVirt declares as uint32. Casting 500m to an
|
|
integer yields 0, and KubeVirt boots a zero core count as one core, so only a
|
|
whole count within uint32 gets past this point. The raw spelling is decoded
|
|
as YAML, so +2, 2.0 or 1e1 pass as the integers they decode to; a leading
|
|
zero is refused outright, because YAML decodes 010 as octal 8. Presence
|
|
rather than truth, so that a 0 is refused instead of read as unset. Memory
|
|
stays a quantity, which KubeVirt accepts as such, but KubeVirt v1.9.0
|
|
admission refuses a non-zero amount below 1M
|
|
(validateMemoryRequestsNegativeOrNull in
|
|
pkg/virt-api/webhooks/validating-webhook/admitters/vmi-create-admitter.go),
|
|
and a zero or negative amount sizes nothing, so the render refuses both.
|
|
|
|
A number the operator left unquoted reaches the chart already decoded, and
|
|
its spelling is gone, so the error labels it as read rather than written. The
|
|
schema admits a number only as an integer, so it prints as whole digits,
|
|
never in the exponent form a large float64 takes under %v.
|
|
*/}}
|
|
{{- define "virtual-machine.resourceAsWritten" -}}
|
|
{{- if kindIs "string" . -}}
|
|
{{- . -}}
|
|
{{- else -}}
|
|
{{- printf "read as %.0f" (float64 .) -}}
|
|
{{- end -}}
|
|
{{- end -}}
|
|
|
|
{{- define "virtual-machine.domainResources" -}}
|
|
{{- $resources := .Values.resources | default dict -}}
|
|
{{- $counts := dict -}}
|
|
{{- range $field := list "cpu" "sockets" -}}
|
|
{{- $value := index $resources $field -}}
|
|
{{- if not (kindIs "invalid" $value) -}}
|
|
{{- $raw := printf "%v" $value -}}
|
|
{{- $count := (printf "v: %s" $raw | fromYaml).v -}}
|
|
{{- $isNumber := or (kindIs "int" $count) (kindIs "int64" $count) (kindIs "float64" $count) -}}
|
|
{{- $whole := and $isNumber (gt (float64 $count) 0.0) (le (float64 $count) 4294967295.0) (eq (floor $count) (float64 $count)) -}}
|
|
{{- if or (not $whole) (regexMatch "^\\+?0[0-9]" $raw) -}}
|
|
{{- fail (printf "resources.%s (%s) must be a positive whole number, such as 2. It becomes the VM's domain.cpu.%s, which KubeVirt declares as an unsigned integer, so a millicore or other unit-suffixed, fractional, zero, negative, out-of-range or leading-zero quantity cannot size the guest. Set a whole number, or remove the field." $field (include "virtual-machine.resourceAsWritten" $value) (ternary "cores" "sockets" (eq $field "cpu"))) -}}
|
|
{{- end -}}
|
|
{{- $_ := set $counts $field ($count | int64) -}}
|
|
{{- end -}}
|
|
{{- end -}}
|
|
{{- $memory := index $resources "memory" -}}
|
|
{{- if not (kindIs "invalid" $memory) -}}
|
|
{{- if lt (include "cozy-lib.resources.toFloat" $memory | float64) 1e6 -}}
|
|
{{- fail (printf "resources.memory (%s) must be at least 1M, such as 8Gi. KubeVirt refuses a non-zero amount below 1M, and a zero or negative amount sizes nothing. Set a larger amount, or remove the field." (include "virtual-machine.resourceAsWritten" $memory)) -}}
|
|
{{- end -}}
|
|
{{- end -}}
|
|
{{- $result := dict -}}
|
|
{{- if or .Values.cpuModel (and $counts.cpu $counts.sockets) -}}
|
|
{{- $cpu := dict -}}
|
|
{{- if and $counts.cpu $counts.sockets -}}
|
|
{{- $_ := set $cpu "cores" $counts.cpu -}}
|
|
{{- $_ := set $cpu "sockets" $counts.sockets -}}
|
|
{{- end -}}
|
|
{{- if .Values.cpuModel -}}
|
|
{{- $_ := set $cpu "model" .Values.cpuModel -}}
|
|
{{- end -}}
|
|
{{- $_ := set $result "cpu" $cpu -}}
|
|
{{- end -}}
|
|
{{- with $memory -}}
|
|
{{- $_ := set $result "resources" (dict "requests" (dict "memory" .)) -}}
|
|
{{- end -}}
|
|
{{- $result | toJson -}}
|
|
{{- end -}}
|
|
|
|
{{/*
|
|
Instance type actually rendered into the VM spec, empty when the VM is sized by
|
|
explicit resources instead.
|
|
|
|
KubeVirt v1.9.0 refuses a VirtualMachine that carries an instancetype matcher
|
|
together with explicit domain sizing, and the two halves of that rule are not
|
|
the same shape. validateCPU in pkg/instancetype/apply/cpu.go conflicts on
|
|
domain.cpu.cores and domain.cpu.sockets only when they are non-zero;
|
|
validateMemory in memory.go conflicts on domain.resources.requests.memory
|
|
whenever the key is present, zero included. A resources block that supplies
|
|
all three therefore replaces the matcher, the same way the kubernetes-nodes
|
|
chart already sizes its worker VMs.
|
|
|
|
Everything below is decided from what domainResources actually emitted, never
|
|
from which keys the user set. The two readings differ, and only the first one
|
|
is the question KubeVirt asks. domainResources needs cpu and sockets together
|
|
before it writes domain.cpu, so a whole resources.cpu on its own emits nothing
|
|
and conflicts with nothing; those releases render today and must keep
|
|
rendering. Reading the emitted values also survives a resources block the
|
|
user nulls outright, which Helm coalescing turns into a nil .Values.resources
|
|
that a raw field read would dereference. cpuModel writes domain.cpu.model,
|
|
which conflicts only when the instance type declares a model of its own, so
|
|
it is deliberately not among the three fields read back here.
|
|
|
|
A block that emits some sizing but not all of it has no safe reading next to an
|
|
instance type: dropping the matcher would size the VM from fields the user
|
|
never finished, and keeping it either loses to the webhook or silently discards
|
|
what was typed. Stop the render and name both sides instead.
|
|
*/}}
|
|
{{- define "virtual-machine.effectiveInstanceType" -}}
|
|
{{- $domain := include "virtual-machine.domainResources" . | fromJson -}}
|
|
{{- $sized := list -}}
|
|
{{- $unsized := list -}}
|
|
{{- if dig "cpu" "cores" nil $domain -}}
|
|
{{- $sized = append $sized "resources.cpu" -}}
|
|
{{- else -}}
|
|
{{- $unsized = append $unsized "resources.cpu" -}}
|
|
{{- end -}}
|
|
{{- if dig "cpu" "sockets" nil $domain -}}
|
|
{{- $sized = append $sized "resources.sockets" -}}
|
|
{{- else -}}
|
|
{{- $unsized = append $unsized "resources.sockets" -}}
|
|
{{- end -}}
|
|
{{- if dig "resources" "requests" "memory" nil $domain -}}
|
|
{{- $sized = append $sized "resources.memory" -}}
|
|
{{- else -}}
|
|
{{- $unsized = append $unsized "resources.memory" -}}
|
|
{{- end -}}
|
|
{{- if empty $unsized -}}
|
|
{{- /* Sized by resources, so no matcher is rendered and nothing conflicts. */ -}}
|
|
{{- else if and $sized .Values.instanceType -}}
|
|
{{- fail (printf "instanceType %q cannot be combined with a resources block that sizes the VM only in part. Sizing came from %s, but not from %s. resources.cpu and resources.sockets size the VM only when both are set to whole numbers. KubeVirt rejects a VirtualMachine that carries an instancetype matcher together with explicit domain cpu or memory, so either give resources.cpu, resources.sockets and resources.memory values that all size the VM, or clear %s and let the instance type size it." .Values.instanceType (join ", " $sized) (join ", " $unsized) (join ", " $sized)) -}}
|
|
{{- else -}}
|
|
{{- /* An explicit instanceType: null survives the merge as a nil, which Go
|
|
renders as the truthy literal <no value>: a name no lookup matches. */ -}}
|
|
{{- .Values.instanceType | default "" -}}
|
|
{{- end -}}
|
|
{{- end -}}
|
|
|
|
{{/*
|
|
Node Affinity for Windows VMs
|
|
*/}}
|
|
{{- define "virtual-machine.nodeAffinity" -}}
|
|
{{- if .Values._cluster.scheduling -}}
|
|
{{- $dedicatedNodesForWindowsVMs := get .Values._cluster.scheduling "dedicatedNodesForWindowsVMs" -}}
|
|
{{- if eq $dedicatedNodesForWindowsVMs "true" -}}
|
|
{{- $isWindows := hasPrefix "windows" (toString .Values.instanceProfile) -}}
|
|
affinity:
|
|
nodeAffinity:
|
|
{{- if $isWindows }}
|
|
requiredDuringSchedulingIgnoredDuringExecution:
|
|
nodeSelectorTerms:
|
|
- matchExpressions:
|
|
- key: scheduling.cozystack.io/vm-windows
|
|
operator: In
|
|
values:
|
|
- "true"
|
|
{{- else }}
|
|
preferredDuringSchedulingIgnoredDuringExecution:
|
|
- weight: 100
|
|
preference:
|
|
matchExpressions:
|
|
- key: scheduling.cozystack.io/vm-windows
|
|
operator: NotIn
|
|
values:
|
|
- "true"
|
|
{{- end }}
|
|
{{- end -}}
|
|
{{- end -}}
|
|
{{- end -}}
|