mirror of
https://github.com/cozystack/cozystack.git
synced 2026-11-21 20:23:39 +09:00
<!-- Thank you for making a contribution! Here are some tips for you: - Use Conventional Commits for the PR title: `type(scope): description` - Types: feat, fix, docs, style, refactor, perf, test, build, ci, chore - Scopes are not an exhaustive list — pick the most specific scope for the change and extend the list when a genuinely new area appears. Examples: - System components: dashboard, platform, operator, cilium, kube-ovn, linstor, fluxcd, cluster-api - Managed apps: postgres, mariadb, redis, kafka, clickhouse, virtual-machine, kubernetes - Development and maintenance: api, hack, tests, ci, docs, maintenance - Breaking changes: append `!` after type/scope (`feat(api)!: ...`) or add a `BREAKING CHANGE:` footer - If it's a work in progress, consider creating this PR as a draft. - Don't hesistate to ask for opinion and review in the community chats, even if it's still a draft. - Add the label `kind/backport` if it's a bugfix that needs to be backported to a previous version. --> ## What this PR does Every SeaweedFS component is a Go binary running under a cgroup memory limit, and none of them set `GOMEMLIMIT`. The collector then works from `GOGC` alone, which is a target relative to the live heap with no absolute ceiling, so a burst of allocation grows the heap past the limit and the kernel kills the container. This is not a leak. On the cluster where it showed up, the S3 gateway held 6.4 GiB of `heap_sys` against an 8 GiB limit while `heap_inuse` was 389 MiB: the container was killed over memory the runtime was holding and not using. Ten kills in seven days, each one an interruption of the object store every tenant writes its backups to. Raising the limit does not help, because nothing bounds the growth; it only moves the ceiling the heap climbs to. This PR adds a `cozy-lib.resources.goMemLimit` helper next to the existing `javaHeap` one and wires it into the master, volume, filer and s3 components and into every volume pool and zone, each sized from the memory limit already computed for it. Pools need their own value because the subchart merges `volume` into every entry of `volumes`: without one, a `t1.nano` pool would inherit the value sized for the default volume's 512Mi limit, above its own 128Mi. The value is 75% of the limit, the same fraction `javaHeap` uses for the JVM; the remaining quarter covers what `GOMEMLIMIT` does not account for, goroutine stacks and mmap'd regions among them. The lifecycle admin and worker run the same binary under limits the parent chart does not set (256Mi and 512Mi in `packages/system/seaweedfs/values.yaml`), so their value is pinned next to those limits at the same 75%: 192MiB and 384MiB. A limit under 4/3 Mi (1398102 bytes) floors to `0MiB`, which Go accepts and then collects almost continuously, so the helper fails the render instead. The upstream chart already supports `extraEnvironmentVars` on every one of these components, so nothing had to change there. No values key is added, so this needs no configuration and changes no public schema. Tested with `helm unittest`: a suite on the seaweedfs package asserts the value tracks the memory limit rather than a fixed string, for the default volume, Simple pools, MultiZone zones and zone pools; the system seaweedfs suite asserts the admin and worker env; and a helper suite in `cozy-lib-tests` pins the unit grammar and the rejection of a zero value. Reverting each fix makes its suite fail. ### Screenshots <!-- REQUIRED for UI changes: attach screenshots or screen recordings demonstrating the visual impact of your changes. PRs with UI changes without screenshots will not be merged. --> ### Downstream repositories <!-- Cozystack is upstream for repositories that are NOT kept in sync with it automatically, and nothing in CI compares the two sides, so a change here can break them silently. Which change forces what, and which file to touch, is the trigger map in docs/agents/contributing.md under "Downstream Repositories". Walk it before you tick anything. IF YOU ARE AN AI AGENT OR AN LLM, THIS IS PART OF THE TASK, NOT A FORM TO FILL IN: 1. Walk the trigger map against the actual diff of this PR, file by file. Do not decide from the PR title or from your memory of what you changed. 2. For every repository you tick, open the follow-up PR there and link it on the same line. A ticked box with no link claims work that does not exist, which is worse than an empty box. Search that repository for an open PR or issue covering it first, and link that instead of filing a duplicate. 3. When the follow-up is out of scope, or needs a decision that is not yours to make, open an issue in that repository instead, link that, and say so in the PR body. Do not push a speculative PR into another repository just to fill a line here. 4. Do not tick "No downstream repository is affected" to make the checklist go away. If you are unsure, leave every box empty and say so in the PR body, so a human decides. --> - [x] No downstream repository is affected by this change - [ ] [cozystack/website](https://github.com/cozystack/website) - follow-up: - [ ] [cozystack/terraform-provider-cozystack](https://github.com/cozystack/terraform-provider-cozystack) - follow-up: - [ ] [cozystack/ansible-cozystack](https://github.com/cozystack/ansible-cozystack) - follow-up: - [ ] [cozystack/ccp](https://github.com/cozystack/ccp) - follow-up: - [ ] [cozystack/talm](https://github.com/cozystack/talm) - follow-up: - [ ] [cozystack/cozyhr](https://github.com/cozystack/cozyhr) - follow-up: - [ ] [cozystack/cozy-proxy](https://github.com/cozystack/cozy-proxy) - follow-up: - [ ] [cozystack/cozystack-telemetry-server](https://github.com/cozystack/cozystack-telemetry-server) - follow-up: - [ ] [cozystack/external-apps-example](https://github.com/cozystack/external-apps-example) - follow-up: - [ ] [cozystack/examples](https://github.com/cozystack/examples) - follow-up: - [ ] [cozystack/community](https://github.com/cozystack/community) - follow-up: ### Release note <!-- Write a release note: - Explain what has changed internally and for users. - Start with the same `type(scope):` prefix as in the PR title - Follow the guidelines at https://github.com/kubernetes/community/blob/master/contributors/guide/release-notes.md. --> ```release-note fix(seaweedfs): set GOMEMLIMIT on master, volume (and each pool and zone), filer, s3 and the lifecycle admin and worker so the Go runtime collects before the container hits its memory limit instead of being OOM-killed ``` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> <!-- coderabbit-ai-generated:v1 --> ## Summary by CodeRabbit * **New Features** * SeaweedFS master, volume, pool, zonal volume, filer, and S3 workloads now receive a Go memory limit set to 75% of their configured memory limit. * Pool workloads use their own resource settings when provided, falling back to the default volume preset when needed. * SeaweedFS admin and worker components now have Go memory limits aligned with their configured memory limits. <!-- end of auto-generated comment: release notes by coderabbit.ai -->