From 4c27fd2feaa6df8fb124266cf8a9e6cfb0ea77f2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mart=C3=ADn?= Date: Tue, 29 Jan 2013 14:57:51 +0100 Subject: [PATCH] Bug #1738: expr_bool.y returns -1 if the type does not match --- src/xml/expr_bool.y | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/xml/expr_bool.y b/src/xml/expr_bool.y index b47ca79f2a..c03ccc6701 100644 --- a/src/xml/expr_bool.y +++ b/src/xml/expr_bool.y @@ -230,6 +230,13 @@ int get_xml_attribute(ObjectXML * oxml, const char* attr, int& val) istringstream iss(results[0]); iss >> val; + if (iss.fail()) + { + val = 0; + + return -1; + } + return 0; } @@ -276,6 +283,13 @@ int get_xml_attribute(ObjectXML * oxml, const char* attr, float& val) istringstream iss(results[0]); iss >> val; + if (iss.fail()) + { + val = 0; + + return -1; + } + return 0; }