From 59570cd4022be695b8683d7bdd35598a4ed4faed Mon Sep 17 00:00:00 2001 From: Alejandro Huertas Herrero Date: Tue, 20 Oct 2020 18:54:16 +0200 Subject: [PATCH] M #-: fsck error VMs have same VNC port (#328) --- src/onedb/fsck.rb | 1 + src/onedb/fsck/vm.rb | 24 ++++++++++++++++++++++++ 2 files changed, 25 insertions(+) diff --git a/src/onedb/fsck.rb b/src/onedb/fsck.rb index 96fef07d6e..a48a9f981a 100644 --- a/src/onedb/fsck.rb +++ b/src/onedb/fsck.rb @@ -352,6 +352,7 @@ EOT log_time # VNC + check_vnc_ports # DATA: VNC Bitmap diff --git a/src/onedb/fsck/vm.rb b/src/onedb/fsck/vm.rb index 24ee4eb067..c572e997aa 100644 --- a/src/onedb/fsck/vm.rb +++ b/src/onedb/fsck/vm.rb @@ -7,6 +7,8 @@ module OneDBFsck @data_vm = {} cluster_vnc = @data_vm[:vnc] = {} + @vms_ports = {} + # DATA: Aggregate information of the RUNNING vms @db.fetch("SELECT oid,body FROM vm_pool WHERE state<>6") do |row| vm_doc = nokogiri_doc(row[:body]) @@ -30,6 +32,14 @@ module OneDBFsck cluster_vnc[cid] << port end + # Check if two or more VMs have the same VNC port within a cluster + if cid && port && ![0, 1, 2, 4, 9].include?(state) + @vms_ports[port] = {} unless @vms_ports[port] + @vms_ports[port][cid] = [] unless @vms_ports[port][cid] + + @vms_ports[port][cid] << vm_doc.root.at_xpath('ID').text.to_i + end + # DATA: Images used by this VM vm_doc.root.xpath("TEMPLATE/DISK/IMAGE_ID").each do |e| img_id = e.text.to_i @@ -197,6 +207,20 @@ module OneDBFsck end end + def check_vnc_ports + @vms_ports.each do |port, cid| + cid.each do |cid, vms| + next if vms.size == 1 + + log_error( + "VMs #{vms.join(', ')} have the same VNC port #{port} " \ + "in cluster #{cid}", + false + ) + end + end + end + def fix_vm # DATA: FIX: do vm_pool fixes @db.transaction do