From ab0c98a7465d90f1df2dfafabc798b62719f0482 Mon Sep 17 00:00:00 2001 From: "Ruben S. Montero" Date: Fri, 21 Jun 2013 20:55:58 +0200 Subject: [PATCH] bug #1781: Replaces " by ' and escape ' using '\''. context.sh should be now sh-syntax secure (cherry picked from commit 306aff89060a274ad402412639dda1302abd0055) --- src/vm/VirtualMachine.cc | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/vm/VirtualMachine.cc b/src/vm/VirtualMachine.cc index 86114b2021..774741568f 100644 --- a/src/vm/VirtualMachine.cc +++ b/src/vm/VirtualMachine.cc @@ -2417,7 +2417,17 @@ int VirtualMachine::generate_context(string &files, int &disk_id) for (it=values.begin(); it != values.end(); it++ ) { - file << it->first <<"=\""<< it->second << "\"" << endl; + //Replace every ' in value by '\'' + string escape_str(it->second); + size_t pos = 0; + + while ((pos = escape_str.find('\'', pos)) != string::npos) + { + escape_str.replace(pos,1,"'\\''"); + pos = pos + 4; + } + + file << it->first <<"='" << escape_str << "'" << endl; } file.close();