From c19345db5043ceed14a491f0692e7dec1b1f9a90 Mon Sep 17 00:00:00 2001 From: "Ruben S. Montero" Date: Thu, 5 Jan 2012 02:40:44 +0100 Subject: [PATCH] feature #862: Fixes id check in delete authorization method --- src/rm/RequestManagerDelete.cc | 25 +++++++++++-------------- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/src/rm/RequestManagerDelete.cc b/src/rm/RequestManagerDelete.cc index 9de9c208a1..8c912d89d8 100644 --- a/src/rm/RequestManagerDelete.cc +++ b/src/rm/RequestManagerDelete.cc @@ -32,23 +32,20 @@ bool RequestManagerDelete::delete_authorization(int oid, return true; } - if ( oid >= 0 ) + object = pool->get(oid,true); + + if ( object == 0 ) { - object = pool->get(oid,true); - - if ( object == 0 ) - { - failure_response(NO_EXISTS, - get_error(object_name(auth_object),oid), - att); - return false; - } - - object->get_permissions(perms); - - object->unlock(); + failure_response(NO_EXISTS, + get_error(object_name(auth_object),oid), + att); + return false; } + object->get_permissions(perms); + + object->unlock(); + AuthRequest ar(att.uid, att.gid); ar.add_create_auth(auth_object, "");