From 45cff2384bd3e75c73c9bd29e1015cbdcb0a5b91 Mon Sep 17 00:00:00 2001 From: "Ruben S. Montero" Date: Sat, 29 Oct 2011 00:23:21 +0200 Subject: [PATCH 1/3] bug in oneuser command. Misspelled class constant. --- src/cli/oneuser | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cli/oneuser b/src/cli/oneuser index 4a7c8cd784..293ecbcac1 100755 --- a/src/cli/oneuser +++ b/src/cli/oneuser @@ -173,7 +173,7 @@ cmd=CommandParser::CmdParser.new(ARGV) do end end - driver = options[:driver] || OpenNebula::User::CORE + driver = options[:driver] || OpenNebula::User::CORE_AUTH helper.create_resource(options) do |user| user.allocate(args[0], pass, driver) From a3a8c2079138cf830b5be8ba6638344c2d3e357c Mon Sep 17 00:00:00 2001 From: "Ruben S. Montero" Date: Sat, 29 Oct 2011 23:34:20 +0200 Subject: [PATCH 2/3] Fix delete of Images with empty SOURCE (may happen when an image can not be registered in the repo) --- src/image/ImageManagerActions.cc | 21 ++++++++++++++++++++- src/image/ImageManagerDriver.cc | 4 +--- 2 files changed, 21 insertions(+), 4 deletions(-) diff --git a/src/image/ImageManagerActions.cc b/src/image/ImageManagerActions.cc index 18193f7aa9..0b625a2818 100644 --- a/src/image/ImageManagerActions.cc +++ b/src/image/ImageManagerActions.cc @@ -287,6 +287,7 @@ int ImageManager::enable_image(int iid, bool to_enable) int ImageManager::delete_image(int iid) { Image * img; + string source; img = ipool->get(iid,true); @@ -324,7 +325,25 @@ int ImageManager::delete_image(int iid) return -1; } - imd->rm(img->get_oid(),img->get_source()); + source = img->get_source(); + + if (source.empty()) + { + string err_str; + int rc; + + rc = ipool->drop(img, err_str); + + if ( rc < 0 ) + { + NebulaLog::log("ImM",Log::ERROR, + "Image could not be removed from DB"); + } + } + else + { + imd->rm(img->get_oid(),img->get_source()); + } img->unlock(); diff --git a/src/image/ImageManagerDriver.cc b/src/image/ImageManagerDriver.cc index e352f79d96..9a9db4ddb7 100644 --- a/src/image/ImageManagerDriver.cc +++ b/src/image/ImageManagerDriver.cc @@ -223,9 +223,7 @@ void ImageManagerDriver::protocol( { int rc; string tmp_error; - - source = image->get_source(); - + rc = ipool->drop(image, tmp_error); if ( rc < 0 ) From ba943c98046df634cdc979f84a84ae959bc01b7f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Mart=C3=ADn?= Date: Mon, 31 Oct 2011 17:20:59 +0100 Subject: [PATCH 3/3] Correct oneimage chtype description in CLI --- src/cli/oneimage | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cli/oneimage b/src/cli/oneimage index a401b393cf..349c7916cc 100755 --- a/src/cli/oneimage +++ b/src/cli/oneimage @@ -160,7 +160,7 @@ cmd=CommandParser::CmdParser.new(ARGV) do end chtype_desc = <<-EOT.unindent - Changes the Image group + Changes the Image's type EOT command :chtype, chtype_desc,[:range, :imageid_list], :type do