The walker dropped input past its node, character and per-string budgets
silently, so 32 guards passed a secret placed after the cap. textsOf now
appends a TRUNCATED marker; names/hasSecretIn treat it as a finding. Regenerated
the 38 copies, bumped the 39 plugins, emptied the known-holes baseline.
Co-Authored-By: RuFlo <ruv@ruv.net>
Extend scripts/sync-mod-screen.mjs to a second kit: the flag() helper in hooks/options.ts of 38 mods now sits between SHARED FLAG markers and is
rewritten/checked from ruflo-agentdb. Drift, a lost marker or zero copies fails --check. Bump the 39 touched plugin versions and their version pins.
Co-Authored-By: RuFlo <ruv@ruv.net>
Replaces 37 copy-pasted recursive walkers with a shared breadth-first one (keys as key=value, overlapping windows for long strings, node and char budgets) and widens INVISIBLE (soft hyphen, bidi isolates, Mongolian separator, more). Probe holes 788 -> 0.
Co-Authored-By: RuFlo <ruv@ruv.net>
One canonical region in ruflo-agentdb/hooks/screen.ts, regenerated into the 37 copies by sync-mod-screen.mjs. 'key assignment' is now decided by
the value (not a call/env/path/placeholder/UUID/name; two character classes; >=2.5 bits entropy). Adds stripe, npm, huggingface, sendgrid, twilio,
slack webhook and credentialed DB URL rules; bearer and DB URL placeholders are rejected. 40 new agentdb tests; 20 KB ReDoS probe 0.57 -> 0.68 ms.
Co-Authored-By: RuFlo <ruv@ruv.net>
Live `/SHORT-mod status` ran clean on all 20 assigned plugins; probing the guards with realistic inputs found:
- adr: the guard never fired on the adr-create skill's own writes (hierarchical-store has no namespace field; causal-edge); now keyed on mem:ADR-NNN
- ddd: `domain-<context>` entries (the skill's key) were not screened
- federation: 1 in 10 epoch-ms timestamps passed Luhn and were refused as card numbers; cards must start 2-6
- deepseek-harness: the guard missed an installed copy (plugin-cache version directory)
- browser: `location.href ==` and `.src ==` read as sinks; document['cookie'] and a trailing-dot metadata host slipped through
- bbs-federation: 0, 0.0, 00.0.0.0, 0x0.0.0.0, ::0 and long IPv6 zeros bypassed the wildcard-bind refusal
- chatgpt-federation: payload cap counted UTF-16 units, not bytes
- business-pods: `.env[^/]*` refused a `.environments` directory
Each has a regression test that fails without the fix; plugins bumped one patch.
Co-Authored-By: RuFlo <ruv@ruv.net>
Each plugin gets a tighten-only tool.call guard on its own tools (secrets and
credential fields out of messages/templates, hostile URLs and exfiltration
scripts out of the browser, pub: channels only for the ChatGPT publisher), a
local slash command (/bbs-mod, /browser-mod, /pods-mod, /chatgpt-mod), a
.claude-flow/<short>-mod/status.json, userConfig, tests, smoke steps M1-M3 and
an "As a mod" README section. Versions: bbs 0.3.0, browser 0.3.0, pods 0.2.0,
chatgpt 0.2.0.
Co-Authored-By: RuFlo <ruv@ruv.net>
* feat(memory): distillation service — mine memory_entries into intelligence substrate (ADR-174 M0+M1)
Root cause the goal-planner surfaced: the daemon's consolidate worker
(worker-daemon.ts:1443) is a STUB writing hardcoded zeros — 6000+ commits
recorded to memory_entries but never distilled. reasoning_patterns /
episodes / pattern_embeddings / causal_edges were all empty (hence 🧠 0%).
M0 (safety) + M1 (service): runDistillation() mines memory_entries into
episodes → reasoning_patterns (+pattern_embeddings) → causal_edges.
- $0: reuses structured-distill.ts extractor + the embeddings already on
each row; no LLM, no re-embedding.
- Incremental: distill_state rowid cursor per namespace; never rescans.
- Non-destructive: only inserts into the empty target tables; never
touches memory_entries. Per-batch transactions.
- Safe on the just-recovered DB: quick_check gate skips corrupt DBs;
better-sqlite3 optional (silent no-op).
- Provenance (ADR-171): feedback outcomes = oracle:test-exec (promotable);
everything else = proxy:structural (written, NEVER promoted).
Measured on a copy of the real 7,900-entry DB: 7,899 → 4,260 patterns
(182 promoted, 4,078 proxy), 4,259 embeddings, 4,258 edges; source
unchanged; dry-run wrote nothing; 2nd run processed 0. 6 tests green.
ADR-174 records the decision, root cause, param surface, self-opt plan,
alternatives, rollback. Follow-ups on branch: M2 CLI, M3 daemon (replace
the stub), M4 self-optimization, M5 platform default.
Co-Authored-By: RuFlo <ruv@ruv.net>
* feat(memory): distill CLI, daemon auto-distill, self-optimization (ADR-174 M2+M3+M4)
M2 — CLI: 'memory distill run|status|config' consuming the frozen M1
runDistillation. Full param surface: --dry-run, --namespace, --batch-size,
--dedup-distance, --max-entries, --since, --budget-usd, --judge (fable
gated on budget per ADR-172), --aggressive/--conservative presets,
--config, --db. status reports substrate counts + cursor + provenance
breakdown; degrades gracefully. 12 tests.
M3 — daemon: replaced the runConsolidateWorker STUB (the root cause — it
wrote hardcoded zeros) with a real runDistillation call every 30-min tick,
bounded to 1000 entries/tick (cursor drains a backlog across ticks, stays
well under the 16-min worker timeout). Real DistillReport written to the
metrics file. Opt-out via --no-distill / RUFLO_DAEMON_NO_DISTILL and the
existing 'daemon enable -w consolidate --disable'. Never throws (corrupt/
skipped surfaced, not fatal). 7 tests. The loop is now self-sustaining.
M4 — self-optimization ('ruflo tuning ruflo'): tuneDistillation grid-
searches {batchSize, dedupDistance, promoteThreshold} on ISOLATED copies,
scored by MRR@10/recall@10 on a rowid-based held-out split (train/held-out
disjointness asserted; held-out scored once). Source checksum unchanged.
Honest measured result on the real 7.9k-entry corpus: winner batchSize=200
dedupDistance=0.2 promoteThreshold=execution+corroborated, held-out MRR@10
0.753 vs 0.749 baseline — roughly on par (the substrate/training value is
the payoff, not raw retrieval uplift; measured-not-marketing). 11 tests.
Combined M1+M2+M3+M4: 30 tests green.
Co-Authored-By: RuFlo <ruv@ruv.net>
* feat(browser): page-agent natural-language intent layer — browser_act (ADR-175)
Adds an in-page NL intent tool on top of the selector-based browser tools:
browser_act injects page-agent (Alibaba, MIT) into the agent-browser-driven
page and runs 'execute(task)' — one natural-language call instead of manual
selector orchestration.
Verified against the real page-agent@1.11.0 (ESM-only, split @page-agent/*
packages) — three load-bearing deviations handled:
- import('page-agent') throws 'window is not defined' in Node even when
installed → availability probed via require.resolve (path only, no eval),
like browser-session-tools.ts.
- the injectable IIFE auto-constructs a second PageAgent pointed at Alibaba's
PUBLIC test endpoint (data leak on every call) → stripped before injection
(stripDemoAutoInit).
- execute() returns { success, data, history } → mapped to { result, steps }.
Safety + routing:
- Optional dependency (~1.11.0) + v3 pnpm-lock regenerated same change;
browser_act returns { degraded:true } (never throws) when absent.
- LLM routed through this CLI's Tier-3 ladder (OPENROUTER/OLLAMA, OpenAI-
compatible); bare ANTHROPIC_API_KEY degrades (wrong API shape).
- KEY SAFETY: page-agent runs in page context, so the real key never enters
the injected string — startLocalLLMProxy holds it server-side on a loopback
http server and injects Authorization itself; page sees 127.0.0.1 + a
placeholder. Tests assert no key substring in the injection.
- Trajectory → memory namespace 'browser' (feeds ADR-174 distillation).
- AIDefence gates returned content (optional; passes through if absent).
ADR-175 records the decision, the outer-harness/in-page split, constraints,
the 6 follow-on use cases, alternatives, and rollback. 16 tool tests +
145 mcp-client regression tests green; full build clean.
Co-Authored-By: RuFlo <ruv@ruv.net>
* fix(browser): fail-closed demo-endpoint firewall for page-agent injection
The demo auto-connect (page content → Alibaba's public sandbox at
page-ag-testing-*.fcapp.run) was only neutralized by a best-effort text
strip that fell OPEN — stripDemoAutoInit returned the source unchanged if
the DEMO_MODEL marker moved, silently re-enabling the leak on an upstream
bundle change.
Verified via the real tarball: the demo endpoint lives ONLY in
dist/iife/page-agent.demo.js (6 refs); the library core ESM entry is clean
(0 refs). So no fork is needed — the leak is a property of the demo bundle,
not the library.
Fix: findDemoLeak() firewall + DemoLeakError. buildPageAgentInjection now
scans the stripped bundle for known demo-endpoint signatures
(page-ag-testing, .fcapp.run, DEMO_MODEL) and THROWS if any survive; the
browser_act handler catches it and degrades rather than injecting. This is
version-independent and fail-CLOSED — a moved/renamed marker can no longer
leak, because the guarantee is 'endpoint absent', not 'marker found'.
+4 tests (signature detection, clean-bundle pass, moved-marker refusal,
clean-bundle injection). 20/20 green. ADR-175 updated with the fork-vs-fix
rationale.
Co-Authored-By: RuFlo <ruv@ruv.net>
* fix(browser): add ADR-112 discoverability guidance to browser_act description
CI failed 4 checks (tool-description audit + 3 smoke contracts that run it):
browser_act was the 1 tool of 361 without a 'Use when …' guidance signal.
The audit regex captures only the FIRST quoted segment of a multi-line
description, so the guidance phrase must lead. Reworded to open with
'Use when …' + 'Prefer … over …' + 'pair with …' + 'Falls back …'.
Audit now 361/361, exit 0.
Co-Authored-By: RuFlo <ruv@ruv.net>
* feat(memory): M5 — promote M4 winning distill config as daemon default (ADR-174)
The daemon's consolidate worker now runs the M4-tuned config
(dedupDistance=0.2, chosen by the self-optimization grid-search on the real
corpus). Honest note in code + ADR: held-out MRR@10 0.753 vs 0.749 baseline
— on-par, the substrate/training value is the payoff. Overridable per-run
via 'memory distill'. Completes ADR-174 M0-M5.
Co-Authored-By: RuFlo <ruv@ruv.net>
* docs+fix(memory): address ADR-174 review — honest default, edge contract, invariants (ADR-174)
Review fixes:
- STATUS: Proposed → Accepted (M0-M5 implemented+tested, pending #2570 merge).
- TUNED DEFAULT honestly justified: the M4 retrieval delta (0.753 vs 0.749)
is a TIE, so dedupDistance=0.2 is sold as COMPRESSION, not retrieval lift —
measured 2,723 vs 4,350 patterns (37% fewer) at 11.6ms/batch, 0 violations.
Added an explicit promotion rule (retrieval-neutral within 0.002 AND >=15%
compression AND <250ms/batch AND 0 proxy violations).
- PARAM TABLE / DEFAULT consistency: dedup default is 0.2 everywhere (service,
CLI, daemon). Presets now bracket it: --aggressive 0.3 / --conservative 0.1.
- CAUSAL_EDGES OVERCLAIM: edges now carry an explicit contract
(edge_type=cooccurrence, provenance_tier=proxy:structural, confidence=0.3,
promoted=false) with the rule 'may rank retrieval, must NOT justify
autonomous action'. Also fixed a latent bug: edges linked epId-1 (assumed
consecutive rowids) → now the actual previous episode id.
- EMBEDDING 1:1 invariant enforced: a cluster with no parseable vector is
skipped, so every pattern has exactly one embedding (was off-by-one on a
malformed source vector).
- ADR adds operational invariants + audit SQL, business-value framing, and an
acceptance test.
+2 invariant tests (embedding coverage, edge contract). 32 distill tests green.
Co-Authored-By: RuFlo <ruv@ruv.net>
* feat(hooks): capture edit/task FAILURES, not just successes (ADR-174)
The DB analysis found 898 feedback records — 100% success, 0 failures —
because the post-edit/post-task hooks recorded a hardcoded success:true and
never inspected the tool outcome. With no negative examples the oracle tier
can't teach good-vs-bad, which caps what distillation can learn.
Fix: read Claude Code's PostToolUse tool_response and record the REAL outcome.
- isToolFailure(hookInput): conservative detector (positive error signal only)
— tool_response.is_error / error / success:false, non-zero Bash exit code,
or an error string. Exported + unit-tested (5 cases).
- Generated hook (helpers-generator.ts) + the shipped .claude/helpers/
hook-handler.cjs both inline it: post-edit → recordEdit(file, !toolFailed),
post-task → feedback(!toolFailed) (feedback() already boosts on success /
decays on failure — it was just never called with false).
- intelligence.cjs recordEdit(file, success) persists success to
pending-insights so consolidation/distillation gets the negative example.
The distillation JUDGE (memory-distillation.ts judgeFeedback) already maps
success:false → reward 0 / not-promoted, so the substrate is failure-ready;
this closes the upstream gap that never produced failures.
End-to-end: a failed-edit PostToolUse payload now logs '[LEARN] Edit FAILURE
recorded' through the actual shipped hook; a success stays '[OK] Edit recorded'.
Co-Authored-By: RuFlo <ruv@ruv.net>
* feat(init): version-stamped auto-refresh of critical helpers — hook fixes reach all users, no re-init (ADR-174)
The propagation gap: Claude Code hooks run the PROJECT-LOCAL
.claude/helpers/*.cjs copies, not the npm package — so npx ruflo@latest
never updated them, and users didn't know to re-run init. Any hook fix
(e.g. the ADR-174 failure-capture change) reached only people who happened
to re-init.
Fix: stamp the critical helpers (hook-handler.cjs, intelligence.cjs,
auto-memory-hook.mjs) with the installed CLI version; on the next CLI
command, if a project's stamp is older than the installed version, silently
re-copy them. New lightweight src/init/helper-refresh.ts (fs/path/module
only at load; lazily imports the heavy generators only on the rare
source-unresolvable fallback). Wired AWAITED into index.ts startup so a fast
command can't exit before the copy lands — fast path is a stamp read +
string compare (sub-ms); the copy runs at most once per version bump. No-op
outside a ruflo project (never scaffolds files in an unrelated dir). Skipped
for init/update. executeUpgrade also stamps so an explicit upgrade is current.
Verified end-to-end: a stale-stamped project with an OLD (no-failure-capture)
hook silently upgrades to the toolFailed logic on a plain 'ruflo --help', and
a current project is a no-op (a marker file survives). +4 tests.
Co-Authored-By: RuFlo <ruv@ruv.net>
* feat(security): Ed25519 signed provenance gate for the helper auto-refresh (ADR-174)
The auto-refresh copies auto-EXECUTING hook code from the installed package
into projects. npm verifies the tarball at install, not the files on disk
after — a sibling package's postinstall (or disk tamper) could overwrite the
helpers and the refresh would faithfully propagate the malicious code.
Fix (fail-closed): every helper is verified against a ruflo-signed manifest
before install.
- helper-signing.ts: baked RUFLO_HELPERS_PUBKEY + verifyHelpersManifest()
(native Ed25519, same primitive as rvfa-signing.ts). Fail-closed — any
bad signature / tampered hash / wrong algorithm → null → refuse.
- scripts/sign-helpers.mjs: publish-time signer; private key from
$RUFLO_HELPERS_SIGNING_KEY, NEVER committed (kept out of the repo tree).
Not shipped (scripts/ is narrowed to postinstall.cjs in files).
- helper-refresh.writeCriticalHelpers: verifies the signed manifest + every
source helper's SHA-256 BEFORE copying anything; a mismatch is refused and
the project's existing helpers are left intact. The generator fallback
needs no manifest (it's the CLI's own compiled code = trust root).
- index.ts warns loudly on a blocked refresh (potential tampering signal).
Threat model: closes post-install/on-disk tampering of the helper files; does
not defend a wholesale-compromised CLI (which could swap the baked key too —
but then it owns the binary you run). A CI test ('hashes match shipped files')
fails if a helper changes without re-signing, so a stale manifest can't ship.
Verified end-to-end: a tampered shipped helper → refresh REFUSED (blocked,
project helper untouched); restored → refresh succeeds. +6 signing tests.
Co-Authored-By: RuFlo <ruv@ruv.net>
* chore(security): source helper-signing key from GCP Secret Manager
sign-helpers.mjs now resolves the private key from GCP Secret Manager
(RUFLO_HELPERS_SIGNING_SECRET, via gcloud secrets versions access) as the
preferred source for CI/publish, with the local-PEM fallback
(RUFLO_HELPERS_SIGNING_KEY) for air-gapped signing. Key never committed.
ADR-174 security note updated.
Co-Authored-By: RuFlo <ruv@ruv.net>
Adds a substrate-alignment banner pointing at the published
@claude-flow/browser@3.0.0-alpha.4 npm package + the announcement gist.
The plugin is the user-facing skill layer; npm package is the substrate.
Co-Authored-By: RuFlo <ruv@ruv.net>
Round 1 (alpha.41) added the required --dimension flag to
`ruvector rvf create` but left the equally bogus `--kind browser-session`
in place. ruvector@0.2.25's `rvf create` accepts only:
-d, --dimension <n> (required)
-m, --metric <metric> (optional, default cosine)
Commander's required-option check fires before its unknown-option
check, so the original bug report (#2015) only surfaced the dimension
error. The fresh live regression check after publishing alpha.41
exposed the second-layer bug: `error: unknown option '--kind'`.
This round:
- Strip `--kind browser-session` from all 5 call sites (TS source,
compiled dist via rebuild, replay-spike.sh, browser-agent.md,
browser-record/SKILL.md). Also fixed the ADR prose example.
- Tighten the smoke (scripts/smoke-browser-rvf-create-flags.mjs):
- Switch from rg-based content scan to an explicit PATHS_IN_SCOPE
list (the original `--kind browser-session` anchor is gone, so
we can no longer identify call sites by content).
- Police BOTH invariants per line:
* --dimension / -d is present
* --kind is ABSENT (since ruvector@0.2.25 rejects it)
- Skip quoted-string false positives ('rvf create failed' log lines).
Versions:
@claude-flow/cli 3.7.0-alpha.42
claude-flow 3.7.0-alpha.42
ruflo 3.7.0-alpha.42
@claude-flow/memory 3.0.0-alpha.16 (unchanged, #2019 fix already live)
Post-publish live functional check (everything green):
- ruvector rvf create --dimension 384 (no --kind): exit 0, .rvf file
written. Reproduces what the MCP tool now invokes.
- Published CLI dist:113 carries '--dimension','384', no --kind.
- #2019 vectorBackend / graphAdapter functional test from
alpha.41 still passes against published memory@3.0.0-alpha.16.
- verify.mjs precondition contract still holds.
Co-Authored-By: RuFlo <ruv@ruv.net>
Three small but recurring bugs ship together because they share the
same anti-pattern: a try/catch (or a missing flag) silently turned a
clear precondition failure into a vague "verification failed" /
"controller disabled" / "rvf create failed" outcome that downstream
consumers couldn't act on.
#1880 — witness verify exits 1 on source-only checkouts
- The 12h scheduled verification has been filing a duplicate
"HIGH — verification broken" issue every cron run since 2026-05-10
because the runner does a source-only checkout (no @noble/ed25519
install, no `npm run build`) and verify.mjs lumped that into the
same exit-1 bucket as a real signature regression.
- verify.mjs now reserves exit 2 strictly for precondition misses:
* @noble/ed25519 not installed → exit 2
* every manifest entry missing AND manifest → exit 2
references /dist/ paths (= "dist not built")
Real failures (signature invalid, specific marker regressed)
keep exit 1. The scheduled runner can now distinguish
"needs install/build" from "we broke something".
- New CI guard: scripts/smoke-witness-verify-precondition.mjs
drives all three shapes (missing dep, all-files-missing,
built tree) and asserts the exit code contract.
- Wired into v3-ci.yml as witness-verify-precondition-smoke and
into witness-verify's `needs:` so a contract break blocks publish.
#2019 — vectorBackend controller permanently disabled
- @claude-flow/memory's controller-registry.ts calls
agentdb.getController('vectorBackend'). agentdb@3.0.0-alpha.14's
getController switch only handles memory/reflexion/skills/causal
and throws `Unknown controller: vectorBackend` for everything else
— silently swallowed, leaving the controller `enabled: false`
even though `agentdb.vectorBackend` is a real field on the
instance (assigned in AgentDB.initialize()).
- Registry now probes `agentdb[name]` directly first, falls back to
getController only when the field is absent. Applied to all three
accessor paths (initializeController, get, isEnabled).
- RuntimeConfig gains an optional `agentdb` injection field so
tests and consumers with a pre-built AgentDB can govern it via
the registry.
- Two new tests in controller-registry.test.ts cover both branches
(direct property wins; falls back to getController when absent).
- Full controller-registry suite stays green (67 tests).
#2015 — ruflo-browser session_record fails every call
- ruvector@0.2.25 makes `-d, --dimension <n>` required on
`rvf create`. The browser_session_record MCP tool wrapper invoked
`rvf create … --kind browser-session` WITHOUT the flag, so every
call returned `{ success: false, error: "rvf create failed" }`.
- All five call sites updated to pass `--dimension 384` (matches
MiniLM-L6 / AgentDB index default):
v3/@claude-flow/cli/src/mcp-tools/browser-session-tools.ts
plugins/ruflo-browser/scripts/replay-spike.sh
plugins/ruflo-browser/agents/browser-agent.md
plugins/ruflo-browser/skills/browser-record/SKILL.md
plugins/ruflo-browser/docs/adrs/0001-browser-skills-architecture.md
- New CI guard: scripts/smoke-browser-rvf-create-flags.mjs
statically scans every `rvf create … --kind browser-session`
invocation across the repo (TS, dist, shell, markdown) and
fails if any is missing --dimension / -d.
- Wired into v3-ci.yml as browser-rvf-create-flags-smoke and into
witness-verify's `needs:` so a regression blocks publish.
Cases covered by guards: source-only checkout (no deps), source-only
checkout with build, built tree, missing dimension flag on TS/dist/
shell/markdown call sites. The smokes are independent jobs so the CI
summary names the specific contract that broke.
Co-Authored-By: RuFlo <ruv@ruv.net>
Followup to ADR-118. Three plugin READMEs amended to describe what
the upstream aidefence@2.3.0 / aimds-*@0.1.1 release improves in
their existing 3-gate flows:
• ruflo-aidefence: new "What the gates catch" table — prompt
injection (0..4 modifier window), role hijack, jailbreak
markers; aidefence_stats counters now accurate.
• ruflo-browser: AIDefence Gate 3 (Prompt-injection check) note
that scraped-content scans now flag role-hijack + jailbreak
in addition to the canonical `ignore all previous
instructions` family.
• ruflo-federation: 3-gate alignment block extended with a
paragraph that the inbound aidefence_is_safe gate's wider
detection runs through the adaptive confidence calibration
automatically — no plugin code change needed.
No semantic change to the plugins themselves. Pure documentation
of behavior the 2.3.0 bump already provides through the unchanged
MCP-tool surface.
Co-authored-by: Reuven <cohen@ruv-mac-mini.local>
ruv