Files
ruflo/scripts/smoke-wasm-rvf-compose.mjs
rUvandRuFlo 47a7825b0e feat(rvagent): #ADR-129 — full rvagent integration (4 phases) (#2123)
* docs(adr): ADR-129 — rvagent full integration (4 phases, post-3.7.0 baseline)

Proposes a 4-phase integration of @ruvector/rvagent-wasm@0.1.0 to make
WasmAgents first-class participants in the ruflo swarm.

## Gaps found in current code (verified by deep-researcher)

- agent-wasm.ts:165-196 — echo-stub bypass (JsModelProvider never
  constructed; verified by `grep -rn 'new JsModelProvider'` returns 0
  hits). WasmAgent.prompt() either echoes or hits a default — not
  routed through the v3 provider system from #2042.
- agent-wasm.ts:420-429 — buildRvfFromTemplate silently drops
  template.mcp_tools, so wasm_gallery_create can't surface MCP tools
  to the agent.
- 10 of 13 gallery methods unexposed (loadRvf, configure, getCategories,
  listByCategory, addCustom, removeCustom, importCustom, exportCustom,
  getActive, getConfig).
- 6 agent introspection methods unexposed (get_state, get_todos,
  get_tools, turn_count, is_stopped, reset).
- No bridge from any of the 35 ruflo plugins to the WASM agent runtime.

## 4 phases

| Phase | What | Smoke |
|---|---|---|
| 1 | JsModelProvider → callAnthropicMessages bridge | smoke-wasm-provider-bridge.mjs |
| 2 | wasm_agent_compose + addMcpTools bridge (314 tools) | smoke-wasm-rvf-compose.mjs |
| 3 | 16 new MCP tools (gallery CRUD + introspection) | smoke-wasm-gallery-crud.mjs |
| 4 | Plugin bridge contract | smoke-wasm-plugin-bridge.mjs |

## Top 3 risks

1. Billing expansion — Phase 1 turns wasm_agent_prompt into billable
   LLM calls (was echo).
2. addMcpTools over-permissioning — Phase 2 default must be explicit
   allowlist, not full dump (314 tools include destructive ones like
   memory_delete, federation_*).
3. importCustom prompt-injection — Phase 3 deserializes user JSON in
   the WASM runtime; AIDefence gate required.

No phase needs a separate ADR. Anchored in #2042 (provider routing),
ADR-115 (rvagent rename), ADR-127 (smoke pattern).

Co-Authored-By: RuFlo <ruflo-bot@users.noreply.github.com>

* feat(rvagent): #ADR-129 P1 — JsModelProvider routes WasmAgent through v3 provider system

Wire set_model_provider() at agent-creation time so the WASM runtime's
internal conversation loop dispatches through callAnthropicMessages
(Anthropic / OpenRouter / Ollama, same routing as agent_execute #2042).
Echo-stub fallback preserved for keyless environments.  Smoke +
CI job added: smoke-wasm-provider-bridge.mjs / wasm-provider-bridge-smoke.

Co-Authored-By: RuFlo <ruv@ruv.net>

* feat(rvagent): #ADR-129 P2 — wasm_agent_compose + addMcpTools bridge (314-tool unlock with allowlist gate)

Fix silent drop of template.mcp_tools in buildRvfFromTemplate; extend
buildRvfContainer to accept mcpTools param → builder.addMcpTools().
Add wasm_agent_compose MCP tool with explicit allowlist, destructive-tool
gate (mcpToolsAllowDestructive required for *_delete/*_shutdown/federation_*),
and includePlugins P4 wire.  Smoke + CI job: smoke-wasm-rvf-compose.mjs.

Co-Authored-By: RuFlo <ruv@ruv.net>

* feat(rvagent): #ADR-129 P3 — 16 new MCP tools (10 gallery CRUD + 6 introspection) with AIDefence gate on import

Add wasm_gallery_load_rvf, configure, categories, list_by_category,
add_custom, remove_custom, import (HIGH_RISK + AIDefence gate), export,
active, config.  Add wasm_agent_state, todos, tools, turn_count,
is_stopped, reset.  Export 10 new functions from agent-wasm.ts.
Smoke + CI job: smoke-wasm-gallery-crud.mjs.

Co-Authored-By: RuFlo <ruv@ruv.net>

* feat(rvagent): #ADR-129 P4 — plugin manifest "rvagent" field + includePlugins in compose

Add loadPluginManifest() + extractPluginSkills() to wasm-agent-tools.ts.
wasm_agent_compose gains includePlugins?: string[] — reads each plugin's
.claude-plugin/plugin.json, parses rvagent.exposeSkillsAsTools, and adds
matching skills to the RVF container.  Unknown plugin name → warning,
not error.  Smoke + CI job: smoke-wasm-plugin-bridge.mjs.

Co-Authored-By: RuFlo <ruv@ruv.net>

* fix(ci): #2120 — memory smoke uses pnpm (workspace: protocol unsupported by npm)

The memory-stats-legacy-db-smoke job hit `EUNSUPPORTEDPROTOCOL:
Unsupported URL Type "workspace:"` in CI because `cd v3/@claude-flow/cli
&& npm install` ran against a package.json with workspace:* deps that
only pnpm understands. Same pattern as the agent-execute smoke fix.

Switch the job to pnpm/action-setup + `pnpm install` + `pnpm --filter
@claude-flow/cli build`. The smoke logic is unchanged.

Co-Authored-By: RuFlo <ruflo-bot@users.noreply.github.com>

* fix(rvagent): #ADR-129 — pad 16 new wasm tool descriptions to ADR-112 spec (>=80 chars + Use-when guidance)

Co-Authored-By: RuFlo <ruv@ruv.net>

* feat(rvagent): #ADR-129 — benchmark suite (provider routing, compose, gallery CRUD, plugin enum)

Co-Authored-By: RuFlo <ruv@ruv.net>

* feat(witness): #ADR-103 — register ADR-129 P1-P4 fixes in witness manifest

Co-Authored-By: RuFlo <ruv@ruv.net>

* fix(ci): #2120 — pnpm install must run from v3/ (workspace root)

My prior fix (2d2091fe7) ran `pnpm install` at repo root, but the
pnpm-workspace.yaml lives in v3/, not at the root. Result: no
node_modules under v3/@claude-flow/cli, tsc errored on missing
@types/node, build never produced dist.

Mirror the working pattern used elsewhere in this workflow:
`working-directory: v3` + `pnpm install` + `pnpm --filter
@claude-flow/cli build`. Keep the root `npm install` for sql.js
which the smoke fixture imports from the repo root.

Co-Authored-By: RuFlo <ruflo-bot@users.noreply.github.com>

* fix(ci): #2120 — recursive build (CLI tsc depends on swarm dist)

Previous fix (cec3cef48) installed correctly from v3/ but the CLI's tsc
emits TS6305 because it has project references to @claude-flow/swarm
and its dist hasn't been produced yet. `pnpm --filter @claude-flow/cli
build` only builds that one package and skips deps.

Switch to `pnpm --recursive --no-bail run build || true` — the proven
pattern used elsewhere in this workflow — then assert the specific dist
file the smoke imports (`dist/src/memory/memory-initializer.js`).

Co-Authored-By: RuFlo <ruflo-bot@users.noreply.github.com>

* fix(memory): #2120 — getBridge honors CLAUDE_FLOW_DISABLE_BRIDGE=1

The #2120 smoke sets `CLAUDE_FLOW_DISABLE_BRIDGE=1` to force the raw
sql.js fallback path of `listEntries`, because the ensureSchemaColumns
backfill (NULL status → 'active') only runs in that fallback —
bridgeListEntries reads via a separate better-sqlite3 handle and skips
the migration.

`getBridge()` ignored that env var, so on CI Linux (where better-sqlite3
builds successfully) the bridge took over `listEntries`, the backfill
never ran, and the smoke's step-4 verification (reading the file with
plain sql.js) saw status=NULL on all rows and reported 0 active. The
test passed on macOS only because the bridge happened to fail to
initialize locally.

Honor the env var: when set to "1", short-circuit getBridge() before any
import attempt. Same value the smoke already sets — no other call site
relies on this flag, so the change is non-breaking.

Co-Authored-By: RuFlo <ruflo-bot@users.noreply.github.com>

---------

Co-authored-by: RuFlo <ruflo-bot@users.noreply.github.com>
2026-05-24 14:32:43 -04:00

103 lines
4.2 KiB
JavaScript

#!/usr/bin/env node
/**
* Regression guard for ADR-129 Phase 2 — wasm_agent_compose MCP tool
* + addMcpTools bridge.
*
* Pre-P2: buildRvfFromTemplate silently dropped template.mcp_tools (the
* field existed in GalleryTemplateDetail but was never passed to
* WasmRvfBuilder.addMcpTools()). No wasm_agent_compose tool existed.
* WasmAgents were isolated from ruflo's 314 MCP tools.
*
* P2 fix:
* 1. buildRvfContainer gains mcpTools parameter → builder.addMcpTools()
* 2. buildRvfFromTemplate passes template.mcp_tools
* 3. wasm_agent_compose MCP tool added with allowlist + destructive gate
*
* Static contracts (no build required):
* 1. wasm-agent-tools.ts MUST contain wasm_agent_compose tool
* 2. Destructive-tool gate must reference mcpToolsAllowDestructive
* 3. DESTRUCTIVE_TOOL_PATTERNS must be defined
* 4. agent-wasm.ts buildRvfFromTemplate must pass mcpTools field
* 5. buildRvfContainer must call builder.addMcpTools
* 6. includePlugins param exists in wasm_agent_compose schema (P4 wire)
*/
import { readFileSync } from 'node:fs';
import { fileURLToPath } from 'node:url';
import { dirname, resolve } from 'node:path';
const __dirname = dirname(fileURLToPath(import.meta.url));
const TOOLS = resolve(__dirname, '../v3/@claude-flow/cli/src/mcp-tools/wasm-agent-tools.ts');
const WASM = resolve(__dirname, '../v3/@claude-flow/cli/src/ruvector/agent-wasm.ts');
function fail(msg) { console.error(`✗ ${msg}`); process.exitCode = 1; }
function pass(msg) { console.log(`✓ ${msg}`); }
const toolsSrc = readFileSync(TOOLS, 'utf8');
const wasmSrc = readFileSync(WASM, 'utf8');
// 1. wasm_agent_compose tool registered
if (!/name:\s*['"]wasm_agent_compose['"]/.test(toolsSrc)) {
fail('wasm_agent_compose tool not registered — ADR-129 P2 tool missing');
} else {
pass('wasm_agent_compose tool registered');
}
// 2. Destructive-tool gate present
if (!/mcpToolsAllowDestructive/.test(toolsSrc)) {
fail('mcpToolsAllowDestructive not found — destructive-tool gate missing');
} else {
pass('mcpToolsAllowDestructive gate present in wasm_agent_compose');
}
// 3. DESTRUCTIVE_TOOL_PATTERNS defined
if (!/DESTRUCTIVE_TOOL_PATTERNS/.test(toolsSrc)) {
fail('DESTRUCTIVE_TOOL_PATTERNS not defined — allowlist enforcement absent');
} else {
pass('DESTRUCTIVE_TOOL_PATTERNS defined — destructive tools blocked by default');
}
// 4. buildRvfFromTemplate passes mcp_tools (ADR-129 P2 fix)
const buildFromTplFn = wasmSrc.match(/export async function buildRvfFromTemplate[\s\S]*?\n\}/);
if (!buildFromTplFn) {
fail('buildRvfFromTemplate not found');
} else if (!/mcp_tools/.test(buildFromTplFn[0]) && !/mcpTools/.test(buildFromTplFn[0])) {
fail('buildRvfFromTemplate does not pass mcp_tools — silent drop still present (#ADR-129 P2 regression)');
} else {
pass('buildRvfFromTemplate passes mcp_tools to buildRvfContainer (drop fixed)');
}
// 5. buildRvfContainer source contains addMcpTools call
// (search the whole file between buildRvfContainer and buildRvfFromTemplate)
const between = wasmSrc.slice(
wasmSrc.indexOf('export async function buildRvfContainer'),
wasmSrc.indexOf('export async function buildRvfFromTemplate'),
);
if (!between || between.length === 0) {
fail('buildRvfContainer function region not found');
} else if (!/addMcpTools/.test(between)) {
fail('buildRvfContainer does not call builder.addMcpTools() — MCP tool bridge missing');
} else {
pass('buildRvfContainer calls builder.addMcpTools() — 314-tool bridge wired');
}
// 6. includePlugins param in wasm_agent_compose (P4 contract)
if (!/includePlugins/.test(toolsSrc)) {
fail('includePlugins param not found in wasm_agent_compose — ADR-129 P4 schema missing');
} else {
pass('includePlugins param present in wasm_agent_compose (P4 plugin bridge)');
}
// 7. isDestructiveTool helper guards known patterns
if (!/memory_delete|federation_|swarm_shutdown|agent_terminate/.test(toolsSrc)) {
fail('Destructive pattern guards missing from allowlist');
} else {
pass('Destructive pattern guards cover memory_delete, federation_*, swarm_shutdown, agent_terminate');
}
if (process.exitCode) {
console.error('\nADR-129 P2 wasm_agent_compose smoke FAILED');
} else {
console.log('\nADR-129 P2 wasm_agent_compose smoke PASS');
}