Files
tailscale/feature/conn25
Mazdak Nasab 4f19a4aff8 feature/conn25: reject Magic IPs whose Transit IP isn't in WireGuard yet (#22374)
A Magic IP gets its address assignment when the DNS response is rewritten,
but the Transit IP it maps to only becomes usable later: handleAddressAssignment
registers it with the connector over PeerAPI, and only then does
addTransitIPForConnector put it in byConnKey, where extraWireGuardAllowedIPs
picks it up and hands it to WireGuard as an allowed IP for that peer.

Until then, transitIPForMagicIP would happily return the Transit IP, the
datapath would DNAT to it, and WireGuard would drop the packet because no
peer claims the address. The client application saw a black hole and hung.
That window stays open indefinitely when the registration never lands: a
failed PeerAPI request, a full assignment queue, or a reset that clears
byConnKey.

transitIPForMagicIP now checks that the Transit IP is registered under its
connector's node key, and returns the new ErrTransitIPNotRoutable if it
isn't. The datapath treats that like an unknown Magic IP and injects an
ICMP host unreachable, so the application fails fast instead of hanging.

Fixes https://github.com/tailscale/corp/issues/50405

Change-Id: Id232e27063f27278e65279d9b1adad5d67d3b6ef

Signed-off-by: Mazdak Nasab <mazdak.nasab@gmail.com>
2026-11-17 15:10:44 -07:00
..