mirror of
https://github.com/tailscale/tailscale.git
synced 2026-11-21 20:22:41 +09:00
When a Serve or Funnel handler serves a path, serveFileOrDirectory used os.Stat and os.Open on it, and http.FileServer(http.Dir(dir)) for a directory. All of these follow symlinks, so a symlink in place of a served file or directory, or inside a served directory, could make tailscaled serve any file it can read from elsewhere on the host. Those directories may be writable by local users who can't configure Serve, and a symlink placed there is followed at request time. Resolve the configured path through an os.Root of its parent directory, and serve a directory through an os.Root of its own. os.Root refuses symlinks whose target leaves the root, and absolute symlinks, and still follows relative symlinks that stay inside it. A refused path inside a served directory is reported as not found, like a missing file. A refused configured path is logged and reported as a server error, like other errors reading it. This changes behavior for setups that serve such symlinks on purpose, including absolute symlinks and Windows junctions: a configured file or directory that is one, or that points out of its parent directory, now fails, and such links inside a served directory now return 404. Symlinks higher up the configured path are still followed, and a filesystem root can still be served. Opening the parent directory needs read permission on it, where os.Stat only needed search permission. Hardlinks are not covered, since os.Root can't tell them apart from regular files. RELNOTE: tailscale serve stops following symlinks out of served directories Updates tailscale/corp#51116 Signed-off-by: Aditya Merchant <adityamerchant08@gmail.com>