mirror of
https://github.com/tailscale/tailscale.git
synced 2026-11-22 12:42:42 +09:00
flowRemoved identified an address assignment by transit IP alone, but a transit IP does not identify an assignment for the lifetime of a flow. An assignment can be dropped while a flow created against it is still in the client flow table, and the pools then hand the same transit IP back out to an unrelated assignment. The stale removal was charged to that stranger, dropping its activeFlowCount while its own flows were still forwarding, so popExpired reclaimed both of its addresses back to the pools mid-connection. If the stranger had no flows of its own the count went to -1, which can never again satisfy popExpired's zero-flow test, pinning it in the expiry heap and leaking both addresses for the life of the process. flowCreated now returns a function, which the datapath calls on removal to clean up the flow. Fixes https://github.com/tailscale/corp/issues/50760 Change-Id: I3693c487b1031737763b5e49f8f8400c72848e8e Signed-off-by: Mazdak Nasab <mazdak.nasab@gmail.com>