From 27dc15e63e960a42eebcd2c06fa872e14d0c96fa Mon Sep 17 00:00:00 2001 From: Oleg Isonen Date: Fri, 23 Dec 2022 14:27:51 +0000 Subject: [PATCH] Remove unused components, deprecate components consistently (#683) ## Description 1. Remove unused components, some of which will be reintroduced once we start using them with designed styles, right now its confusing because they were copied from modulz example repo and never adjusted with our design system 2. Deprecated consistently ## Code Review - [ ] hi @istarkov , I need you to do - conceptual review (architecture, feature-correctness) ## Before requesting a review - [x] made a self-review - [x] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [x] tested locally and on preview environment (preview dev login: 5de6) - [x] updated [test cases](https://github.com/webstudio-is/webstudio-designer/blob/main/apps/designer/docs/test-cases.md) document - [x] added tests - [x] if any new env variables are added, added them to `.env.example` and the `designer/env-check.js` if mandatory --- apps/designer/app/auth/login.tsx | 4 +- .../app/dashboard/components/card.tsx | 6 +- .../features/props-panel/props-panel.tsx | 6 +- .../features/sidebar-left/lib/header.tsx | 6 +- .../sidebar-left/panels/pages/pages.tsx | 8 +- .../sidebar-left/panels/pages/settings.tsx | 14 +- .../controls/toggle/toggle-control.tsx | 6 +- .../sections/layout/shared/flex-grid.tsx | 6 +- .../sections/layout/shared/lock.tsx | 6 +- .../sections/typography/typography.tsx | 6 +- .../designer/features/topbar/menu/menu.tsx | 6 +- .../app/designer/features/topbar/preview.tsx | 6 +- .../app/designer/features/topbar/share.tsx | 6 +- .../design-tokens-manager/item-menu.tsx | 4 +- .../shared/fonts-manager/item-menu.tsx | 4 +- .../{ => __DEPRECATED__}/heading.tsx | 8 +- .../icon-button.tsx} | 4 +- .../src/components/accordion.tsx | 102 ---- .../src/components/alert-dialog.tsx | 53 -- .../design-system/src/components/alert.tsx | 49 -- .../design-system/src/components/app-bar.tsx | 97 ---- .../design-system/src/components/badge.tsx | 456 ------------------ .../design-system/src/components/banner.tsx | 80 --- .../design-system/src/components/code.tsx | 24 - .../design-system/src/components/combobox.tsx | 6 +- .../src/components/container.tsx | 32 -- .../src/components/context-menu.tsx | 102 ---- .../src/components/control-group.tsx | 103 ---- .../design-system/src/components/dialog.tsx | 82 ---- .../src/components/icon-button-with-menu.tsx | 6 +- .../design-system/src/components/image.tsx | 7 - packages/design-system/src/components/kbd.tsx | 87 ---- .../design-system/src/components/overlay.tsx | 7 - .../design-system/src/components/popover.tsx | 6 +- .../src/components/progress-bar.tsx | 98 ---- .../src/components/radio-card.tsx | 74 --- .../src/components/radio-grid.tsx | 36 -- .../src/components/scrollbar.tsx | 209 -------- .../src/components/search-field.tsx | 4 +- .../design-system/src/components/section.tsx | 32 -- .../design-system/src/components/sheet.tsx | 142 ------ .../design-system/src/components/skeleton.tsx | 80 --- packages/design-system/src/components/sub.tsx | 8 - packages/design-system/src/components/sup.tsx | 8 - .../design-system/src/components/tab-link.tsx | 43 -- .../design-system/src/components/table.tsx | 108 ----- .../src/components/text-field.stories.tsx | 22 +- .../src/components/toggle-group.tsx | 2 +- .../{simple-toggle.tsx => toggle.tsx} | 2 +- .../design-system/src/components/tooltip.tsx | 90 ++-- .../src/components/verified-badge.tsx | 30 -- packages/design-system/src/index.ts | 12 +- 52 files changed, 127 insertions(+), 2278 deletions(-) rename packages/design-system/src/components/{ => __DEPRECATED__}/heading.tsx (89%) rename packages/design-system/src/components/{icon-button-deprecated.tsx => __DEPRECATED__/icon-button.tsx} (93%) delete mode 100644 packages/design-system/src/components/accordion.tsx delete mode 100644 packages/design-system/src/components/alert-dialog.tsx delete mode 100644 packages/design-system/src/components/alert.tsx delete mode 100644 packages/design-system/src/components/app-bar.tsx delete mode 100644 packages/design-system/src/components/badge.tsx delete mode 100644 packages/design-system/src/components/banner.tsx delete mode 100644 packages/design-system/src/components/code.tsx delete mode 100644 packages/design-system/src/components/container.tsx delete mode 100644 packages/design-system/src/components/context-menu.tsx delete mode 100644 packages/design-system/src/components/control-group.tsx delete mode 100644 packages/design-system/src/components/dialog.tsx delete mode 100644 packages/design-system/src/components/image.tsx delete mode 100644 packages/design-system/src/components/kbd.tsx delete mode 100644 packages/design-system/src/components/overlay.tsx delete mode 100644 packages/design-system/src/components/progress-bar.tsx delete mode 100644 packages/design-system/src/components/radio-card.tsx delete mode 100644 packages/design-system/src/components/radio-grid.tsx delete mode 100644 packages/design-system/src/components/scrollbar.tsx delete mode 100644 packages/design-system/src/components/section.tsx delete mode 100644 packages/design-system/src/components/sheet.tsx delete mode 100644 packages/design-system/src/components/skeleton.tsx delete mode 100644 packages/design-system/src/components/sub.tsx delete mode 100644 packages/design-system/src/components/sup.tsx delete mode 100644 packages/design-system/src/components/tab-link.tsx delete mode 100644 packages/design-system/src/components/table.tsx rename packages/design-system/src/components/{simple-toggle.tsx => toggle.tsx} (95%) delete mode 100644 packages/design-system/src/components/verified-badge.tsx diff --git a/apps/designer/app/auth/login.tsx b/apps/designer/app/auth/login.tsx index aa4153222c..f376d1b5c7 100644 --- a/apps/designer/app/auth/login.tsx +++ b/apps/designer/app/auth/login.tsx @@ -4,7 +4,7 @@ import { useState } from "react"; import { Card, Flex, - Heading, + DeprecatedHeading, Button, Text, TextField, @@ -45,7 +45,7 @@ export const Login = ({ errorMessage }: { errorMessage: string }) => { > - Login + Login {errorMessage.length ? ( diff --git a/apps/designer/app/dashboard/components/card.tsx b/apps/designer/app/dashboard/components/card.tsx index 8c8aed83a8..b86f478740 100644 --- a/apps/designer/app/dashboard/components/card.tsx +++ b/apps/designer/app/dashboard/components/card.tsx @@ -7,7 +7,7 @@ import { Select, TextField, Button, - Heading, + DeprecatedHeading, Text, } from "@webstudio-is/design-system"; import { designerPath } from "~/shared/router-utils"; @@ -35,9 +35,9 @@ export const SelectProjectCard = ({ return ( - + Select a project - +