From 24ea4f8dae0e9bf33da14c46d2195499459dc246 Mon Sep 17 00:00:00 2001 From: Oleg Isonen Date: Sun, 11 Dec 2022 14:10:54 +0000 Subject: [PATCH 1/2] with more text button was becoming larger even though the layout has a constraint --- packages/design-system/src/components/text-field.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/design-system/src/components/text-field.tsx b/packages/design-system/src/components/text-field.tsx index 121c6f6ad6..be7b65130e 100644 --- a/packages/design-system/src/components/text-field.tsx +++ b/packages/design-system/src/components/text-field.tsx @@ -148,6 +148,7 @@ const TextFieldBase = styled("div", { fontSize: "$fontSize$3", height: 28, // @todo waiting for the sizing scale lineHeight: 1, + overflow: "hidden", "&:focus-within": { boxShadow: "inset 0px 0px 0px 1px $colors$blue10, 0px 0px 0px 1px $colors$blue10", From 1a7a7381b4ea8c84c34213a21ec3874cfde698d2 Mon Sep 17 00:00:00 2001 From: Oleg Isonen Date: Sun, 11 Dec 2022 14:45:07 +0000 Subject: [PATCH 2/2] minWidth also fixes the problem with disrespecting layout contraint --- packages/design-system/src/components/text-field.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/design-system/src/components/text-field.tsx b/packages/design-system/src/components/text-field.tsx index be7b65130e..ebff406e6a 100644 --- a/packages/design-system/src/components/text-field.tsx +++ b/packages/design-system/src/components/text-field.tsx @@ -148,7 +148,7 @@ const TextFieldBase = styled("div", { fontSize: "$fontSize$3", height: 28, // @todo waiting for the sizing scale lineHeight: 1, - overflow: "hidden", + minWidth: 0, "&:focus-within": { boxShadow: "inset 0px 0px 0px 1px $colors$blue10, 0px 0px 0px 1px $colors$blue10",