From 86357c84746f42e3cc69394dd2011bd8cd6afb59 Mon Sep 17 00:00:00 2001 From: Oleg Isonen Date: Wed, 5 Aug 2026 10:17:15 +0100 Subject: [PATCH] fix: omit raw format from direct image URLs --- .../text-file-editor/markdown-preview.test.tsx | 8 ++------ packages/cli/src/asset-files.test.ts | 4 +--- packages/cli/src/prebuild.test.ts | 2 +- packages/sdk/src/assets.test.ts | 12 +++++------- packages/sdk/src/assets.ts | 2 +- 5 files changed, 10 insertions(+), 18 deletions(-) diff --git a/apps/builder/app/builder/features/text-file-editor/markdown-preview.test.tsx b/apps/builder/app/builder/features/text-file-editor/markdown-preview.test.tsx index 479117280d..19daedba1c 100644 --- a/apps/builder/app/builder/features/text-file-editor/markdown-preview.test.tsx +++ b/apps/builder/app/builder/features/text-file-editor/markdown-preview.test.tsx @@ -36,12 +36,8 @@ test("resolves asset IDs and relative paths in Markdown images and links", () => origin: "https://builder.example", }); - expect(html).toContain( - 'src="https://builder.example/cgi/image/image.png?format=raw"' - ); - expect(html).toContain( - 'href="https://builder.example/cgi/image/image.png?format=raw"' - ); + expect(html).toContain('src="https://builder.example/cgi/image/image.png"'); + expect(html).toContain('href="https://builder.example/cgi/image/image.png"'); expect(html).toContain('src="https://example.com/image.png"'); }); diff --git a/packages/cli/src/asset-files.test.ts b/packages/cli/src/asset-files.test.ts index 01f96a1790..e62bf70db4 100644 --- a/packages/cli/src/asset-files.test.ts +++ b/packages/cli/src/asset-files.test.ts @@ -136,9 +136,7 @@ test("downloads asset files when they are missing from the synced asset cache", await expect(readFile("public/assets/image.png", "utf8")).resolves.toBe( "downloaded" ); - expect(fetch).toHaveBeenCalledWith( - "https://example.com/cgi/image/image.png?format=raw" - ); + expect(fetch).toHaveBeenCalledWith("https://example.com/cgi/image/image.png"); }); test("retries asset download once after a server error", async () => { diff --git a/packages/cli/src/prebuild.test.ts b/packages/cli/src/prebuild.test.ts index e3f2250791..eed1b27822 100644 --- a/packages/cli/src/prebuild.test.ts +++ b/packages/cli/src/prebuild.test.ts @@ -2558,7 +2558,7 @@ describe("prebuild", () => { template: ["defaults"], }); expect(fetch).toHaveBeenCalledWith( - "https://assets.example/cgi/image/image.png?format=raw" + "https://assets.example/cgi/image/image.png" ); expect(consoleWarn).not.toHaveBeenCalled(); expect(consoleError).toHaveBeenCalledWith( diff --git a/packages/sdk/src/assets.test.ts b/packages/sdk/src/assets.test.ts index 9f17c01165..8cc9bf0c88 100644 --- a/packages/sdk/src/assets.test.ts +++ b/packages/sdk/src/assets.test.ts @@ -593,11 +593,9 @@ describe("allowed-file-types", () => { test("generates correct URL for image assets", () => { const url = getAssetUrl(mockImageAsset, "https://example.com"); - expect(url.href).toBe( - "https://example.com/cgi/image/photo.jpg?format=raw" - ); + expect(url.href).toBe("https://example.com/cgi/image/photo.jpg"); expect(url.pathname).toBe("/cgi/image/photo.jpg"); - expect(url.search).toBe("?format=raw"); + expect(url.search).toBe(""); }); test.each(["bmp", "ico", "avif"])( @@ -1048,7 +1046,7 @@ describe("allowed-file-types", () => { test("converts image asset with all fields", () => { const result = toRuntimeAsset(mockImageAsset, "https://example.com"); expect(result).toEqual({ - url: "/cgi/image/photo.jpg?format=raw", + url: "/cgi/image/photo.jpg", width: 1920, height: 1080, }); @@ -1086,8 +1084,8 @@ describe("allowed-file-types", () => { const result1 = toRuntimeAsset(mockImageAsset, "https://cdn.example.com"); const result2 = toRuntimeAsset(mockImageAsset, "http://localhost:3000"); // Both should return the same relative URL - expect(result1.url).toBe("/cgi/image/photo.jpg?format=raw"); - expect(result2.url).toBe("/cgi/image/photo.jpg?format=raw"); + expect(result1.url).toBe("/cgi/image/photo.jpg"); + expect(result2.url).toBe("/cgi/image/photo.jpg"); }); test("handles image without dimensions", () => { diff --git a/packages/sdk/src/assets.ts b/packages/sdk/src/assets.ts index c948c96f12..388d7f720f 100644 --- a/packages/sdk/src/assets.ts +++ b/packages/sdk/src/assets.ts @@ -543,7 +543,7 @@ export const getAssetUrl = ( origin: string ): URL => { const path = isResizableImageFileName(asset.name) - ? `/cgi/image/${asset.name}?format=raw` + ? `/cgi/image/${asset.name}` : `/cgi/asset/${asset.name}?format=raw`; return new URL(path, origin); };