From 8febda5eee8a43191200a811d04261925700cb28 Mon Sep 17 00:00:00 2001
From: Roman Pominov <rpominov+github@gmail.com>
Date: Mon, 17 Oct 2022 08:52:26 +0400
Subject: [PATCH] move InputErrorsTooltip to design-system

---
 .../sidebar-left/panels/pages/settings.tsx    | 36 ++++---------------
 .../design-system/src/components/tooltip.tsx  | 28 +++++++++++++++
 packages/design-system/src/index.ts           |  2 +-
 3 files changed, 35 insertions(+), 31 deletions(-)

diff --git a/apps/designer/app/designer/features/sidebar-left/panels/pages/settings.tsx b/apps/designer/app/designer/features/sidebar-left/panels/pages/settings.tsx
index 08ac6ba4d9..fa855bb586 100644
--- a/apps/designer/app/designer/features/sidebar-left/panels/pages/settings.tsx
+++ b/apps/designer/app/designer/features/sidebar-left/panels/pages/settings.tsx
@@ -8,13 +8,13 @@ import {
   styled,
   Flex,
   toast,
-  Tooltip,
+  InputErrorsTooltip,
 } from "@webstudio-is/design-system";
 import { useFetcher, type FetcherWithComponents } from "@remix-run/react";
 import { ChevronDoubleLeftIcon } from "@webstudio-is/icons";
 import type { ZodError } from "zod";
 import { BaseHeader } from "../../lib/header";
-import React, { useEffect, useRef, useState } from "react";
+import { useEffect, useRef, useState } from "react";
 import { type Page } from "@webstudio-is/project";
 
 const Group = styled(Flex, {
@@ -27,30 +27,6 @@ export type CreatePageData =
   | { ok: true; page: Page }
   | { errors: string | ZodError["formErrors"] };
 
-const ErrorsTooltip = ({
-  errors,
-  children,
-}: {
-  errors: string[] | undefined;
-  children: React.ComponentProps<typeof Tooltip>["children"];
-}) => {
-  const content = errors?.map((error, i) => (
-    <React.Fragment key={i}>
-      {i > 0 && <br />}
-      {error}
-    </React.Fragment>
-  ));
-  return (
-    // We intentionally always pass non empty content to avoid optimization inside Tooltip
-    // where it renders {children} directly if content is empty.
-    // If this optimization accur, the <TextField> will remount which will cause focus loss
-    // and current value loss.
-    <Tooltip content={content || " "} open={errors !== undefined} side="right">
-      {children}
-    </Tooltip>
-  );
-};
-
 export const NewPageSettings = ({
   onClose,
   onSuccess,
@@ -120,7 +96,7 @@ export const NewPageSettings = ({
             <Label htmlFor={nameFieldId} size={2}>
               Page Name
             </Label>
-            <ErrorsTooltip errors={fieldErrors.name}>
+            <InputErrorsTooltip errors={fieldErrors.name}>
               <TextField
                 state={fieldErrors.name && "invalid"}
                 id={nameFieldId}
@@ -130,13 +106,13 @@ export const NewPageSettings = ({
                   setFieldErrors(({ name, ...rest }) => rest);
                 }}
               />
-            </ErrorsTooltip>
+            </InputErrorsTooltip>
           </Group>
           <Group>
             <Label htmlFor={pathFieldId} size={2}>
               Path
             </Label>
-            <ErrorsTooltip errors={fieldErrors.path}>
+            <InputErrorsTooltip errors={fieldErrors.path}>
               <TextField
                 state={fieldErrors.path && "invalid"}
                 id={pathFieldId}
@@ -146,7 +122,7 @@ export const NewPageSettings = ({
                   setFieldErrors(({ path, ...rest }) => rest);
                 }}
               />
-            </ErrorsTooltip>
+            </InputErrorsTooltip>
           </Group>
           <Group css={{ alignItems: "end" }}>
             <Button type="submit" variant="green" disabled={isSubmitting}>
diff --git a/packages/design-system/src/components/tooltip.tsx b/packages/design-system/src/components/tooltip.tsx
index 211036ad3e..2bcac85c50 100644
--- a/packages/design-system/src/components/tooltip.tsx
+++ b/packages/design-system/src/components/tooltip.tsx
@@ -82,3 +82,31 @@ export const Tooltip = React.forwardRef(function TooltipWrapper(
     </TooltipPrimitive.Root>
   );
 });
+
+export const InputErrorsTooltip = ({
+  errors,
+  children,
+}: {
+  errors: string[] | undefined;
+  children: React.ComponentProps<typeof Tooltip>["children"];
+}) => {
+  const content = errors?.map((error, i) => (
+    <React.Fragment key={i}>
+      {i > 0 && <br />}
+      {error}
+    </React.Fragment>
+  ));
+  return (
+    // We intentionally always pass non empty content to avoid optimization inside Tooltip
+    // where it renders {children} directly if content is empty.
+    // If this optimization accur, the input will remount which will cause focus loss
+    // and current value loss.
+    <Tooltip
+      content={content || " "}
+      open={errors !== undefined && errors.length !== 0}
+      side="right"
+    >
+      {children}
+    </Tooltip>
+  );
+};
diff --git a/packages/design-system/src/index.ts b/packages/design-system/src/index.ts
index 54bb4137dc..4d6604439f 100644
--- a/packages/design-system/src/index.ts
+++ b/packages/design-system/src/index.ts
@@ -24,7 +24,7 @@ export {
 export { Card } from "./components/card";
 export { SimpleToggle } from "./components/simple-toggle";
 export { ScrollArea } from "./components/scrollbar";
-export { Tooltip } from "./components/tooltip";
+export { Tooltip, InputErrorsTooltip } from "./components/tooltip";
 export { Button } from "./components/button";
 export { IconButton } from "./components/icon-button";
 export { Box } from "./components/box";