From b92c53cb606a7260da44ccf620ab31d5c07cc29a Mon Sep 17 00:00:00 2001 From: Jaya Krishna Namburu Date: Thu, 22 Aug 2024 15:02:32 +0530 Subject: [PATCH] fix: transition-timing function update from the dropdown ui (#3989) ## Description Fixes #3957 Looks like there is a props mis-match during the refactoring from shorthand to using long hand properties. Now changed it to use the same convention every where for timing function. ## Steps for reproduction - Add a new transition layer. - Update the `timing` from the transition-ui floating panel. - The updated function from the select should reflect in UI, floating panel content box and in the style-panel layer name. ## Code Review - [ ] hi @kof, I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [x] made a self-review ## Before merging - [x] tested locally and on preview environment (preview dev login: 5de6) --- .../style-panel/sections/transitions/transition-content.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/builder/app/builder/features/style-panel/sections/transitions/transition-content.tsx b/apps/builder/app/builder/features/style-panel/sections/transitions/transition-content.tsx index 97f1987d04..d958e37926 100644 --- a/apps/builder/app/builder/features/style-panel/sections/transitions/transition-content.tsx +++ b/apps/builder/app/builder/features/style-panel/sections/transitions/transition-content.tsx @@ -135,7 +135,7 @@ export const TransitionContent = ({ options: StyleUpdateOptions = { isEphemeral: false } ) => { const value: Array = Object.values({ - ...{ property, duration, delay, timingFunction }, + ...{ property, duration, delay, timing: timingFunction }, ...params, }).filter( (item): item is UnitValue | KeywordValue => item != null