2 Commits

Include renames

Author	SHA1	Message	Date
Ivan StarkovandOleg Isonen	50ff477c97	fix: Project Cloning Broken for Share Links (#4071) ... ## Description closes #4068 <img width="267" alt="image" src="https://github.com/user-attachments/assets/ba0d6287-1391-4f03-b513-cdd07a180a11"> AuthorizationContext - splitted on 4 types, user, token, service, anonymous (before was a mix making it hard to understand permissions) Clone - needs 2 contexts source and destination. ## Steps for reproduction - **Log in as "Vasya Pupkin".** `5de6:vasya@pupkin.com` - **Create a project.** - **Generate a ShareLink.** - **Copy the ShareLink.** `https://p-636d568a-0a42-43d7-9509-8b23607cd5e8-dot-clone-project.development.webstudio.is/?authToken=da7ef507-c91b-4393-a1fe-91848ba533c9&mode=preview` - **Log out.** --- - **Log in as another user.** - **Paste the ShareLink then clone the project.** - **See title etc in clone dialog** <img width="588" alt="image" src="https://github.com/user-attachments/assets/0a04ae59-548e-48ca-871c-d01c91778194"> - **Log out.** --- - **Paste the ShareLink then clone the project.** - **Login process** - **See title etc in clone dialog after the login** <img width="588" alt="image" src="https://github.com/user-attachments/assets/0a04ae59-548e-48ca-871c-d01c91778194"> - **Log out.** --- - **Paste ShareLink in the, go to the menu and copy the clone link.** <img width="417" alt="image" src="https://github.com/user-attachments/assets/5f2911c1-721c-4c36-8ad7-b91052c9f9c1"> `https://clone-project.development.webstudio.is/dashboard?projectToCloneAuthToken=da7ef507-c91b-4393-a1fe-91848ba533c9` --- - **Log in as "Vasya Pupkin".** - **Remove cloning permission for the project.** - **Log out.** --- Paste `https://clone-project.development.webstudio.is/dashboard?projectToCloneAuthToken=da7ef507-c91b-4393-a1fe-91848ba533c9` See "unexpected server error" --- ## Code Review - [ ] hi @kof, I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [ ] made a self-review - [ ] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [ ] tested locally and on preview environment (preview dev login: 5de6) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env` file --------- Co-authored-by: Oleg Isonen <oleg008@gmail.com>	2024-09-07 09:18:40 +03:00
Ivan Starkov	f7487fd1bc	chore: New Builder Auth (#4010) ... ## Description ### Full track https://github.com/webstudio-is/webstudio-saas/issues/317#issuecomment-2289241819 So thoughts about session https://github.com/webstudio-is/webstudio-saas/issues/317#issuecomment-2314515772 Some explanations what is fixed and how https://github.com/webstudio-is/webstudio-saas/issues/317#issue-2465048823 Next PR: - [x] - Old share links auto redirect - [x] - Try make better error message having that current PR will logout all users. ## Steps for reproduction 1. Login using `google login` or `dev login` try to open projects on dahsboard, create new, clone delete etc. 2. Try to open projects on dahboard, see each is on it's own domain and work 3. Try to open project link (without share token) with other user - should fail. 4. Try publish/clone any links and operations. 5. Share project from `userA`: - try to open it with other `userB` - see `userB` is not logged in to that project - try to get using fetch from console anything about `userB` or `userA` i.e rest etc endpoints on apps.webstudio.is domain - try to open incognito, check it works. 6. Open few project, then logout from dashboard, reload project page - See login page - Try to login as same uer - see it works - Or try to login as another user - see auth error ## Code Review - [ ] hi @kof, I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [ ] made a self-review - [ ] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [ ] tested locally and on preview environment (preview dev login: 5de6) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env` file	2024-08-29 12:38:39 +03:00