 Ivan Starkov
|
9d6773f382
|
fix: Incorrect style calculations (#3929)
## Description
Closes #3807
Test cases are here
-
[Failing](https://main.development.webstudio.is/builder/5aecde38-362a-4315-8fd6-df7b94a1baad)
-
[Fixed](https://fix-styles.development.webstudio.is/builder/5aecde38-362a-4315-8fd6-df7b94a1baad)
They are fail on main and works in current PR
### Fixed
- [x] - Body display inline
- [x] - Switching between elements rendered styles for some period
incorrect
- [x] - Selecting display none in menu didn't work
- [x] - Html/Browser styles of invisible elements i.e. `display: none`
wasn't picked
- [x] - Unit sizes of invisible elements wasn't picked
### New
Components with `display: contents` and only text nodes inside now have
outline (using range to get rect)
<img width="643" alt="image"
src="https://github.com/user-attachments/assets/4ee0eff2-66b5-405a-a88a-41191878bbbb">
## Steps for reproduction
-
[Failing](https://main.development.webstudio.is/builder/5aecde38-362a-4315-8fd6-df7b94a1baad)
-
[Fixed](https://fix-styles.development.webstudio.is/builder/5aecde38-362a-4315-8fd6-df7b94a1baad)
## Code Review
- [ ] hi @kof, I need you to do
- conceptual review (architecture, feature-correctness)
- detailed review (read every line)
- test it on preview
## Before requesting a review
- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")
## Before merging
- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
|
2024-08-13 18:24:57 +03:00 |
|