Files
webstudio/apps/builder/app/services/destinations.server.ts
Ivan Starkov 766d7eb95f chore: Add CSRF protection to prevent Canvas script execution vulnerability (#4047)
## Description

how it works
https://github.com/webstudio-is/webstudio-saas/issues/317#issuecomment-2317121292

- attack example
https://p-845e975a-4e84-4186-b312-431f3a6f99ea-dot-main.development.webstudio.is/
- attack fixed
https://p-845e975a-4e84-4186-b312-431f3a6f99ea-dot-csrf.staging.webstudio.is/

corresponding PR #4060 (Add postMessage token to secure against Canvas
script execution)

Additionally

csp on iframe (see comments)
destination checks - to prevent including loaders/pages into iframes

<img width="1015" alt="image"
src="https://github.com/user-attachments/assets/2d8c6840-e195-424e-942f-8b8d05203e18">


## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
2024-09-04 17:08:08 +03:00

36 lines
1.1 KiB
TypeScript

type Destinations = RequestDestination | "empty";
/**
* Prevent loaders of iframe injections like `<iframe src="/rest/data/98b712e5-247c-448d-b68c-8c1681125998">`
* or even cross domain injections like `<iframe src="https://example.com">`
*
* - document: The request is intended to obtain a document or an embedded resource.
* - empty: The request is intended to obtain a resource that is not associated with a document i.e. fetch etc
* - iframe: The request is intended to obtain a resource that is to be embedded in an iframe.
*
* IMPORTANT!!!: In most cases must be used in loaders only.
**/
export const allowedDestinations = (
request: Request,
destinations: Destinations[]
) => {
const destination = request.headers.get("sec-fetch-dest");
if (destination === null) {
return;
}
if (destinations.includes(destination as Destinations)) {
return;
}
throw new Response(null, {
status: 403,
statusText: `Forbidden: Destination ${destination} not allowed`,
});
};
export const isFetchDestination = (request: Request) => {
return request.headers.get("sec-fetch-dest") === "empty";
};